Re: [fossil-users] Side-by-side diff improvement

2013-07-06 Thread Stephan Beal
On Sat, Jul 6, 2013 at 4:51 AM, Joel Bruick j...@joelface.com wrote:

 The purpose of this commit is, as the commit message says, to support
 arbitrary line lengths with synced horizontal scrolling in side-by-side
 diffs. Here's an example of it in action on a test copy of the Fossil repo:
 http://joelface.com/fossil/**fdiff?v1=98aec3c55155011bv2=**
 d74d0c320c455abdsbs=1(youhttp://joelface.com/fossil/fdiff?v1=98aec3c55155011bv2=d74d0c320c455abdsbs=1(youcan
  click anywhere inside a diff and use the left/right arrow keys to
 scroll)


Looks very nice :)



 The diff --tk code also needed to be updated to support the new HTML
 output, and, well, I probably overdid it. I think it's really nice, though,
 so I hope you'll give it a try. (Tip: tab/shift-tab cycles through files.)


Tab/shift-tab for me iterates through all the links on the page?


-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Side-by-side diff improvement

2013-07-06 Thread Jan Danielsson
On 07/06/13 04:51, Joel Bruick wrote:
[---]
 The purpose of this commit is, as the commit message says, to support
 arbitrary line lengths with synced horizontal scrolling in side-by-side
 diffs. Here's an example of it in action on a test copy of the Fossil
 repo:
 http://joelface.com/fossil/fdiff?v1=98aec3c55155011bv2=d74d0c320c455abdsbs=1(you
 can click anywhere inside a diff and use the left/right arrow keys to
 scroll)

   I instantly can't live without it.

-- 
Kind regards,
Jan Danielsson




signature.asc
Description: OpenPGP digital signature
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Side-by-side diff improvement

2013-07-06 Thread Sergei Gavrikov
On Fri, 5 Jul 2013, Joel Bruick wrote:

 Hi all,
 
 I've committed a pretty big changeto the diff
 code(http://www.fossil-scm.org/index.html/info/4081a91c84) , and I'd
 like some other people to take a look at it/test it out before it
 (maybe/hopefully) gets merged into the trunk.
 
 The purpose of this commit is, as the commit message says, to support
 arbitrary line lengths with synced horizontal scrolling in
 side-by-side diffs.  Here's an example of it in action on a test copy
 of the Fossil repo:
 http://joelface.com/fossil/fdiff?v1=98aec3c55155011bv2=d74d0c320c455abdsbs=1(you
 can click anywhere inside a diff and use the left/right arrow keys to
 scroll)
 
Thank you! I looked for this for months. At the end, sbs diff does not
break long UTF-8 lines

  
http://91.208.39.24:8080/lipsum/vdiff?from=6a58f2dd9ada9a81to=8b0984ab46648f58sbs=1

New sbs diff engine with scroll bars looks great (tested on Linux:
Firefox  Google Chrome). I could not live without it.

Sergei
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Side-by-side diff improvement

2013-07-06 Thread Lluís Batlle i Rossell
On Sat, Jul 06, 2013 at 02:34:38PM +0300, Sergei Gavrikov wrote:
 On Fri, 5 Jul 2013, Joel Bruick wrote:
 
  Hi all,
  
  I've committed a pretty big changeto the diff
  code(http://www.fossil-scm.org/index.html/info/4081a91c84) , and I'd
  like some other people to take a look at it/test it out before it
  (maybe/hopefully) gets merged into the trunk.
  
  The purpose of this commit is, as the commit message says, to support
  arbitrary line lengths with synced horizontal scrolling in
  side-by-side diffs.  Here's an example of it in action on a test copy
  of the Fossil repo:
  http://joelface.com/fossil/fdiff?v1=98aec3c55155011bv2=d74d0c320c455abdsbs=1(you
  can click anywhere inside a diff and use the left/right arrow keys to
  scroll)
  
 Thank you! I looked for this for months. At the end, sbs diff does not
 break long UTF-8 lines
 
   
 http://91.208.39.24:8080/lipsum/vdiff?from=6a58f2dd9ada9a81to=8b0984ab46648f58sbs=1
 
 New sbs diff engine with scroll bars looks great (tested on Linux:
 Firefox  Google Chrome). I could not live without it.

In the 'annotate_links' branch, since many months there is a patch that does not
break lines. For us it was inacceptable that a 'diff' could *hide* the
differences, due to some forced wrap length.

It mainly calculated the max line, and took it as the wrap length.

I still have to test this scrollbar proposal (I don't like much scrollbars
inside windows which already have scrollbars...), but at least it goes into a
good direction.

Thank you!
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] Side-by-side diff improvement

2013-07-06 Thread Stephan Beal
On Sat, Jul 6, 2013 at 2:05 PM, Lluís Batlle i Rossell vi...@viric.namewrote:

 I still have to test this scrollbar proposal (I don't like much scrollbars
 inside windows which already have scrollbars...), but at least it goes
 into a
 good direction.


A few hours ago i would have agreed, but he's synchronized the
side-scrolling of the diffs, which makes it quite comfortable. Just do
Shift-mousewheel with your mouse over the diff.

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users