Re: [fossil-users] Fossil crashes on Windows
drh,
Your commit 34dc2a4956 regarding this problem does not seem entirely
correct to me. The return value &p->aFile[i] should be changed for
&pBase->aFile[i] according to my testing (see below).
If I'm mistaking, could you please explain my mistake?
F.
François Vogel said on 13/01/2012 23:17:
François Vogel said on 13/01/2012 23:10:
The loop in which this fossil_stricmp is called is the following:
for(i=0; inFile; i++){
if( fossil_stricmp(zName, p->aFile[i].zName)==0 ){
return &p->aFile[i];
}
}
I would suggest the call to fossil_stricmp should read:
fossil_stricmp(zName, pBase->aFile[i].zName)
instead.
Btw, to be complete, the return value inside the for loop should be
corrected as well. Final suggested version of manifest.c:1249-1253:
for(i=0; inFile; i++){
if( fossil_stricmp(zName, pBase->aFile[i].zName)==0 ){
return &pBase->aFile[i];
}
}
Changing this, compiling and trying my tests again shows the crash is
gone.
Definitely confirmed.
F.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
François Vogel said on 13/01/2012 23:10:
The loop in which this fossil_stricmp is called is the following:
for(i=0; inFile; i++){
if( fossil_stricmp(zName, p->aFile[i].zName)==0 ){
return &p->aFile[i];
}
}
I would suggest the call to fossil_stricmp should read:
fossil_stricmp(zName, pBase->aFile[i].zName)
instead.
Btw, to be complete, the return value inside the for loop should be
corrected as well. Final suggested version of manifest.c:1249-1253:
for(i=0; inFile; i++){
if( fossil_stricmp(zName, pBase->aFile[i].zName)==0 ){
return &pBase->aFile[i];
}
}
Changing this, compiling and trying my tests again shows the crash is
gone.
Definitely confirmed.
F.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
Okay.
It crashes in printf.c:fossil_stricmp(const char *zA, const char *zB),
because zB is a bad pointer.
This is called from manifest.c:manifest_file_find exactly on line
1250, which reads:
if( fossil_stricmp(zName, p->aFile[i].zName)==0 ){
(...)
Now I'm not understanding a lot to what this part of the source code
tries to do (I never saw this code before half an hour ago), but this
looks to me like a copy/paste error from a similar snippet a few lines
above.
The loop in which this fossil_stricmp is called is the following:
for(i=0; inFile; i++){
if( fossil_stricmp(zName, p->aFile[i].zName)==0 ){
return &p->aFile[i];
}
}
I would suggest the call to fossil_stricmp should read:
fossil_stricmp(zName, pBase->aFile[i].zName)
instead.
Changing this, compiling and trying my tests again shows the crash is
gone.
F.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
François Vogel said on 13/01/2012 22:33: Seems I have built a release version despite CFLAGS = -nologo -MT -O2 -Zi Forgot the linker flags, sorry for the noise. F. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
Lluís Batlle i Rossell said on 13/01/2012 22:20: In "Open -> Project", you can choose an exe. Set the arguments in the project, the working directory, and press 'play'. That will happen inside the debugger. Great! I see and have tried. It turns out I did not properly change the makefile.msc to include debug symbols. Seems I have built a release version despite CFLAGS = -nologo -MT -O2 -Zi How would you modify the makefile to build a debug version of fossil? And for crashes, you should be able to install VS2010 as the just-in-time debugger (to be called on crashes). Any details on this, please? Is this possible with the Express version of VS2008 or VS2010 (can't afford the paid version)? Seems not if I believe this page: http://msdn.microsoft.com/en-us/library/5hs4b7a6.aspx However the latter may be wrong. Thanks, F. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
On Fri, Jan 13, 2012 at 10:15:27PM +0100, François Vogel wrote: > Out of ideas I'm looking at the debugging of the issue. > > I could compile fossil from source (on Windows, VS 2010). Now, how > can I debug the problem, considering it crashes before I can attach > the debugger to the process? Any advice, perhaps? In "Open -> Project", you can choose an exe. Set the arguments in the project, the working directory, and press 'play'. That will happen inside the debugger. And for crashes, you should be able to install VS2010 as the just-in-time debugger (to be called on crashes). Regards, Lluís. > fvogeln...@free.fr said on 11/01/2012 17:00: > > > >Running fossil revert pops up the standard wrong pointer messagebox from > >Windows (here running XP): > > > > > >Instruction at "0x0042eae9" use memory address "0x7c00ae00". Can't be "read". > >Click on "OK" to exit program. > > > > > >On clicking OK I get the rest in my cmd window: > > > > > >D:\ME\tcltk-fossil\tk-fossil>fossil changes > >EDITED generic/tkTextMark.c > >EDITED tests/textMark.test > > > >D:\ME\tcltk-fossil\tk-fossil>fossil revert > >D:\ME\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot > >rollback transaction - SQL statements in progress > >D:\ME\fossil.exe: cannot rollback transaction - SQL statements in progress > >ROLLBACK > > > >If you have recently updated your fossil executable, you might > >need to run "fossil all rebuild" to bring the repository > >schemas up to date. > > > > > >I tried the solution suggested in this message, but at no avail. > ___ > fossil-users mailing list > fossil-users@lists.fossil-scm.org > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
Out of ideas I'm looking at the debugging of the issue. I could compile fossil from source (on Windows, VS 2010). Now, how can I debug the problem, considering it crashes before I can attach the debugger to the process? Any advice, perhaps? Thanks, F. fvogeln...@free.fr said on 11/01/2012 17:00: Running fossil revert pops up the standard wrong pointer messagebox from Windows (here running XP): Instruction at "0x0042eae9" use memory address "0x7c00ae00". Can't be "read". Click on "OK" to exit program. On clicking OK I get the rest in my cmd window: D:\ME\tcltk-fossil\tk-fossil>fossil changes EDITED generic/tkTextMark.c EDITED tests/textMark.test D:\ME\tcltk-fossil\tk-fossil>fossil revert D:\ME\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot rollback transaction - SQL statements in progress D:\ME\fossil.exe: cannot rollback transaction - SQL statements in progress ROLLBACK If you have recently updated your fossil executable, you might need to run "fossil all rebuild" to bring the repository schemas up to date. I tried the solution suggested in this message, but at no avail. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
Isn't this really a crash of the fossil executable? Running fossil revert pops up the standard wrong pointer messagebox from Windows (here running XP): Instruction at "0x0042eae9" use memory address "0x7c00ae00". Can't be "read". Click on "OK" to exit program. On clicking OK I get the rest in my cmd window: D:\ME\tcltk-fossil\tk-fossil>fossil changes EDITED generic/tkTextMark.c EDITED tests/textMark.test D:\ME\tcltk-fossil\tk-fossil>fossil revert D:\ME\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot rollback transaction - SQL statements in progress D:\ME\fossil.exe: cannot rollback transaction - SQL statements in progress ROLLBACK If you have recently updated your fossil executable, you might need to run "fossil all rebuild" to bring the repository schemas up to date. I tried the solution suggested in this message, but at no avail. Francois -Original Message- De: "Mark Janssen" À: "Fossil SCM user's discussion" Envoyé: Mercredi 11 Janvier 2012 13:59:13 Objet: Re: [fossil-users] Fossil crashes on Windows Unless this is not the whole story, this is not a crash, Fossil gives an error. Did you try the solution suggested in the error message? Try a "fossil rebuild" from the checkout. Mark -Original Message- From: fossil-users-boun...@lists.fossil-scm.org [mailto:fossil-users-boun...@lists.fossil-scm.org] On Behalf Of François Vogel Sent: dinsdag 10 januari 2012 22:06 To: fossil-users@lists.fossil-scm.org Subject: [fossil-users] Fossil crashes on Windows Hi all, On Windows Vista, I get repeatable crashes of fossil (application stops working and brutally crashes). This happens when running fossil revert (whatever the rest of the command is), for instance: C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossi l changes EDITED ../generic/tkTextMark.c EDITED textMark.test C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossi l revert textMark.test C:\Users\francois\Documents\Development\tcltk-fossil\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot rollback transaction - SQL statements in progress C:\Users\francois\Documents\Development\tcltk-fossil\fossil.exe: cannot rollback transaction - SQL statements in progress ROLLBACK If you have recently updated your fossil executable, you might need to run "fossil all rebuild" to bring the repository schemas up to date. C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossi l version This is fossil version 1.21 [002580c50d] 2011-12-13 13:53:56 UTC Even when providing no argument to fossil revert, I get the same crash of fossil. This happens also when fossil diff FILE, but not when fossil diff with no additional argument. I have looked at the fossil tickets tracker, but did not find anything obviously related. Thanks for any hint, Francois ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
Unless this is not the whole story, this is not a crash, Fossil gives an error. Did you try the solution suggested in the error message? Try a "fossil rebuild" from the checkout. Mark -Original Message- From: fossil-users-boun...@lists.fossil-scm.org [mailto:fossil-users-boun...@lists.fossil-scm.org] On Behalf Of François Vogel Sent: dinsdag 10 januari 2012 22:06 To: fossil-users@lists.fossil-scm.org Subject: [fossil-users] Fossil crashes on Windows Hi all, On Windows Vista, I get repeatable crashes of fossil (application stops working and brutally crashes). This happens when running fossil revert (whatever the rest of the command is), for instance: C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossi l changes EDITED ../generic/tkTextMark.c EDITED textMark.test C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossi l revert textMark.test C:\Users\francois\Documents\Development\tcltk-fossil\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot rollback transaction - SQL statements in progress C:\Users\francois\Documents\Development\tcltk-fossil\fossil.exe: cannot rollback transaction - SQL statements in progress ROLLBACK If you have recently updated your fossil executable, you might need to run "fossil all rebuild" to bring the repository schemas up to date. C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossi l version This is fossil version 1.21 [002580c50d] 2011-12-13 13:53:56 UTC Even when providing no argument to fossil revert, I get the same crash of fossil. This happens also when fossil diff FILE, but not when fossil diff with no additional argument. I have looked at the fossil tickets tracker, but did not find anything obviously related. Thanks for any hint, Francois ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Fossil crashes on Windows
On Windows Vista, I get repeatable crashes of fossil (application stops working and brutally crashes). This happens when running fossil revert (whatever the rest of the command is) Happens for me on a second machine, same repo (Tk toolkit project). Does not happen with the fossil-scm repository. Clueless. F. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] Fossil crashes on Windows
Hi all, On Windows Vista, I get repeatable crashes of fossil (application stops working and brutally crashes). This happens when running fossil revert (whatever the rest of the command is), for instance: C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossil changes EDITED ../generic/tkTextMark.c EDITED textMark.test C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossil revert textMark.test C:\Users\francois\Documents\Development\tcltk-fossil\fossil.exe: SQLITE_BUSY: statement aborts at 2: [ROLLBACK] cannot rollback transaction - SQL statements in progress C:\Users\francois\Documents\Development\tcltk-fossil\fossil.exe: cannot rollback transaction - SQL statements in progress ROLLBACK If you have recently updated your fossil executable, you might need to run "fossil all rebuild" to bring the repository schemas up to date. C:\Users\francois\Documents\Development\tcltk-fossil\tk-fossil\tests>fossil version This is fossil version 1.21 [002580c50d] 2011-12-13 13:53:56 UTC Even when providing no argument to fossil revert, I get the same crash of fossil. This happens also when fossil diff FILE, but not when fossil diff with no additional argument. I have looked at the fossil tickets tracker, but did not find anything obviously related. Thanks for any hint, Francois ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
