Re: [fossil-users] Patch for setup.c - Was: "fossil http" doubts

[Richard Hipp]

Thanks.  Alternative fix checked in.

On 6/8/17, Johan Kuuse  wrote:
> Found another one in tkt.c
>
> BR,
> Johan
>
> On Thu, Jun 8, 2017 at 7:10 PM, Richard Hipp  wrote:
>> On 6/8/17, Johan Kuuse  wrote:
>>> Hi,
>>>
>>> Playing around with 'fossil test-http' I found an error in the
>>> /setup_adunit output.
>>> Patch attached,
>>>
>>
>> Good catch.  Fix is checked in.
>> --
>> D. Richard Hipp
>> d...@sqlite.org
>


-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Patch for setup.c - Was: "fossil http" doubts

[Johan Kuuse]

Found another one in tkt.c

BR,
Johan

On Thu, Jun 8, 2017 at 7:10 PM, Richard Hipp  wrote:
> On 6/8/17, Johan Kuuse  wrote:
>> Hi,
>>
>> Playing around with 'fossil test-http' I found an error in the
>> /setup_adunit output.
>> Patch attached,
>>
>
> Good catch.  Fix is checked in.
> --
> D. Richard Hipp
> d...@sqlite.org
Index: src/tkt.c
==
--- src/tkt.c
+++ src/tkt.c
@@ -749,18 +749,18 @@
 cgi_redirectf("tktview?name=%T", zName);
   }
   style_header("Edit Ticket");
   if( zName==0 || (nName = strlen(zName))<4 || nName>UUID_SIZE
   || !validate16(zName,nName) ){
-@ Not a valid ticket id: \"%h(zName)\"
+@ Not a valid ticket id: %h(zName)
 style_footer();
 return;
   }
   nRec = db_int(0, "SELECT count(*) FROM ticket WHERE tkt_uuid GLOB '%q*'",
 zName);
   if( nRec==0 ){
-@ No such ticket: \"%h(zName)\"
+@ No such ticket: %h(zName)
 style_footer();
 return;
   }
   if( nRec>1 ){
 @ %d(nRec) tickets begin with:

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Patch for setup.c - Was: "fossil http" doubts

[Richard Hipp]

On 6/8/17, Johan Kuuse  wrote:
> Hi,
>
> Playing around with 'fossil test-http' I found an error in the
> /setup_adunit output.
> Patch attached,
>

Good catch.  Fix is checked in.
-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

[fossil-users] Patch for setup.c - Was: "fossil http" doubts

[Johan Kuuse]

Hi,

Playing around with 'fossil test-http' I found an error in the
/setup_adunit output.
Patch attached,

BR,
Johan

On Wed, Jun 7, 2017 at 4:16 PM, Johan Kuuse  wrote:
> On Wed, Jun 7, 2017 at 3:50 PM, Warren Young  wrote:
>> On Jun 7, 2017, at 7:42 AM, Johan Kuuse  wrote:
>>>
>>> 2. I want to validate the web pages: Validate the HTML, check for
>>> broken links, etc, using for example the W3C validation tools.
>>
>> If you’re using something like curl or wget to pull the web pages, there’s 
>> typically a way to set up a “cookie jar” so that you can log in with one 
>> HTTP request, then make the remaining HTTP requests as that user, with the 
>> HTTP client automatically sending the necessary session cookie.
>
>
> Thanks for the suggestion, but I wanted to avoid both a running web
> server and the cookie jar setup.
> "fossil test-http" made my day.
> Get the HTML (including the HTTP Response header) from all Fossil
> built-in web pages, using the output from 'fossil help -w' as a list:
>
> mkdir -p fhtml && for w in `fossil help -w | xargs printf "%s\n"`; do
> printf "GET $w HTTP/1.0\n\n" | fossil test-http > fhtml/${w}.html;done
>
> BR,
> Johan
Index: src/setup.c
==
--- src/setup.c
+++ src/setup.c
@@ -1723,11 +1723,11 @@
   @ If the "Right-Column Ad-Unit" is blank, the "Banner Ad-Unit" is used on all pages.
   @ Suggested CSS changes:
   @ 
   @ div.adunit_banner {
   @   margin: auto;
-  @   width: 100%;
+  @   width: 100%%;
   @ }
   @ div.adunit_right {
   @   float: right;
   @ }
   @ div.adunit_right_container {

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users