Re: [fossil-users] andygoth-user-reports
Thus said jungle Boogie on Sun, 17 May 2015 21:22:21 -0700: To me, this list says Mr. Bradford did some kind of check-in with these files listed here. A checkin does not necessarily mean that one made changes to a specific file; it means that a specific file was part of a checkin. For example, a merge from trunk into a feature branch will bring in changes that were made by others, however, when committed, the merge will have a checkin that includes those files. https://www.fossil-scm.org/index.html/finfo?name=src/sqlite3.c I don't see any check-ins for user andybradford using Firefox's find. This is because I have not made any changes to those files. This is not the same thing as making checkins that include that file. Hopefully this clarifies it some... Andy -- TAI64 timestamp: 4000555a1609 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] andygoth-user-reports
On 18 May 2015 at 09:40, Andy Bradford amb-fos...@bradfords.org wrote: A checkin does not necessarily mean that one made changes to a specific file; it means that a specific file was part of a checkin. For example, a merge from trunk into a feature branch will bring in changes that were made by others, however, when committed, the merge will have a checkin that includes those files. Got it, cool. Thanks for the clarification! -- --- inum: 883510009027723 sip: jungleboo...@sip2sip.info xmpp: jungle-boo...@jit.si ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] andygoth-user-reports
Thus said jungle Boogie on Mon, 18 May 2015 10:45:54 -0700: Got it, cool. Thanks for the clarification! Perhaps... Andy Goth actually thinks the behavior is a bug and provided a link to some steps to cause the behavior. I'm not sure without further investigation. Andy -- TAI64 timestamp: 4000555a7b4e ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] andygoth-user-reports
Yeah, I first saw the issue when using the file report, filtered by user (new feature on this branch), to see what all files I've ever touched. I saw a great many I'd never have expected, and they're not actually included in the changed file listings of any of my commits. I don't think it makes sense to attribute to me changes to files that were done by others just because I merged after them. On May 18, 2015 6:52 PM, Andy Bradford amb-fos...@bradfords.org wrote: Thus said jungle Boogie on Mon, 18 May 2015 10:45:54 -0700: Got it, cool. Thanks for the clarification! Perhaps... Andy Goth actually thinks the behavior is a bug and provided a link to some steps to cause the behavior. I'm not sure without further investigation. Andy -- TAI64 timestamp: 4000555a7b4e ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] andygoth-user-reports
On 17 May 2015 at 19:51, Andy Goth andrew.m.g...@gmail.com wrote: Please give andygoth-user-reports a whirl and report any positive or negative impressions or experiences. I don't think this is anything related to your specific branch, but I observed it as a result of your branch so I'm bringing it up. So with your branch, I'm here: /reports?user=andybradfordview=byfile You should see an extensive list of check-ins by Mr. Bradford starting with src/xfer.c. To me, this list says Mr. Bradford did some kind of check-in with these files listed here. This holds true for the first nine, but what about that src/sqlite3.c file, which would be this page: https://www.fossil-scm.org/index.html/finfo?name=src/sqlite3.c I don't see any check-ins for user andybradford using Firefox's find. But there I do: https://www.fossil-scm.org/index.html/timeline?n=200y=civ=1c=2015-03-21+23%3A34%3A57nd=u=andybradford I don't think this is any kind of bug but there may be confusion as why a committer is showing up for a file but you can't find any check-ins in the finfo page for that user. FWIW, I like the work you're doing! Thanks. -- --- inum: 883510009027723 sip: jungleboo...@sip2sip.info xmpp: jungle-boo...@jit.si ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] andygoth-user-reports
On 5/17/2015 11:22 PM, jungle Boogie wrote: This holds true for the first nine, but what about that src/sqlite3.c file, which would be this page: https://www.fossil-scm.org/index.html/finfo?name=src/sqlite3.c I don't see any check-ins for user andybradford using Firefox's find. But there I do: https://www.fossil-scm.org/index.html/timeline?n=200y=civ=1c=2015-03-21+23%3A34%3A57nd=u=andybradford I don't think this is any kind of bug but there may be confusion as why a committer is showing up for a file but you can't find any check-ins in the finfo page for that user. This is indeed a bug. See this email for analysis and another symptom: http://www.mail-archive.com/fossil-users@lists.fossil-scm.org/msg20586.html FWIW, I like the work you're doing! Thanks. You're welcome. At the moment I can't get to the work I'm supposed to be doing, so I decided to hack Fossil instead. -- Andy Goth | andrew.m.goth/at/gmail/dot/com signature.asc Description: OpenPGP digital signature ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] andygoth-user-reports
The andygoth-user-reports branch does a ton of cleanup in the reports page, mostly to the way users are handled. The weekday and file reports didn't even support user filtering at all. I also added the ability to type the user name directly rather than having to find it in the users report then go to the report actually desired. In addition, I fixed the type selection links to not lose the user. Please give andygoth-user-reports a whirl and report any positive or negative impressions or experiences. In the process of testing the user filtering on files, I noticed the file change counts are wrong. I documented this in another email. The problem is not fixed yet, and I suspect the correction, whatever it is, won't take effect until the next rebuild. I hope no one minds me spamming everyone with new code. :^) It's pretty much all on branches so we will have the ability to decide what does and does not make it into the next release. Though I must say that I'm coding up the stuff I would like to be in the next release. Not up to me though. I'm just writing code to scratch itches and learn more about the Fossil guts. -- Andy Goth | andrew.m.goth/at/gmail/dot/com signature.asc Description: OpenPGP digital signature ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
