Hello,

I tried the new "repolist" feature of ui/server/cgi. Neat addition.

There is  a minor caveat, though: It does not work together with the
"notfound" setting. Trying to get the repository listing on "/" redirects
to the "notfound" URL, because this one is checked first. Wouldn't it be
better to change this order, like e.g. so?

Index: src/main.c
==================================================================
--- src/main.c
+++ src/main.c
@@ -1546,16 +1546,16 @@
         zRepo[j] = '.';
       }

       if( szFile<1024 ){
         set_base_url(0);
-        if( zNotFound ){
-          cgi_redirect(zNotFound);
-        }else if( strcmp(zPathInfo,"/")==0
+        if( strcmp(zPathInfo,"/")==0
                   && allowRepoList
                   && repo_list_page() ){
           /* Will return a list of repositories */
+        }else if( zNotFound ){
+          cgi_redirect(zNotFound);
         }else{
 #ifdef FOSSIL_ENABLE_JSON
           if(g.json.isJsonMode){
             json_err(FSL_JSON_E_RESOURCE_NOT_FOUND,NULL,1);
             return;


It works for me, and allows even for setting it up to list the repositories
on a notfound by using a dot as URL "notfound: ."

Fossil version [3dbe76fca9] 2015-03-03 17:16:54

Regards,
Marcel
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to