Re: [fossil-users] tree-view of files

2014-01-07 Thread Michai Ramakers
On 7 January 2014 00:50, Joel Bruick j...@joelface.com wrote:
 Joel Bruick wrote:

 I'm going to add some javascript for expanding/collapsing directories. Then
 the tree-view will be practically perfect in every way.

 And... done. For added convenience, you can also expand/collapse every
 subdirectory at once by clicking the root directory.

even works very nice when viewed with links; I hadn't expected that, really.

Michai
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


[fossil-users] tree-view of files

2014-01-06 Thread Michai Ramakers
Hello,

I noticed that when clicking on 'files' in a checkin-summary (e.g.
random checkin https://www.fossil-scm.org/index.html/info/f83e0d2123),
tree-view is now displayed instead of legacy flat-dir.

No complaints here, but was this intentional? (Is 'tree' the new 'dir'..?)

Michai
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Michai Ramakers
On 6 January 2014 11:59, Michai Ramakers m.ramak...@gmail.com wrote:
 Hello,

 I noticed that when clicking on 'files' in a checkin-summary (e.g.
 random checkin https://www.fossil-scm.org/index.html/info/f83e0d2123),
 tree-view is now displayed instead of legacy flat-dir.

 No complaints here, but was this intentional? (Is 'tree' the new 'dir'..?)

actually... one obvious drawback is that due to expanding subdirs, the
actual 1st-level files/subdirs are now scattered. Is there a way to
use 'dir' as default, and 'tree'-view only when explicitly telling it
to? (TBH I haven't read all of the tree-view details yet, chances are
I missed it or am doing something wrong.)

Michai
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Joel Bruick

Michai Ramakers wrote:

On 6 January 2014 11:59, Michai Ramakersm.ramak...@gmail.com  wrote:

Hello,

I noticed that when clicking on 'files' in a checkin-summary (e.g.
random checkin https://www.fossil-scm.org/index.html/info/f83e0d2123),
tree-view is now displayed instead of legacy flat-dir.

No complaints here, but was this intentional? (Is 'tree' the new 'dir'..?)


actually... one obvious drawback is that due to expanding subdirs, the
actual 1st-level files/subdirs are now scattered. Is there a way to
use 'dir' as default, and 'tree'-view only when explicitly telling it
to? (TBH I haven't read all of the tree-view details yet, chances are
I missed it or am doing something wrong.)

Michai


Yeah, having everything expanded can be annoying. In the Fossil repo in 
particular, compat/zlib/ is huge. You have to scroll halfway down the 
page to get to src/, where most of the work gets done.


I'm going to add some javascript for expanding/collapsing directories. 
Then the tree-view will be practically perfect in every way.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Joel Bruick

Joel Bruick wrote:
I'm going to add some javascript for expanding/collapsing directories. 
Then the tree-view will be practically perfect in every way.


And... done. For added convenience, you can also expand/collapse every 
subdirectory at once by clicking the root directory.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Andy Bradford
Thus said Joel Bruick on Mon, 06 Jan 2014 18:50:57 -0500:

 And... done. For added convenience, you can also expand/collapse every
 subdirectory at once by clicking the root directory.

I wonder if  it would be a  good idea to change the  class for tree-view
directories from ``dir'' to ``treedir''  so different CSS can be applied
to the different modes of viewing the files?

At  the moment,  I use  the  following CSS  to put  a  / at  the end  of
directories  for  the  flat-view,  but  it  conflicts  a  bit  with  the
tree-view:

li.dir:after {
content: '/';
}

Other than this, it looks better and works well.

Thanks,

Andy
-- 
TAI64 timestamp: 400052cb69d5


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Richard Hipp
On Mon, Jan 6, 2014 at 6:50 PM, Joel Bruick j...@joelface.com wrote:

 Joel Bruick wrote:

 I'm going to add some javascript for expanding/collapsing directories.
 Then the tree-view will be practically perfect in every way.


 And... done. For added convenience, you can also expand/collapse every
 subdirectory at once by clicking the root directory.


Tnx.  That works great.  It's on the server now, after a few modifications,
such as adding the expand query parameter which causes the display to
start in an expanded state.

One issue I have:  There is now no longer a way to get a tree for a
subdirectory by itself, except to enter the name= query parameter
manually in the URL.  For example, you can no longer get to:


http://www.fossil-scm.org/fossil/tree?ci=trunkname=compat/tcl-8.6expand

just by clicking.  Then again, maybe I'm the only person who ever wants to
do that so the missing capability is not important...


-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Andy Bradford
Thus said Richard Hipp on Mon, 06 Jan 2014 21:48:40 -0500:

 just by clicking. Then again, maybe I'm the only person who ever wants
 to do that so the missing capability is not important...

I think this is easily shown to be problematic by simply browsing to:

http://www.fossil-scm.org/fossil/dir?ci=13c71a97feb26586name=src

Then click Tree-View which gives:

http://www.fossil-scm.org/fossil/dir?ci=13c71a97feb26586name=srctype=tree

One  has to  manually add  expand  at this  point to  reveal the  files.
Perhaps  Fossil should  check it's  query parameters  when Tree-View  is
clicked  and  if  ``name''  is  in  the  set  of  parameters  it  should
automatically add expand?

Thanks,

Andy
-- 
TAI64 timestamp: 400052cb6e19


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Andy Bradford
Thus said Andy Bradford on 06 Jan 2014 20:01:13 -0700:

 Then click Tree-View which gives:
 
 http://www.fossil-scm.org/fossil/dir?ci=13c71a97feb26586name=srctype=tree
 
 One has  to manually  add expand  at this point  to reveal  the files.
 Perhaps Fossil  should check it's  query parameters when  Tree-View is
 clicked  and  if ``name''  is  in  the  set  of parameters  it  should
 automatically add expand?

Actually, perhaps this is just a  bug with the Javascript? Why shouldn't
I  be able  to click  on the  directory node  at that  URL to  cause the
directory contents  to expand? Maybe I  should look more closely  at the
code to see what is being generated...

Andy
-- 
TAI64 timestamp: 400052cb6f30


___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Joel Bruick

Richard Hipp wrote:
Tnx.  That works great.  It's on the server now, after a few 
modifications, such as adding the expand query parameter which 
causes the display to start in an expanded state.


One issue I have:  There is now no longer a way to get a tree for a 
subdirectory by itself, except to enter the name= query parameter 
manually in the URL.  For example, you can no longer get to:


http://www.fossil-scm.org/fossil/tree?ci=trunkname=compat/tcl-8.6expand 
http://www.fossil-scm.org/fossil/tree?ci=trunkname=compat/tcl-8.6expand


just by clicking.  Then again, maybe I'm the only person who ever 
wants to do that so the missing capability is not important...


You can still middle/right click on the links to open the subdirectory 
pages, if you really need to scratch that itch.

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] tree-view of files

2014-01-06 Thread Baruch Burstein
On Tue, Jan 7, 2014 at 4:48 AM, Richard Hipp d...@sqlite.org wrote:


 Tnx.  That works great.  It's on the server now, after a few
 modifications, such as adding the expand query parameter which causes the
 display to start in an expanded state.

 One issue I have:  There is now no longer a way to get a tree for a
 subdirectory by itself, except to enter the name= query parameter
 manually in the URL.  For example, you can no longer get to:


 http://www.fossil-scm.org/fossil/tree?ci=trunkname=compat/tcl-8.6expand

 just by clicking.  Then again, maybe I'm the only person who ever wants to
 do that so the missing capability is not important...

 Bug: In the above link, try clicking on the compat directory name in the
first line. It will supposedly take you to the compat listing, but it will
be empty
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users