[fossil-users] window opened by `diff --tk' is editable
not a big deal but slightly irritating: the tk-window opened by `diff --tk' is editable, i..e one can modify the displayed diff text (w/o any real effect, of course). I don't know Tk, but maybe there's an option to make the window readonly in order to avoid any potential confusion (since many graphical diff/merge tools _do_ allow to edit such diffs)? I don't presume this info is relevant here, but it happens on a current mac with fossil 1.26 j. -- Using Opera's revolutionary email client: http://www.opera.com/mail/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] window opened by `diff --tk' is editable
On Tue, Aug 20, 2013 at 10:57 AM, j. van den hoff veedeeh...@googlemail.com wrote: not a big deal but slightly irritating: the tk-window opened by `diff --tk' is editable, i..e one can modify the displayed diff text (w/o any real effect, of course). I don't know Tk, but maybe there's an option to make the window readonly in order to avoid any potential confusion (since many graphical diff/merge tools _do_ allow to edit such diffs)? I don't presume this info is relevant here, but it happens on a current mac with fossil 1.26 I just tried it here and couldn't get it to edit. Maybe this has already been fixed? j. -- Using Opera's revolutionary email client: http://www.opera.com/mail/ __**_ fossil-users mailing list fossil-users@lists.fossil-scm.**org fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:**8080/cgi-bin/mailman/listinfo/**fossil-usershttp://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] window opened by `diff --tk' is editable
On Tue, 20 Aug 2013 17:31:24 +0200, Richard Hipp d...@sqlite.org wrote: On Tue, Aug 20, 2013 at 10:57 AM, j. van den hoff veedeeh...@googlemail.com wrote: not a big deal but slightly irritating: the tk-window opened by `diff --tk' is editable, i..e one can modify the displayed diff text (w/o any real effect, of course). I don't know Tk, but maybe there's an option to make the window readonly in order to avoid any potential confusion (since many graphical diff/merge tools _do_ allow to edit such diffs)? I don't presume this info is relevant here, but it happens on a current mac with fossil 1.26 I just tried it here and couldn't get it to edit. Maybe this has already been fixed? you are right. it happenend with fossil version 1.26 [c9cb6e7293] 2013-06-18 21:09:23 UTC but current leaf revision produces a quite differently looking Tk window not exhibiting the reported problem anymore. indeed, things are moving fast with fossil ;-) however, regarding the _new_ Tk window (as of fossil version 1.26 [13161f39aa] 2013-08-20 11:29:01 UTC) I see the following issues: compared to the old one, font size now is at the limit of comfortable readability, i.e. is too small (I could send you a screen shot offline, if you are interested...) and the new central Files drop-down menu (I presume that's what it should be?) is broken does in fact _not_ drop down but opens a new small Tk window about the size of the menu button itself, containing the file name and three inactive close/minimize/maximize buttons. it disappears when clicking somewhere else in the first Tk window but not when releasing/clicking the menu button. so apart from the spurious edit feature I find the alt variant more usable (the font issue alone leads to this) and also cleaner (the black horizontal and vertical bars are distracting in my view and the bare bones `sdiff' look of the old variant was more in accord with my taste). j. j. -- Using Opera's revolutionary email client: http://www.opera.com/mail/ __**_ fossil-users mailing list fossil-users@lists.fossil-scm.**org fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:**8080/cgi-bin/mailman/listinfo/**fossil-usershttp://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- Using Opera's revolutionary email client: http://www.opera.com/mail/ ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] window opened by `diff --tk' is editable
On Tue, Aug 20, 2013 at 6:22 PM, j. van den hoff veedeeh...@googlemail.comwrote: indeed, things are moving fast with fossil ;-) This year is turning out to be one of the busier ones: http://fossil-scm.org/index.html/reports?view=byyear and recent activity has been pretty high: http://fossil-scm.org/index.html/reports?view=byweek however, regarding the _new_ Tk window (as of fossil version 1.26 [13161f39aa] 2013-08-20 11:29:01 UTC) I see the following issues: LOL! i'll stay out of this one, except to say that i would like to see a commit button directly in the tk diff. And a way to map that to the gdiff-command, so that (f gdiff) becomes (f diff --tk). But this netbook is too slow for further hacking on fossil tonight... -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] window opened by `diff --tk' is editable
Hi j., I'm responsible for the new and improved Tk diff and would like to look into these problems. Send any screenshots and/or hate mail my way. I'd also like to know what OS and Tcl/Tk version you're using. j. van den hoff wrote: however, regarding the _new_ Tk window (as of fossil version 1.26 [13161f39aa] 2013-08-20 11:29:01 UTC) I see the following issues: compared to the old one, font size now is at the limit of comfortable readability, i.e. is too small (I could send you a screen shot offline, if you are interested...) and the new central Files drop-down menu (I presume that's what it should be?) is broken does in fact _not_ drop down but opens a new small Tk window about the size of the menu button itself, containing the file name and three inactive close/minimize/maximize buttons. it disappears when clicking somewhere else in the first Tk window but not when releasing/clicking the menu button. Yeah, the Files drop-down is a hack to work around problems with the standard Tk menu widget when you have a diff with many files. It should pop up a listbox just below the menu button that will allow you to select the file you want to jump to. It shouldn't be showing the window decoration/buttons, though. so apart from the spurious edit feature I find the alt variant more usable (the font issue alone leads to this) and also cleaner (the black horizontal and vertical bars are distracting in my view and the bare bones `sdiff' look of the old variant was more in accord with my taste). I'm not married to any of the styling. If Richard or somebody else wants to change it to whatever other people prefer, be my guest. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
