Re: [fpc-pascal] fcl-passrc errors

[Sven Barth via fpc-pascal]

Am 13.10.2019 um 23:19 schrieb Ryan Joseph:



On Oct 13, 2019, at 11:11 AM, Sven Barth via fpc-pascal 
 wrote:

Then specialize the list with the correct type.

This issue *will* be fixed and is not up to discussion.


Here’s some code from the parser today. TFPList is being used because it’s a 
generic storage for various different kinds of classes.

   public
 Declarations: TFPList; // list of TPasElement
 // Declarations contains all the following:
 Attributes, // TPasAttributes
 Classes,// TPasClassType, TPasRecordType
 Consts, // TPasConst
 ExportSymbols,// TPasExportSymbol
 Functions,  // TPasProcedure
 Properties, // TPasProperty
 ResStrings, // TPasResString
 Types,  // TPasType, except TPasClassType, TPasRecordType
 Variables   // TPasVariable, not descendants
   : TFPList;

What do I do when I want to iterate over this now? I know that these types all 
descend from TPasElement so I want to use that, but no, the compiler complains 
I *must* use a pointer for the iterator. Why can’t I as the programmer tell the 
for loop I know what the enumerator is going to return?


Because the iterator returns a Pointer and not whatever you think it 
might return. If you know it's something else, you cast that inside the 
loop.




var
   element: TPasElement;
begin
   // ERROR!
   for element in module.InterfaceSection.Functions do
 begin
 end;


I guess we’re supposed to just do our typecasts inside the loop now but how is 
this any better? Sorry I’m really not getting this.
It's not about better or not, it's about correct: The for-in-loop 
expects a variable, not an expression, just like the normal for-loop 
does. And as this behavior is accidental it could just as well be that 
this breaks behind the scene. For example if we should optimize for-in 
some time in the future. Or it might trigger some runtime checks.


Regards,
Sven
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Ryan Joseph]

> On Oct 13, 2019, at 11:11 AM, Sven Barth via fpc-pascal 
>  wrote:
> 
> Then specialize the list with the correct type. 
> 
> This issue *will* be fixed and is not up to discussion. 
> 

Here’s some code from the parser today. TFPList is being used because it’s a 
generic storage for various different kinds of classes.

  public
Declarations: TFPList; // list of TPasElement
// Declarations contains all the following:
Attributes, // TPasAttributes
Classes,// TPasClassType, TPasRecordType
Consts, // TPasConst
ExportSymbols,// TPasExportSymbol
Functions,  // TPasProcedure
Properties, // TPasProperty
ResStrings, // TPasResString
Types,  // TPasType, except TPasClassType, TPasRecordType
Variables   // TPasVariable, not descendants
  : TFPList;

What do I do when I want to iterate over this now? I know that these types all 
descend from TPasElement so I want to use that, but no, the compiler complains 
I *must* use a pointer for the iterator. Why can’t I as the programmer tell the 
for loop I know what the enumerator is going to return?

var
  element: TPasElement;
begin
  // ERROR!
  for element in module.InterfaceSection.Functions do
begin
end;


I guess we’re supposed to just do our typecasts inside the loop now but how is 
this any better? Sorry I’m really not getting this.

var
  element: pointer;
begin
  for element in module.InterfaceSection.Functions do
begin
  writeln(TPasElement(element).Name, ‘’, TPasElement(element).DoSomething);
end;

Regards,
Ryan Joseph

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc method/function invocations

[Michael Van Canneyt]

On Sun, 13 Oct 2019, Ryan Joseph wrote:


One of my tasks for the language server is determining “references” to a 
symbol, which means for functions I need to know all the times they were called.

Given the syntax tree the parser creates how do I know when a function was
called?  I see there is a TPasImplSimple that seems related but I’m not
sure exactly.  It’s probably possible that it’s not always possible to
know because there are unresolved types so: a := clss.DoThis; maybe be a
function call or accessing a proeprty/member variable.


for this you need the resolver. The resolver resolves symbols.

That is a separate step in the process. You would need to traverse the
syntax tree, and let the resolver resolve every symbol encountered in
expressions or function call statements. (or just the symbol names 
you are interested in).


The resolver is implemented in pasresolver.pp and pasresolveeval.pas
(but I think you'll only need the former)

You can attach any amount of data to an element of the AST. 
For instance this could be the number of times the element is accessed.


Separate from the resolver, there is also the pasuseanalyser, 
which analyses if elements are used.


I don't think it keeps a count, though.

Michael.
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Michael Van Canneyt]

On Sun, 13 Oct 2019, Ryan Joseph wrote:





On Oct 13, 2019, at 12:30 PM, Michael Van Canneyt  
wrote:

Ahah...

That needs to be tested then. This seems to be a bug. Can you please create
a bug with a compilable example ?


- Please test the operator because I don’t think the parser understands it.


OK, that's strange, because I can see the code for handling operators, and
operators are definitely parsed, the RTL/FCL are riddled with operators...

Then this needs to be tested and possibly fixed too. Please report this also as 
a bug with a testcase, so I don't forget.

I'll try to fix them ASAP.


I’m out of time today but I’m make some examples later. Where do you want me to post 
them? Sorry I don’t get "sed s/bug/bugreport/“.


Please post them in the bugtracker, one issue per problem.



heres’ the list:

1) allow omission of extension for $include macro
2) record class operators
3) record sections in records nested in routines


so I expect 3 issues :-) I don't know if you can assign them to someone as
reporter, but if you can you can assign them to me (Michael Van Canneyt)

As for "sed":

sed s/bug/bugreport/ : sed is the  Stream EDitor command-line tool. 
the expression s/bug/bugreport/ substitutes the first occurrence of 'bug' with 'bugreport'


I wrote 'bug' when I meant 'bugreport'

Michael.___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

[fpc-pascal] fcl-passrc method/function invocations

[Ryan Joseph]

One of my tasks for the language server is determining “references” to a 
symbol, which means for functions I need to know all the times they were called.

Given the syntax tree the parser creates how do I know when a function was 
called? I see there is a TPasImplSimple that seems related but I’m not sure 
exactly. It’s probably possible that it’s not always possible to know because 
there are unresolved types so: a := clss.DoThis; maybe be a function call or 
accessing a proeprty/member variable.

Regards,
Ryan Joseph

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Ryan Joseph]

> On Oct 13, 2019, at 12:30 PM, Michael Van Canneyt  
> wrote:
> 
> Ahah...
> 
> That needs to be tested then. This seems to be a bug. Can you please create
> a bug with a compilable example ?
> 
>> - Please test the operator because I don’t think the parser understands it.
> 
> OK, that's strange, because I can see the code for handling operators, and
> operators are definitely parsed, the RTL/FCL are riddled with operators...
> 
> Then this needs to be tested and possibly fixed too. Please report this also 
> as a bug with a testcase, so I don't forget.
> 
> I'll try to fix them ASAP.

I’m out of time today but I’m make some examples later. Where do you want me to 
post them? Sorry I don’t get "sed s/bug/bugreport/“.

heres’ the list:

1) allow omission of extension for $include macro
2) record class operators
3) record sections in records nested in routines

Regards,
Ryan Joseph

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] *etFTime -> File*etDate

[Christo Crause]

On Sun, Oct 13, 2019 at 8:03 PM Ched <
charles.edouard.des.vastes.vig...@gmail.com> wrote:

> Hello,
>
> In https://www.freepascal.org/docs-html/rtl/sysutils/filenameroutines.html
> ,
>
> FileSetDate <
> https://www.freepascal.org/docs-html/rtl/sysutils/filesetdate.html>Get
> file dates  should be
> corrected to _S_et .
>
I don't see any mix-up of Get and Set on either the FileSetDate or
FileGetDate pages at your link above.


> Now, my real problem is that the following code is compiled when SYS is
> not defined, and isn't when it
> is, and I really don't know why.
>
> PROGRAM QQ;
> { $DEFINE SYS}
> USES
> {$IFDEF SYS}
>SYSUTILS;
> {$ELSE}
>DOS;
> {$ENDIF}
> VAR
> FO: FILE OF DOUBLE;
> L: LONGINT;
> BEGIN
> ASSIGN(FO, 'blabla.bin');
> RESET(FO);
> {$IFDEF SYS}
>L:=FILEGETDATE(FO);   { Got File, expected LongInt }
> {$ELSE}
>GETFTIME(FO, L);
> {$ENDIF}
> CLOSE(FO);
> END.
>

The file variable FO in your code should be declared as type THandle (which
is an alias for LongInt) when you are using the SysUtils file handling
routines.  Take a look at the example at the bottom of FileCreate (
https://www.freepascal.org/docs-html/rtl/sysutils/filecreate.html) to see
how to work with these routines.


> Well, it appears that I prbably haven't fully understand the dos->sysutils
> conversion.
>

You are mixing classic Pascal style file handling (Assign, Reset, Close)
which isn't (AFAIK) Dos style, with an alternative file handling style
defined in SysUtils.

Cheers, Ched'
>
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

[fpc-pascal] *etFTime -> File*etDate

[Ched]

Hello,

In https://www.freepascal.org/docs-html/rtl/sysutils/filenameroutines.html ,

FileSetDate Get file dates  should be 
corrected to _S_et .



Now, my real problem is that the following code is compiled when SYS is not defined, and isn't when it 
is, and I really don't know why.


PROGRAM QQ;
   { $DEFINE SYS}
USES
   {$IFDEF SYS}
  SYSUTILS;
   {$ELSE}
  DOS;
   {$ENDIF}
VAR
   FO: FILE OF DOUBLE;
   L: LONGINT;
BEGIN
   ASSIGN(FO, 'blabla.bin');
   RESET(FO);
   {$IFDEF SYS}
  L:=FILEGETDATE(FO);   { Got File, expected LongInt }
   {$ELSE}
  GETFTIME(FO, L);
   {$ENDIF}
   CLOSE(FO);
END.

Well, it appears that I prbably haven't fully understand the dos->sysutils 
conversion.

Cheers, Ched'
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Michael Van Canneyt]

On Sun, 13 Oct 2019, Michael Van Canneyt wrote:




- This is a new version from 3 days ago.
- The record sections failed because they are inside a function. If I pull 
the record out of the function they work.


Ahah...

That needs to be tested then. This seems to be a bug. Can you please create
a bug with a compilable example ?


sed s/bug/bugreport/

Michael.
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Michael Van Canneyt]

On Sun, 13 Oct 2019, Ryan Joseph wrote:


To be clear:

here I meant that 'currently that will definitely not be done in fcl-passrc.'



This is a problem then because I wanted to make a language server for FPC
but if the parser doesn’t understand accepted FPC syntax the whole thing
falls apart.  Can you make an FPC complient mode or something then?  IMO
if the parser included with the compiler doesn’t understand the same
syntax as the compiler then we’re in trouble.


It should understand the same syntax, 100%. 
If it does not, that's definitely a bug.


The missing extension you can easily fix by explicitly adding it.

But of course I will add it to fcl-passrc, I simply was not aware of the
.inc. The documentation also must be adapted for this.


Here’s basically what I’m doing to parse. Nothing special and the engine is 
just a template that does just the minimum (like the examples in the package).

module := ParseSource(engine, ’bugs.pas', 'darwin', 'x86_64');


At first sight, you need to do at least

module := ParseSource(engine, ’-Mdelphi bugs.pas', 'darwin', 'x86_64');

Because for the language constructs you are using you need mode delphi.
(unless you have the necessary $mode and $modeswitch statements in code)

The parser by default does not enable mode delphi or objfpc for that matter, 
so you need to specify that on the 'command-line'.



- This is a new version from 3 days ago.
- The record sections failed because they are inside a function. If I pull the 
record out of the function they work.


Ahah...

That needs to be tested then. This seems to be a bug. Can you please create
a bug with a compilable example ?


- Please test the operator because I don’t think the parser understands it.


OK, that's strange, because I can see the code for handling operators, and
operators are definitely parsed, the RTL/FCL are riddled with operators...

Then this needs to be tested and possibly fixed too. 
Please report this also as a bug with a testcase, so I don't forget.


I'll try to fix them ASAP.

Michael.___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Sven Barth via fpc-pascal]

Ryan Joseph  schrieb am So., 13. Okt. 2019, 16:22:

>
>
> > On Oct 13, 2019, at 5:58 AM, Sven Barth via fpc-pascal <
> fpc-pascal@lists.freepascal.org> wrote:
> >
> >> Delphi does not allow it:
> >>
> >> [dcc32 Error] Project1.dpr(18): E1019 For loop control variable must be
> simple local variable
> >>
> >> I don't think this should be allowed, either.
> >
> > Same.
>
> Why not?
>
> I just had this problem on 9/26, search for “for-in loop cast”. What if I
> have a list of TObjects I want to iterate? I know TMyClass is safe to use
> but the compiler complains so I override it with a typecast. If you take
> that away I’ll have to do tons of casting outside of the loop.
>
> var
>   arr: specialize TFPGObjectList;
>   obj: TMyClass;
> begin
>   arr := specialize TFPGObjectList.Create;
>   arr.Add(TObject.Create);
>   // Incompatible types: got "TObject" expected "TMyClass"
>   for obj in arr do
> begin
> end;
>

Then specialize the list with the correct type.

This issue *will* be fixed and is not up to discussion.

Regards,
Sven

>
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Ryan Joseph]

> On Oct 13, 2019, at 5:58 AM, Sven Barth via fpc-pascal 
>  wrote:
> 
>> Delphi does not allow it:
>> 
>> [dcc32 Error] Project1.dpr(18): E1019 For loop control variable must be 
>> simple local variable
>> 
>> I don't think this should be allowed, either.
> 
> Same.

Why not?

I just had this problem on 9/26, search for “for-in loop cast”. What if I have 
a list of TObjects I want to iterate? I know TMyClass is safe to use but the 
compiler complains so I override it with a typecast. If you take that away I’ll 
have to do tons of casting outside of the loop.  

var
  arr: specialize TFPGObjectList;
  obj: TMyClass;
begin
  arr := specialize TFPGObjectList.Create;
  arr.Add(TObject.Create);
  // Incompatible types: got "TObject" expected "TMyClass"
  for obj in arr do
begin
end;


Regards,
Ryan Joseph

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Ryan Joseph]

> On Oct 13, 2019, at 6:18 AM, Michael Van Canneyt  
> wrote:
> 
>>> Well spotted. I didn't notice that the extension was missing.
>>> 
>>> That will definitely not be done in fcl-passrc.
> 
> To be clear:
> 
> here I meant that 'currently that will definitely not be done in fcl-passrc.'


This is a problem then because I wanted to make a language server for FPC but 
if the parser doesn’t understand accepted FPC syntax the whole thing falls 
apart. Can you make an FPC complient mode or something then? IMO if the parser 
included with the compiler doesn’t understand the same syntax as the compiler 
then we’re in trouble.




Here’s basically what I’m doing to parse. Nothing special and the engine is 
just a template that does just the minimum (like the examples in the package).

module := ParseSource(engine, ’bugs.pas', 'darwin', 'x86_64'); 

- This is a new version from 3 days ago.
- The record sections failed because they are inside a function. If I pull the 
record out of the function they work.
- Please test the operator because I don’t think the parser understands it.

{$mode objfpc}
{$modeswitch advancedrecords}

program bugs;

type
  TMyRecordA = record
class operator = (constref a, b: TMyRecordA): boolean;
  end;

class operator TMyRecordA.= (constref a, b: TMyRecordA): boolean;
begin
  result := (@a = @b);
end;

procedure DoThis;
  type
TMyRecordB = record
  private
x, y, z: integer; 
end;
  begin
  end;

begin
end.

Regards,
Ryan Joseph

___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Michael Van Canneyt]

On Sun, 13 Oct 2019, Sven Barth via fpc-pascal wrote:

Could the missing ".inc" be the problem? I have not checked, but it 
could

be that FPC always adds ".inc" if no extension is present.


Well spotted. I didn't notice that the extension was missing.

That will definitely not be done in fcl-passrc.


To be clear:

here I meant that 'currently that will definitely not be done in fcl-passrc.'

I was not aware FPC does this either. It's not documented, that's for 
sure:


https://www.freepascal.org/docs-html/current/prog/progsu40.html

Delphi also does not look for .inc files, I checked. It only adds 
extension

.pas

So, conclusion: FPC is way too lenient. ;-)


This is how FPC looks for an include file:

=== code begin ===

   { try to find the file }
   found:=findincludefile(path,name,foundfile);
   if (not found) and (ExtractFileExt(name)='') then
    begin
  { try default extensions .inc , .pp and .pas }
  if (not found) then
found:=findincludefile(path,ChangeFileExt(name,'.inc'),foundfile);
  if (not found) then
found:=findincludefile(path,ChangeFileExt(name,sourceext),foundfile);
  if (not found) then
found:=findincludefile(path,ChangeFileExt(name,pasext),foundfile);


Thanks, I will adapt the mechanism in pas2js.

Michael.___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Sven Barth via fpc-pascal]

Am 13.10.2019 um 11:26 schrieb Michael Van Canneyt:



On Sun, 13 Oct 2019, Sven Barth via fpc-pascal wrote:

Just type casting because the array is an array of pointers. I get 
these

errors otherwise "Incompatible types: got "Pointer"
expected “TEntity"”. I could use a proper type in a generic array 
but I

don’t always do that.

I didn't know you could do this in a for in loop. FPC eats this ?



It currently does, but it might as well be a bug in FPC. I'll have to 
cross

check with Delphi.


Delphi does not allow it:

[dcc32 Error] Project1.dpr(18): E1019 For loop control variable must 
be simple local variable


I don't think this should be allowed, either.


Same.





Not yet.

I have no idea how you call the parser. Include files most
definitely work: the documentation generator uses fcl-passrc, and the
RTL/FCL is full of include files.

Probably your invocation of the parser is simply wrong or missing some
arguments.



Could the missing ".inc" be the problem? I have not checked, but it 
could

be that FPC always adds ".inc" if no extension is present.


Well spotted. I didn't notice that the extension was missing.

That will definitely not be done in fcl-passrc.

I was not aware FPC does this either. It's not documented, that's for 
sure:


https://www.freepascal.org/docs-html/current/prog/progsu40.html

Delphi also does not look for .inc files, I checked. It only adds 
extension

.pas

So, conclusion: FPC is way too lenient. ;-)


This is how FPC looks for an include file:

=== code begin ===

   { try to find the file }
   found:=findincludefile(path,name,foundfile);
   if (not found) and (ExtractFileExt(name)='') then
    begin
  { try default extensions .inc , .pp and .pas }
  if (not found) then
found:=findincludefile(path,ChangeFileExt(name,'.inc'),foundfile);
  if (not found) then
found:=findincludefile(path,ChangeFileExt(name,sourceext),foundfile);
  if (not found) then
found:=findincludefile(path,ChangeFileExt(name,pasext),foundfile);
    end;

=== code end ===

Regards,
Sven
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Michael Van Canneyt]

On Sun, 13 Oct 2019, Sven Barth via fpc-pascal wrote:


Just type casting because the array is an array of pointers. I get these

errors otherwise "Incompatible types: got "Pointer"

expected “TEntity"”. I could use a proper type in a generic array but I

don’t always do that.

I didn't know you could do this in a for in loop. FPC eats this ?



It currently does, but it might as well be a bug in FPC. I'll have to cross
check with Delphi.


Delphi does not allow it:

[dcc32 Error] Project1.dpr(18): E1019 For loop control variable must be simple 
local variable

I don't think this should be allowed, either.



Not yet.

I have no idea how you call the parser. Include files most
definitely work: the documentation generator uses fcl-passrc, and the
RTL/FCL is full of include files.

Probably your invocation of the parser is simply wrong or missing some
arguments.



Could the missing ".inc" be the problem? I have not checked, but it could
be that FPC always adds ".inc" if no extension is present.


Well spotted. I didn't notice that the extension was missing.

That will definitely not be done in fcl-passrc.

I was not aware FPC does this either. It's not documented, that's for sure:

https://www.freepascal.org/docs-html/current/prog/progsu40.html

Delphi also does not look for .inc files, I checked. It only adds extension
.pas

So, conclusion: FPC is way too lenient. ;-)

Michael.___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Sven Barth via fpc-pascal]

Michael Van Canneyt  schrieb am So., 13. Okt. 2019,
08:20:

> > 2)  For..in loops
> >
> > EParserError: Expected := or in at token "(" in file
> >
>  
> /Users/ryanjoseph/Developer/Projects/FPC/NewEngine/Sources/Examples/EmptyWindow.pas
> at line 138 column
> > 14
> >
> >
> >   For in loops should be supported, but I've never seen this before:
> >
> > for pointer(entity) in entities do
> >
> >
> >   What is for pointer(entity) in entities  supposed to do ?
> >
> >   It can be that this syntax is not supported (no surprise, since I
> don't have
> >   a clue what this is supposed to do).
> >
> >
> > Just type casting because the array is an array of pointers. I get these
> errors otherwise "Incompatible types: got "Pointer"
> > expected “TEntity"”. I could use a proper type in a generic array but I
> don’t always do that.
>
> I didn't know you could do this in a for in loop. FPC eats this ?
>

It currently does, but it might as well be a bug in FPC. I'll have to cross
check with Delphi.


> >
> >  begin
> >entity.Update;
> >entity.Draw(renderer);
> >renderer.PushBox(entity.GetHitBox, TRGBA.RedColor);
> >  end;
> >
> > 3) {$i settings} will not find the file “settings.inc”. This
> is valid in FPC but the parser seems to
> > have other rules.
> >
> >
> >   They should be the same.
> >
> >   As said, pas2js uses fcl-passrc, and pas2js handles inifiles just
> as FPC
> >   does.
> >
> >
> > Another bug then. Should I make a bug report for these?
>
> Not yet.
>
> I have no idea how you call the parser. Include files most
> definitely work: the documentation generator uses fcl-passrc, and the
> RTL/FCL is full of include files.
>
> Probably your invocation of the parser is simply wrong or missing some
> arguments.
>

Could the missing ".inc" be the problem? I have not checked, but it could
be that FPC always adds ".inc" if no extension is present.

Regards,
Sven
___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal

Re: [fpc-pascal] fcl-passrc errors

[Michael Van Canneyt]

On Sat, 12 Oct 2019, Ryan Joseph wrote:




  On Oct 12, 2019, at 6:43 PM, Michael Van Canneyt  
wrote:

1) class operators for records

EParserError: Expected "procedure" at token "operator" in file
/Users/ryanjoseph/Developer/Projects/FPC/GLCanvas/GLCanvas.pas at 
line 115 column 7

class operator TVertex3.= (constref a, b: TVertex3): boolean;
begin
result := (@a = @b);
end;


  This can be.


It’s a bug then? I found another advanced record bug below.


It's a little early to conclude this. The code supports class operators.
But see below.



2)  For..in loops

EParserError: Expected := or in at token "(" in file

/Users/ryanjoseph/Developer/Projects/FPC/NewEngine/Sources/Examples/EmptyWindow.pas
 at line 138 column
14


  For in loops should be supported, but I've never seen this before:

for pointer(entity) in entities do


  What is for pointer(entity) in entities  supposed to do ?

  It can be that this syntax is not supported (no surprise, since I don't 
have
  a clue what this is supposed to do).


Just type casting because the array is an array of pointers. I get these errors otherwise 
"Incompatible types: got "Pointer"
expected “TEntity"”. I could use a proper type in a generic array but I don’t 
always do that.


I didn't know you could do this in a for in loop. FPC eats this ?



 begin
   entity.Update;
   entity.Draw(renderer);
   renderer.PushBox(entity.GetHitBox, TRGBA.RedColor);
 end;

3) {$i settings} will not find the file “settings.inc”. This is 
valid in FPC but the parser seems to
have other rules.


  They should be the same.

  As said, pas2js uses fcl-passrc, and pas2js handles inifiles just as FPC
  does.


Another bug then. Should I make a bug report for these?


Not yet.

I have no idea how you call the parser. Include files most
definitely work: the documentation generator uses fcl-passrc, and the
RTL/FCL is full of include files.

Probably your invocation of the parser is simply wrong or missing some
arguments.



Here’s another one I found. No section headers in records?

Expected "," or ":" at token "Identifier IDSize" in file
/Users/ryanjoseph/Developer/Projects/FPC/NewEngine/Sources/Base/UImage.pas at 
line 94 column 4


Again, that works. These constructs can be found in the RTL/FCL and the
documentation generator parses that (and so does pas2js).

Disregarding the typecast in the for..in, concluding that there are bugs is 
very premature.
All constructs you mention are supported.

So the question is why you are getting errors for constructs that are
supported ?

Did you specify the advanced record modeswitch in the sources ? 
Do you specify delphi mode when calling the parser ?


But the parser must be invoked correctly. If you don't invoke it correctly, then
of course you can expect it to report errors. If you use the default 
'ParseSource'
function, that definitely does not cover all possible cases as handled by FPC. 
It will not observe whatever you have in .fpc.cfg or /etc/fpc.cfg etc.


Also, are you using trunk or 3.0.4 ? There have been a massive amount of
updates to fcl-passrc.

Michael.___
fpc-pascal maillist  -  fpc-pascal@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal