sysinstall bootstrapping issues [Was: -CURRENT b0rked?]

2001-05-14 Thread Maxim Sobolev 

On Sun, 13 May 2001 17:13:01 +0200 (SAT), John Hay wrote:

It seems that sysinstall(8) was not fully integrated into
buildworld - it depends on content of /usr/share/syscons/keymaps,
while it shouldn't.

I've just committed a patch that should fix this problem.
  
  You should look a little earlier in the logs to where the damage was really
  done:
  
  rm -f keymap.tmp
  for map in be.iso br275.iso danish.iso finnish.iso fr.iso  german.iso hr.iso hu.
  iso2.101keys it.iso icelandic.iso jp.106  norwegian.iso pl_PL.ISO_8859-2 pt.iso 
  ru.koi8-r si.iso  spanish.iso swedish.iso swissfrench.iso swissgerman.iso ua.koi
  8-u  ua.koi8-u.shift.alt uk.iso us.dvorak us.iso us.pc-ctrl us.unix ; do  env KE
  YMAP_PATH=/usr/src/usr.sbin/sysinstall/../../share/syscons/keymaps  kbdcontrol -
  L $map |  sed -e '/^static accentmap_t/,$d'  keymap.tmp ;  done
  Segmentation fault - core dumped
  ...
  
  It looks like kbdcontrol is not very happy.
 
 Ok, here is a patch that fix the problem for me. The problem is that
 a second call to mkfullname() will reuse the memory at the pointer that
 it returns, so you have to preserve it before then.

OOPS, sorry. I've overlooked it. Should be fixed now. Interesting
that on my system it worked like a charm.

4.3 upgrade path is likely to be still broken , because kbdcontrol(8)
in 4-STABLE doesn't honour KEYMAP_PATH environment variable.
Perhaps kbdcontrol should be added into bootstrap tools to fully fix
the problem.

-Maxim

-Maxim

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message

Re: [sysinstall bootstrapping issues [Was: -CURRENT b0rked?]]

2001-05-14 Thread John Hay 

   
   It looks like kbdcontrol is not very happy.
  
  Ok, here is a patch that fix the problem for me. The problem is that
  a second call to mkfullname() will reuse the memory at the pointer that
  it returns, so you have to preserve it before then.
 
 OOPS, sorry. I've overlooked it. Should be fixed now. Interesting
 that on my system it worked like a charm.

Do you set malloc options with /etc/malloc.conf maybe? The J option
will cause this and it is on by default in -current. You didn't switch
it off maybe?

 4.3 upgrade path is likely to be still broken , because kbdcontrol(8)
 in 4-STABLE doesn't honour KEYMAP_PATH environment variable.
 Perhaps kbdcontrol should be added into bootstrap tools to fully fix
 the problem.

Won't it be good enough to merge KEYMAP_PATH to stable? Or do we need
to be able to upgrade to -current from any 4.x?

John
-- 
John Hay -- [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message