Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On Sat, May 10, 2014 at 20:06:58 -0600, Warner Losh wrote:
On May 10, 2014, at 8:06 PM, Warner Losh i...@bsdimp.com wrote:
On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
Warner,
It looks like your change broke the FreeBSD-HEAD-modules
build.
This build does the following:
export JFLAG=-j4
export MAKESYSPATH=${WORKSPACE}/mk”
Shouldn’t this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be …/share/mk
or $TOP/share/mk when building outside of make world-like environments now.
Warner
cd ${WORKSPACE}/sys/modules
echo === make cleandir ===
make cleandir
echo === make depend ===
make ${JFLAG} depend
echo === make all ===
make ${JFLAG} all
Just confirmed that it works with a proper MAKESYSPATH…
Warner
This job checks out svn://svn.freebsd.org/base/head/sys to
${WORKSPACE}/sys and svn://svn.freebsd.org/base/head/share/mk to
${WORKSPACE}/mk , then sets MAKESYSPATH=${WORKSPACE}/mk since I was
trying not to check out the whole src tree.
Just be curious, why in line 24 of sys/conf/kern.opts.mk , we do:
.include ../../share/mk/bsd.mkopt.mk
but not:
.include bsd.mkopt.mk
like other .mk files under sys/conf ?
I tried to switch to this and it seems work, but I am not sure if this
is your original intention. I'll change the modules building job to
checkout the whole src tree if this is not an accepted solution.
Thanks,
Li-Wen
--
Li-Wen Hsu lw...@freebsd.org
http://lwhsu.org
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
Hi,
No, that's not the problem, because we specifically check out
/usr/share/mk into $WORKSPACE/mk before running the build.
The problem is due to this commit:
http://svnweb.freebsd.org/base/head/sys/conf/kern.mk?r1=265832r2=265841
You didn't completely remove MK_FORMAT_EXTENSIONS from this file,
so we are now getting this error message:
make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.mk
line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no)
--
Craig
On Sat, May 10, 2014 at 7:06 PM, Warner Losh i...@bsdimp.com wrote:
On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
Warner,
It looks like your change broke the FreeBSD-HEAD-modules
build.
This build does the following:
export JFLAG=-j4
export MAKESYSPATH=${WORKSPACE}/mk
Shouldn't this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be .../share/mk
or $TOP/share/mk when building outside of make world-like environments now.
Warner
cd ${WORKSPACE}/sys/modules
echo === make cleandir ===
make cleandir
echo === make depend ===
make ${JFLAG} depend
echo === make all ===
make ${JFLAG} all
Can you look into this?
Thanks.
--
Craig
On Fri, May 9, 2014 at 3:39 PM, jenkins-ad...@freebsd.org wrote:
See
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes
Changes:
[imp] Introduce kern.opts.mk to hold all the options for kernel module
builds. Include this in the right places. Make src.opts.mk optional so
that modules can be built outside of the tree in the ports system.
PR: 189520
--
Started by upstream project FreeBSD_HEAD build number 636
originally caused by:
Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision
'2014-05-09T22:39:09.739 +'
U conf/kmod.mk
AUconf/kern.opts.mk
U conf/kern.pre.mk
At revision 265785
Updating svn://svn.freebsd.org/base/head/share/mk at revision
'2014-05-09T22:39:09.739 +'
U src.opts.mk
At revision 265785
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
+ export JFLAG=-j4
+ export
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]:
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1
Stop.
make: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On May 11, 2014, at 1:43 PM, Craig Rodrigues rodr...@freebsd.org wrote:
Hi,
No, that's not the problem, because we specifically check out
/usr/share/mk into $WORKSPACE/mk before running the build.
The problem is due to this commit:
http://svnweb.freebsd.org/base/head/sys/conf/kern.mk?r1=265832r2=265841
You didn't completely remove MK_FORMAT_EXTENSIONS from this file,
I never tried.
so we are now getting this error message:
make[1]:
/builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk
line 24: Could not find ../../share/mk/bsd.mkopt.mk
We assume a certain tree layout, which your script violates, so we can’t
include this file. We simply don’t support building the kernel with such
arbitrary system layouts.
We have to include it this way, rather than other ways, because when you are
building out of tree you don’t pass in the root.
I don’t think this is a valid test of the build system. You are building with
weird tree layouts. Please build with standard layouts.
make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.mk
line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == no”)
Since we can’t include the file, anything downstream from that is just noise
and needs to be ignored.
Warner
--
Craig
On Sat, May 10, 2014 at 7:06 PM, Warner Losh i...@bsdimp.com wrote:
On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
Warner,
It looks like your change broke the FreeBSD-HEAD-modules
build.
This build does the following:
export JFLAG=-j4
export MAKESYSPATH=${WORKSPACE}/mk
Shouldn't this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be
.../share/mk or $TOP/share/mk when building outside of make world-like
environments now.
Warner
cd ${WORKSPACE}/sys/modules
echo === make cleandir ===
make cleandir
echo === make depend ===
make ${JFLAG} depend
echo === make all ===
make ${JFLAG} all
Can you look into this?
Thanks.
--
Craig
On Fri, May 9, 2014 at 3:39 PM, jenkins-ad...@freebsd.org wrote:
See
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes
Changes:
[imp] Introduce kern.opts.mk to hold all the options for kernel module
builds. Include this in the right places. Make src.opts.mk optional so
that modules can be built outside of the tree in the ports system.
PR: 189520
--
Started by upstream project FreeBSD_HEAD build number 636
originally caused by:
Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision
'2014-05-09T22:39:09.739 +'
U conf/kmod.mk
AUconf/kern.opts.mk
U conf/kern.pre.mk
At revision 265785
Updating svn://svn.freebsd.org/base/head/share/mk at revision
'2014-05-09T22:39:09.739 +'
U src.opts.mk
At revision 265785
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
+ export JFLAG=-j4
+ export
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]:
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1
Stop.
make: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
signature.asc
Description: Message signed with OpenPGP using GPGMail
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On Sun, May 11, 2014 at 3:25 PM, Warner Losh i...@bsdimp.com wrote: On May 11, 2014, at 1:43 PM, Craig Rodrigues rodr...@freebsd.org wrote: make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk line 24: Could not find ../../share/mk/bsd.mkopt.mk Instead of explicitly specifying the path to ../../share/mk, should some additional logic be added to respect MAKESYSPATH? Some people building products do build the kernel and modules out of the FreeBSD source tree, and put their mk files in a directory which is not src/share/mk. -- Craig ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On May 11, 2014, at 5:00 PM, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, May 11, 2014 at 3:25 PM, Warner Losh i...@bsdimp.com wrote: On May 11, 2014, at 1:43 PM, Craig Rodrigues rodr...@freebsd.org wrote: make[1]: /builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk line 24: Could not find ../../share/mk/bsd.mkopt.mk Instead of explicitly specifying the path to ../../share/mk, should some additional logic be added to respect MAKESYSPATH? The only logic that can work is to test MAKESYSPATH and respect it if it is defined, and use the relative path if not (since we don’t require MAKESYSPATH to be defined to do a out-of-tree module build, and could be built on a system that isn’t running the latest current). Some people building products do build the kernel and modules out of the FreeBSD source tree, and put their mk files in a directory which is not src/share/mk. That’s not really a supported configuration. Using JIRA to force it is rather an annoying use of JIRA since it makes making JIRA happy hard to test and outside the normal work flow. This will cause pain in the future, and I also object to my changes being characterized as “wrong” when such a non-standard setup has never been explicitly supported, required or part of anybody’s normal workflow. Grump. I’ve prepared a compromise commit, but I’m not happy about it, and think it is a horribly ugly kludge. But I can think of no other ways to keep both use cases working. Warner signature.asc Description: Message signed with OpenPGP using GPGMail
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On Sun, May 11, 2014 at 4:22 PM, Warner Losh i...@bsdimp.com wrote: The only logic that can work is to test MAKESYSPATH and respect it if it is defined, and use the relative path if not (since we don't require MAKESYSPATH to be defined to do a out-of-tree module build, and could be built on a system that isn't running the latest current). That is a legitimate patch. I've seen people make similar changes to the kernel makefiles an mk rules, specifically folks who import FreeBSD kernel source into their tree, but have the mk rules in a non-standard place. Thanks for applying this change. Using JIRA to force it is rather an annoying use of JIRA since it makes making JIRA happy hard to test and outside the normal work flow. Please use the correct terminology to avoid confusion. Jenkins is not the same as JIRA. -- Craig ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On May 11, 2014, at 7:50 PM, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, May 11, 2014 at 4:22 PM, Warner Losh i...@bsdimp.com wrote: The only logic that can work is to test MAKESYSPATH and respect it if it is defined, and use the relative path if not (since we don't require MAKESYSPATH to be defined to do a out-of-tree module build, and could be built on a system that isn't running the latest current). That is a legitimate patch. I've seen people make similar changes to the kernel makefiles an mk rules, specifically folks who import FreeBSD kernel source into their tree, but have the mk rules in a non-standard place. Thanks for applying this change. Sure. Still not sure what I think about it, but it does work and I have bigger fish to fry... Using JIRA to force it is rather an annoying use of JIRA since it makes making JIRA happy hard to test and outside the normal work flow. Please use the correct terminology to avoid confusion. Jenkins is not the same as JIRA. Yes. Others have corrected me as well. Sorry for the confusion… Warner signature.asc Description: Message signed with OpenPGP using GPGMail
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
Warner,
It looks like your change broke the FreeBSD-HEAD-modules
build.
This build does the following:
export JFLAG=-j4
export MAKESYSPATH=${WORKSPACE}/mk
cd ${WORKSPACE}/sys/modules
echo === make cleandir ===
make cleandir
echo === make depend ===
make ${JFLAG} depend
echo === make all ===
make ${JFLAG} all
Can you look into this?
Thanks.
--
Craig
On Fri, May 9, 2014 at 3:39 PM, jenkins-ad...@freebsd.org wrote:
See https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes
Changes:
[imp] Introduce kern.opts.mk to hold all the options for kernel module
builds. Include this in the right places. Make src.opts.mk optional so
that modules can be built outside of the tree in the ports system.
PR: 189520
--
Started by upstream project FreeBSD_HEAD build number 636
originally caused by:
Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision
'2014-05-09T22:39:09.739 +'
U conf/kmod.mk
AUconf/kern.opts.mk
U conf/kern.pre.mk
At revision 265785
Updating svn://svn.freebsd.org/base/head/share/mk at revision
'2014-05-09T22:39:09.739 +'
U src.opts.mk
At revision 265785
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
+ export JFLAG=-j4
+ export
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]:
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1
Stop.
make: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
Warner,
It looks like your change broke the FreeBSD-HEAD-modules
build.
This build does the following:
export JFLAG=-j4
export MAKESYSPATH=${WORKSPACE}/mk”
Shouldn’t this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be …/share/mk or
$TOP/share/mk when building outside of make world-like environments now.
Warner
cd ${WORKSPACE}/sys/modules
echo === make cleandir ===
make cleandir
echo === make depend ===
make ${JFLAG} depend
echo === make all ===
make ${JFLAG} all
Can you look into this?
Thanks.
--
Craig
On Fri, May 9, 2014 at 3:39 PM, jenkins-ad...@freebsd.org wrote:
See
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes
Changes:
[imp] Introduce kern.opts.mk to hold all the options for kernel module
builds. Include this in the right places. Make src.opts.mk optional so
that modules can be built outside of the tree in the ports system.
PR: 189520
--
Started by upstream project FreeBSD_HEAD build number 636
originally caused by:
Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision
'2014-05-09T22:39:09.739 +'
U conf/kmod.mk
AUconf/kern.opts.mk
U conf/kern.pre.mk
At revision 265785
Updating svn://svn.freebsd.org/base/head/share/mk at revision
'2014-05-09T22:39:09.739 +'
U src.opts.mk
At revision 265785
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
+ export JFLAG=-j4
+ export
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]:
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1
Stop.
make: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
signature.asc
Description: Message signed with OpenPGP using GPGMail
Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386
On May 10, 2014, at 8:06 PM, Warner Losh i...@bsdimp.com wrote:
On May 10, 2014, at 6:27 PM, Craig Rodrigues rodr...@freebsd.org wrote:
Warner,
It looks like your change broke the FreeBSD-HEAD-modules
build.
This build does the following:
export JFLAG=-j4
export MAKESYSPATH=${WORKSPACE}/mk”
Shouldn’t this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be …/share/mk
or $TOP/share/mk when building outside of make world-like environments now.
Warner
cd ${WORKSPACE}/sys/modules
echo === make cleandir ===
make cleandir
echo === make depend ===
make ${JFLAG} depend
echo === make all ===
make ${JFLAG} all
Just confirmed that it works with a proper MAKESYSPATH…
Warner
Can you look into this?
Thanks.
--
Craig
On Fri, May 9, 2014 at 3:39 PM, jenkins-ad...@freebsd.org wrote:
See
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes
Changes:
[imp] Introduce kern.opts.mk to hold all the options for kernel module
builds. Include this in the right places. Make src.opts.mk optional so
that modules can be built outside of the tree in the ports system.
PR: 189520
--
Started by upstream project FreeBSD_HEAD build number 636
originally caused by:
Started by an SCM change
Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/
Updating svn://svn.freebsd.org/base/head/sys at revision
'2014-05-09T22:39:09.739 +'
U conf/kmod.mk
AUconf/kern.opts.mk
U conf/kern.pre.mk
At revision 265785
Updating svn://svn.freebsd.org/base/head/share/mk at revision
'2014-05-09T22:39:09.739 +'
U src.opts.mk
At revision 265785
[FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
+ export JFLAG=-j4
+ export
MAKESYSPATH=https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk
+ cd
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
+ echo '=== make cleandir ==='
=== make cleandir ===
+ make cleandir
=== aac (cleandir)
make[1]:
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk;
line 24: Could not find ../../share/mk/bsd.mkopt.mk
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac
*** Error code 1
Stop.
make: stopped in
https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules
Build step 'Execute shell' marked build as failure
signature.asc
Description: Message signed with OpenPGP using GPGMail
