Re: Fix sysinstall problem

2001-09-24 Thread Marcel Moolenaar

On Mon, Sep 24, 2001 at 04:53:16PM +0900, Takahashi Yoshihiro wrote:
 
 It uses the boot programs in /boot. So, even if we change boot0 and/or
 mbr, the new sysinstall includes old one. And, it breaks cross
 building, too.
 
 I have made the patch to fix this problem. It adds a new target boot
 into Makefile.inc1. Because, the boot programs must be made after
 cross-tools target and before par-depend target.

I'm not sure this is the right way to do it. Aren't we already building
sys/boot as part of buildworld?

-- 
 Marcel Moolenaar USPA: A-39004  [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Fix sysinstall problem

2001-09-24 Thread John Baldwin


On 24-Sep-01 Marcel Moolenaar wrote:
 On Mon, Sep 24, 2001 at 04:53:16PM +0900, Takahashi Yoshihiro wrote:
 
 It uses the boot programs in /boot. So, even if we change boot0 and/or
 mbr, the new sysinstall includes old one. And, it breaks cross
 building, too.
 
 I have made the patch to fix this problem. It adds a new target boot
 into Makefile.inc1. Because, the boot programs must be made after
 cross-tools target and before par-depend target.
 
 I'm not sure this is the right way to do it. Aren't we already building
 sys/boot as part of buildworld?

Yes, it possibly should grab them from /usr/obj somewhere.

-- 

John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
Power Users Use the Power to Serve!  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Fix sysinstall problem

2001-09-24 Thread Takahashi Yoshihiro

In article [EMAIL PROTECTED]
Marcel Moolenaar [EMAIL PROTECTED] writes:

 On Mon, Sep 24, 2001 at 04:53:16PM +0900, Takahashi Yoshihiro wrote:
  
  It uses the boot programs in /boot. So, even if we change boot0 and/or
  mbr, the new sysinstall includes old one. And, it breaks cross
  building, too.
  
  I have made the patch to fix this problem. It adds a new target boot
  into Makefile.inc1. Because, the boot programs must be made after
  cross-tools target and before par-depend target.
 
 I'm not sure this is the right way to do it. Aren't we already building
 sys/boot as part of buildworld?

No.

The boot0 and mbr images are needed for making makedevs.c. And,
makedes.c is made by depend target. So, we need building boot images
before running depend target (of course, before all target).

---
TAKAHASHI Yoshihiro
THE CENTER for INFORMATION SCIENCE, Kogakuin Univ.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: Fix sysinstall problem

2001-09-24 Thread Marcel Moolenaar

On Tue, Sep 25, 2001 at 11:27:58AM +0900, Takahashi Yoshihiro wrote:
   
   It uses the boot programs in /boot. So, even if we change boot0 and/or
   mbr, the new sysinstall includes old one. And, it breaks cross
   building, too.
   
  
  I'm not sure this is the right way to do it. Aren't we already building
  sys/boot as part of buildworld?
 
 The boot0 and mbr images are needed for making makedevs.c. And,
 makedes.c is made by depend target. So, we need building boot images
 before running depend target (of course, before all target).

I'd rather we remove the ordering constraint so that we don't have
to introduce a new mini-phase and thus keep the build clean. The
boot code is already being built, just not when it's needed by
sysinstall's depend target.

Idea 1:
Since we know how large the binaries are going to be, is it viable
to backpatch the boot0 and mbr images into the binary and only
reserve the space during compilation? This is probably less portable
than the following:

Idea 2:
We could link boot0.o and mbr.o into sysinstall. Currently both
object files contain a global symbol 'start'. It doesn't look to
me that those symbols should be named start, so we can rename
them to 'boot0_start' and 'mbr_start'. These symbols can then be
used in sysinstall to get to the bits.

Thoughts?

-- 
 Marcel Moolenaar USPA: A-39004  [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message