Re: Read-only /usr/obj/ no longer kosher?
> On Aug 26, 2015, at 19:03, O'Connor, Daniel wrote: > > >> On 27 Aug 2015, at 08:25, Pawel Jakub Dawidek wrote: >>> On Tue, Aug 25, 2015 at 03:32:35PM -0700, NGie Cooper wrote: On Tue, Aug 25, 2015 at 3:21 PM, Xin Li wrote: On 08/25/15 14:55, Pawel Jakub Dawidek wrote: >> Now that I think of it, it might have been that I did >> buildworld/buildkernel before -p1. Then freebsd-update updated >> newvers.sh and then I was trying to do installworld. > > Yes, I can now reproduce it with source updated to -p2. Yes, that's because freebsd-version.sh is generated from the files (but it's not clear to me whether if it's a bug or a feature that 'make install' checks if it's up-to-date and decides to regenerate it...). >>> >>> It's a quirk for sure. If you change the behavior, people will >>> definitely complain as they will now need to go back and rebuild >>> everything. >> >> What we have now is misleading. People should recompile. It is rather >> rare to see security advisory which bumps only patch level and something >> that doesn't require recompilation (eg. a shell script). Current >> behaviour would make people think they are running latest patch level >> because freebsd-version says so, eventhough they only did 'make >> installworld' without rebuilding affected binaries. > > So.. > How hard would it be to force CC/CXX to /usr/bin/false during installworld? Trivial in FreeBSD. Just make it so in Makefile for the installworld target, add false to itools, and add appropriate special casing in bsd.compiler.mk. Doing this just prevents recompiling though, so not pjd's case. Also, this might break someone's random usecase where they need CC/CXX to do something meaningful at install time, however, the likelihood of it being correct is slim IMHO.. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Read-only /usr/obj/ no longer kosher?
> On 27 Aug 2015, at 08:25, Pawel Jakub Dawidek wrote: > On Tue, Aug 25, 2015 at 03:32:35PM -0700, NGie Cooper wrote: >> On Tue, Aug 25, 2015 at 3:21 PM, Xin Li wrote: >>> On 08/25/15 14:55, Pawel Jakub Dawidek wrote: > Now that I think of it, it might have been that I did > buildworld/buildkernel before -p1. Then freebsd-update updated > newvers.sh and then I was trying to do installworld. Yes, I can now reproduce it with source updated to -p2. >>> >>> Yes, that's because freebsd-version.sh is generated from the files (but >>> it's not clear to me whether if it's a bug or a feature that 'make >>> install' checks if it's up-to-date and decides to regenerate it...). >> >> It's a quirk for sure. If you change the behavior, people will >> definitely complain as they will now need to go back and rebuild >> everything. > > What we have now is misleading. People should recompile. It is rather > rare to see security advisory which bumps only patch level and something > that doesn't require recompilation (eg. a shell script). Current > behaviour would make people think they are running latest patch level > because freebsd-version says so, eventhough they only did 'make > installworld' without rebuilding affected binaries. So.. How hard would it be to force CC/CXX to /usr/bin/false during installworld? -- Daniel O'Connor "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Read-only /usr/obj/ no longer kosher?
On Tue, Aug 25, 2015 at 03:32:35PM -0700, NGie Cooper wrote: > On Tue, Aug 25, 2015 at 3:21 PM, Xin Li wrote: > > On 08/25/15 14:55, Pawel Jakub Dawidek wrote: > >>> Now that I think of it, it might have been that I did > >>> buildworld/buildkernel before -p1. Then freebsd-update updated > >>> newvers.sh and then I was trying to do installworld. > >> > >> Yes, I can now reproduce it with source updated to -p2. > > > > Yes, that's because freebsd-version.sh is generated from the files (but > > it's not clear to me whether if it's a bug or a feature that 'make > > install' checks if it's up-to-date and decides to regenerate it...). > > It's a quirk for sure. If you change the behavior, people will > definitely complain as they will now need to go back and rebuild > everything. What we have now is misleading. People should recompile. It is rather rare to see security advisory which bumps only patch level and something that doesn't require recompilation (eg. a shell script). Current behaviour would make people think they are running latest patch level because freebsd-version says so, eventhough they only did 'make installworld' without rebuilding affected binaries. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com pgpRsLnByGkaA.pgp Description: PGP signature
Re: Read-only /usr/obj/ no longer kosher?
On Tue, Aug 25, 2015 at 3:21 PM, Xin Li wrote: > On 08/25/15 14:55, Pawel Jakub Dawidek wrote: >>> Now that I think of it, it might have been that I did >>> buildworld/buildkernel before -p1. Then freebsd-update updated >>> newvers.sh and then I was trying to do installworld. >> >> Yes, I can now reproduce it with source updated to -p2. > > Yes, that's because freebsd-version.sh is generated from the files (but > it's not clear to me whether if it's a bug or a feature that 'make > install' checks if it's up-to-date and decides to regenerate it...). It's a quirk for sure. If you change the behavior, people will definitely complain as they will now need to go back and rebuild everything. By and large though, recompiling things is really bad. That's I've seen others do `CC=false CXX=false` when calling installworld. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Read-only /usr/obj/ no longer kosher?
On 08/25/15 14:55, Pawel Jakub Dawidek wrote: >> Now that I think of it, it might have been that I did >> buildworld/buildkernel before -p1. Then freebsd-update updated >> newvers.sh and then I was trying to do installworld. > > Yes, I can now reproduce it with source updated to -p2. Yes, that's because freebsd-version.sh is generated from the files (but it's not clear to me whether if it's a bug or a feature that 'make install' checks if it's up-to-date and decides to regenerate it...). Cheers, -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die signature.asc Description: OpenPGP digital signature
Re: Read-only /usr/obj/ no longer kosher?
On Tue, Aug 25, 2015 at 11:53:47PM +0200, Pawel Jakub Dawidek wrote:
> On Tue, Aug 25, 2015 at 11:04:37PM +0200, Pawel Jakub Dawidek wrote:
> > On Sun, Aug 23, 2015 at 03:29:01PM -0700, Xin Li wrote:
> > >
> > >
> > > On 8/23/15 14:55, Pawel Jakub Dawidek wrote:
> > > > I used to build world and kernel on one machine and export both
> > > > /usr/src/ and
> > > > /usr/obj read-only to other machines. It doesn't work anymore (this is
> > > > from
> > > > 'make installworld'):
> > > >
> > > > ===> bin/freebsd-version (install)
> > > > eval $(egrep '^(TYPE|REVISION|BRANCH)='
> > > > /usr/src/bin/freebsd-version/../../sys/conf/newvers.sh) ; if ! sed -e
> > > > " s/@@TYPE@@/${TYPE}/g; s/@@REVISION@@/${REVISION}/g;
> > > > s/@@BRANCH@@/${BRANCH}/g; "
> > > > /usr/src/bin/freebsd-version/freebsd-version.sh.in >freebsd-version.sh
> > > > ; then rm -f freebsd-version.sh ; exit 1 ; fi
> > > > cannot create freebsd-version.sh: Permission denied
> > > > rm: freebsd-version.sh: Read-only file system
> > > > *** Error code 1
> > >
> > > What's the modification times of
> > > /usr/obj/usr/bin/freebsd-version/freebsd-version.sh,
> > > /usr/src/bin/freebsd-version/freebsd-version.sh and
> > > /usr/src/sys/conf/newvers.sh?
> >
> > I saw it twice, but cannot reproduce it anymore. This is 10.2-RELEASE,
> > I've send it to current@ by mistake. All in all my expectation is that
> > we shouldn't modify obj/ during installworld.
>
> Now that I think of it, it might have been that I did
> buildworld/buildkernel before -p1. Then freebsd-update updated
> newvers.sh and then I was trying to do installworld.
Yes, I can now reproduce it with source updated to -p2.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://mobter.com
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Read-only /usr/obj/ no longer kosher?
On Tue, Aug 25, 2015 at 11:04:37PM +0200, Pawel Jakub Dawidek wrote:
> On Sun, Aug 23, 2015 at 03:29:01PM -0700, Xin Li wrote:
> >
> >
> > On 8/23/15 14:55, Pawel Jakub Dawidek wrote:
> > > I used to build world and kernel on one machine and export both /usr/src/
> > > and
> > > /usr/obj read-only to other machines. It doesn't work anymore (this is
> > > from
> > > 'make installworld'):
> > >
> > > ===> bin/freebsd-version (install)
> > > eval $(egrep '^(TYPE|REVISION|BRANCH)='
> > > /usr/src/bin/freebsd-version/../../sys/conf/newvers.sh) ; if ! sed -e "
> > > s/@@TYPE@@/${TYPE}/g; s/@@REVISION@@/${REVISION}/g;
> > > s/@@BRANCH@@/${BRANCH}/g; "
> > > /usr/src/bin/freebsd-version/freebsd-version.sh.in >freebsd-version.sh ;
> > > then rm -f freebsd-version.sh ; exit 1 ; fi
> > > cannot create freebsd-version.sh: Permission denied
> > > rm: freebsd-version.sh: Read-only file system
> > > *** Error code 1
> >
> > What's the modification times of
> > /usr/obj/usr/bin/freebsd-version/freebsd-version.sh,
> > /usr/src/bin/freebsd-version/freebsd-version.sh and
> > /usr/src/sys/conf/newvers.sh?
>
> I saw it twice, but cannot reproduce it anymore. This is 10.2-RELEASE,
> I've send it to current@ by mistake. All in all my expectation is that
> we shouldn't modify obj/ during installworld.
Now that I think of it, it might have been that I did
buildworld/buildkernel before -p1. Then freebsd-update updated
newvers.sh and then I was trying to do installworld.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://mobter.com
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Read-only /usr/obj/ no longer kosher?
On Sun, Aug 23, 2015 at 03:29:01PM -0700, Xin Li wrote:
>
>
> On 8/23/15 14:55, Pawel Jakub Dawidek wrote:
> > I used to build world and kernel on one machine and export both /usr/src/
> > and
> > /usr/obj read-only to other machines. It doesn't work anymore (this is from
> > 'make installworld'):
> >
> > ===> bin/freebsd-version (install)
> > eval $(egrep '^(TYPE|REVISION|BRANCH)='
> > /usr/src/bin/freebsd-version/../../sys/conf/newvers.sh) ; if ! sed -e "
> > s/@@TYPE@@/${TYPE}/g; s/@@REVISION@@/${REVISION}/g;
> > s/@@BRANCH@@/${BRANCH}/g; "
> > /usr/src/bin/freebsd-version/freebsd-version.sh.in >freebsd-version.sh ;
> > then rm -f freebsd-version.sh ; exit 1 ; fi
> > cannot create freebsd-version.sh: Permission denied
> > rm: freebsd-version.sh: Read-only file system
> > *** Error code 1
>
> What's the modification times of
> /usr/obj/usr/bin/freebsd-version/freebsd-version.sh,
> /usr/src/bin/freebsd-version/freebsd-version.sh and
> /usr/src/sys/conf/newvers.sh?
I saw it twice, but cannot reproduce it anymore. This is 10.2-RELEASE,
I've send it to current@ by mistake. All in all my expectation is that
we shouldn't modify obj/ during installworld.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://mobter.com
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Read-only /usr/obj/ no longer kosher?
On 8/23/15 14:55, Pawel Jakub Dawidek wrote:
> I used to build world and kernel on one machine and export both /usr/src/ and
> /usr/obj read-only to other machines. It doesn't work anymore (this is from
> 'make installworld'):
>
> ===> bin/freebsd-version (install)
> eval $(egrep '^(TYPE|REVISION|BRANCH)='
> /usr/src/bin/freebsd-version/../../sys/conf/newvers.sh) ; if ! sed -e "
> s/@@TYPE@@/${TYPE}/g; s/@@REVISION@@/${REVISION}/g;
> s/@@BRANCH@@/${BRANCH}/g; "
> /usr/src/bin/freebsd-version/freebsd-version.sh.in >freebsd-version.sh ; then
> rm -f freebsd-version.sh ; exit 1 ; fi
> cannot create freebsd-version.sh: Permission denied
> rm: freebsd-version.sh: Read-only file system
> *** Error code 1
What's the modification times of
/usr/obj/usr/bin/freebsd-version/freebsd-version.sh,
/usr/src/bin/freebsd-version/freebsd-version.sh and
/usr/src/sys/conf/newvers.sh?
Cheers,
signature.asc
Description: OpenPGP digital signature
Read-only /usr/obj/ no longer kosher?
I used to build world and kernel on one machine and export both /usr/src/ and
/usr/obj read-only to other machines. It doesn't work anymore (this is from
'make installworld'):
===> bin/freebsd-version (install)
eval $(egrep '^(TYPE|REVISION|BRANCH)='
/usr/src/bin/freebsd-version/../../sys/conf/newvers.sh) ; if ! sed -e "
s/@@TYPE@@/${TYPE}/g; s/@@REVISION@@/${REVISION}/g; s/@@BRANCH@@/${BRANCH}/g;
" /usr/src/bin/freebsd-version/freebsd-version.sh.in >freebsd-version.sh ;
then rm -f freebsd-version.sh ; exit 1 ; fi
cannot create freebsd-version.sh: Permission denied
rm: freebsd-version.sh: Read-only file system
*** Error code 1
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://mobter.com
pgp0DzHE4AU2t.pgp
Description: PGP signature
