make world failure with today's current. (in /usr/src/sys/boot/i386/boot2/boot2.c)
Hi Guys, Source as of 4 hours ago I get the following in make world ... Cheers, Mark Full log of error follows : objcopy -S -O binary boot1.out boot1 dd if=/dev/zero of=boot2.ldr bs=276 count=1 2/dev/null nm -t d boot1.out | awk '/([0-9])+ T xread/ { x = $1 - ORG1; printf(#define X READORG %#x\n, REL1 + x) }' ORG1=`printf %d 0x7c00` REL1=`printf %d 0x700 ` boot2.h cc -elf -ffreestanding -Os -fno-builtin -fno-guess-branch-probability -fomit-fr ame-pointer -mno-align-long-strings -mrtd -DUFS1_AND_UFS2 -I/usr/src/sys/boot /i386/boot2/../../common -I/usr/src/sys/boot/i386/boot2/../btx/lib -I. -Wall - Waggregate-return -Wbad-function-cast -Wcast-align -Wmissing-declarations -Wmis sing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wstrict-prototypes - Wwrite-strings -ffreestanding -mpreferred-stack-boundary=2 -S -o boot2.s.tmp /u sr/src/sys/boot/i386/boot2/boot2.c /usr/src/sys/boot/i386/boot2/boot2.c: In function `load': /usr/src/sys/boot/i386/boot2/boot2.c:362: error: `RB_BOOTINFO' undeclared (first use in this function) /usr/src/sys/boot/i386/boot2/boot2.c:362: error: (Each undeclared identifier is reported only once /usr/src/sys/boot/i386/boot2/boot2.c:362: error: for each function it appears in .) *** Error code 1 Stop in /usr/src/sys/boot/i386/boot2. *** Error code 1 Stop in /usr/src/sys/boot/i386. *** Error code 1 Stop in /usr/src/sys/boot. *** Error code 1 Stop in /usr/src/sys. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
RB_BOOTINFO not found in sys/boot/i386/boot2/boot2.c
RB_BOOTINFO, defined in reboot.h, not found in sys/boot/i386/boot2/boot2.c .. can somebody fix this? ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: RB_BOOTINFO not found in sys/boot/i386/boot2/boot2.c
On 2003.11.11 11:15:11 +0200, Anton Yudin wrote: RB_BOOTINFO, defined in reboot.h, not found in sys/boot/i386/boot2/boot2.c .. can somebody fix this? I'm rather sure bde already fixed this some hours ago in src/sys/boot/i386/boot2/boot2.c v 1.66. -- Simon L. Nielsen FreeBSD Documentation Team pgp0.pgp Description: PGP signature
Re: i386/boot2.c patches
On 20-Mar-2002 Thomas Quinot wrote: Le 2002-03-20, John Baldwin écrivait : Looks mostly ok to me. Not entirely sure about the autoboot changes as it looks weird to load(kname) right before you change what kname is. I think the logic must somehow be wrong there. But this is what is currently in the code (as I mentioned in the PR, 36015 is strictly a code clarification, with no functional change). The load() function in boot2 ends with an exec() of the loaded binary. It returns only if it has failed. The purpose of replacing kname after load() has returned is to try to load /boot/kernel if we have failed to load /boot/loader. I was just saying it looked weird in the old code as well. Your explanation helps explain why though. -- John Baldwin [EMAIL PROTECTED]http://www.FreeBSD.org/~jhb/ Power Users Use the Power to Serve! - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
i386/boot2.c patches
Would anyone mind if I commit the following to i386/boot2.c? I've reviewed and tested them. add -n option to boot2 to disallow user interruption http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36016 boot2 cleanup (modulo style(9) and a minor typo in a comment): http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36015 -- Pierre Beyssac [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
RE: i386/boot2.c patches
On 20-Mar-2002 Pierre Beyssac wrote: Would anyone mind if I commit the following to i386/boot2.c? I've reviewed and tested them. add -n option to boot2 to disallow user interruption http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36016 Looks fine to me. boot2 cleanup (modulo style(9) and a minor typo in a comment): http://www.FreeBSD.org/cgi/query-pr.cgi?pr=36015 Looks mostly ok to me. Not entirely sure about the autoboot changes as it looks weird to load(kname) right before you change what kname is. I think the logic must somehow be wrong there. Might want to ask Robert Nordier for review. -- John Baldwin [EMAIL PROTECTED]http://www.FreeBSD.org/~jhb/ Power Users Use the Power to Serve! - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: i386/boot2.c patches
Le 2002-03-20, John Baldwin écrivait : Looks mostly ok to me. Not entirely sure about the autoboot changes as it looks weird to load(kname) right before you change what kname is. I think the logic must somehow be wrong there. But this is what is currently in the code (as I mentioned in the PR, 36015 is strictly a code clarification, with no functional change). The load() function in boot2 ends with an exec() of the loaded binary. It returns only if it has failed. The purpose of replacing kname after load() has returned is to try to load /boot/kernel if we have failed to load /boot/loader. Thomas. -- [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
boot2.c
I think I've just stumbled over a little problem with boot2.c in -current. If I boot a kernel directly from boot2 rather than through the loader, the root filesystem gets mounted as the old-style wd0s1a rather than the new ad0a (or whatever). This means that init gets somewhat upset if /etc/fstab has / as /dev/ad0a. :-) Given that the old wd driver is now deprecated, the correct fix is presumably just to change "wd" to "ad" on line 91 of src/sys/boot/i386/boot2/boot2.c? Chris. -- Chris Webb [EMAIL PROTECTED] Office: +44 1299 404075 Arachsys Internet Services LtdMobile: +44 7801 090045 To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message