Re: Blackbox does not compile, diff in here

2018-08-08 Thread Kubilay Kocak
On 9/08/2018 3:14 pm, Kubilay Kocak wrote:
> On 9/08/2018 3:05 pm, Erich Dollansky wrote:
>> Hi,
>>
>> On Thu, 9 Aug 2018 14:34:17 +1000
>> Kubilay Kocak  wrote:
>>
>>> On 9/08/2018 12:29 pm, Erich Dollansky wrote:

 I do not know if somebody spotted this already. Some casting was
 done to the wrong types.  
>>>
>>> This looks like
>>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708
>>>
>> yes, it is the same. But why could I compile blackbox without a problem
>> up to one or two months ago? Did the compiler to comprehend the problem
>> before?
> 
> The bug report doesn't contain system information (freebsd version/arch,
> date) so it's not immediately at this stage, but I have reproduced the
> error on 12-CURRENT (r336056) and am QA'ing other versions/archs as we
> speak.

Looks like it's Clang 6, so I'm guessing all reporters are running
12-CURRENT post clang 6 import.

See Also:

https://clang.debian.net/status.php?version=6.0=CXX11_NARROWING

> What's the uname -a of the system you are seeing this issue on? Could
> you add this information in the bug?
> 
> 
>> Erich
>>
>>
>>> The first and third chunks below appear to be
>>> noise/spurious/unnecessary though.
>>>
 Erich

 PS I am not experienced in creating diffs for ports. This one was
 done in the working directory's lib entry: 


 --- EWMH.cc.180809  2005-01-24
 15:50:56.0 +0800 +++ EWMH.cc 2018-08-09
 10:10:05.630203000 +0800 @@ -204,7 +204,7 @@
  bool bt::EWMH::readNumberOfDesktops(Window target,
   unsigned int* number) const {
unsigned char* data = 0;
 -  if (getProperty(target, XA_CARDINAL, net_number_of_desktops,
 )) {
 +  if (getProperty (target, XA_CARDINAL, net_number_of_desktops,
 )) { *number =
static_cast(*(reinterpret_cast>>> *>(data)));   
 @@ -246,8 +246,11 @@
  
  
  void bt::EWMH::setDesktopViewport(Window target, int x, int y)
 const {
 +   //
 +   // 09.08.18 ed: the following statement was modified.
 +   //
const unsigned long viewport[] =
 -{ static_cast(x), static_cast(y) };
 +{ static_cast(x), static_cast>>> long>(y) }; setProperty(target, XA_CARDINAL, net_desktop_viewport,
reinterpret_cast(viewport),
 2); }
 @@ -644,8 +647,10 @@
  }
  
  
 -bool bt::EWMH::getProperty(Window target, Atom type, Atom property,
 -unsigned char** data) const {
 +bool bt::EWMH::getProperty (Window target, Atom type, Atom
 property,
 +unsigned char  ** data)
 const { Atom atom_return;
int size;
unsigned long nitems, bytes_left;
 ___
 freebsd-ports@freebsd.org mailing list
 https://lists.freebsd.org/mailman/listinfo/freebsd-ports
 To unsubscribe, send any mail to
 "freebsd-ports-unsubscr...@freebsd.org" 
>>>
>>
> 

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Blackbox does not compile, diff in here

2018-08-08 Thread Kubilay Kocak
On 9/08/2018 3:05 pm, Erich Dollansky wrote:
> Hi,
> 
> On Thu, 9 Aug 2018 14:34:17 +1000
> Kubilay Kocak  wrote:
> 
>> On 9/08/2018 12:29 pm, Erich Dollansky wrote:
>>>
>>> I do not know if somebody spotted this already. Some casting was
>>> done to the wrong types.  
>>
>> This looks like
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708
>>
> yes, it is the same. But why could I compile blackbox without a problem
> up to one or two months ago? Did the compiler to comprehend the problem
> before?

The bug report doesn't contain system information (freebsd version/arch,
date) so it's not immediately at this stage, but I have reproduced the
error on 12-CURRENT (r336056) and am QA'ing other versions/archs as we
speak.

What's the uname -a of the system you are seeing this issue on? Could
you add this information in the bug?


> Erich
> 
> 
>> The first and third chunks below appear to be
>> noise/spurious/unnecessary though.
>>
>>> Erich
>>>
>>> PS I am not experienced in creating diffs for ports. This one was
>>> done in the working directory's lib entry: 
>>>
>>>
>>> --- EWMH.cc.180809  2005-01-24
>>> 15:50:56.0 +0800 +++ EWMH.cc 2018-08-09
>>> 10:10:05.630203000 +0800 @@ -204,7 +204,7 @@
>>>  bool bt::EWMH::readNumberOfDesktops(Window target,
>>>   unsigned int* number) const {
>>>unsigned char* data = 0;
>>> -  if (getProperty(target, XA_CARDINAL, net_number_of_desktops,
>>> )) {
>>> +  if (getProperty (target, XA_CARDINAL, net_number_of_desktops,
>>> )) { *number =
>>>static_cast(*(reinterpret_cast>> *>(data)));   
>>> @@ -246,8 +246,11 @@
>>>  
>>>  
>>>  void bt::EWMH::setDesktopViewport(Window target, int x, int y)
>>> const {
>>> +   //
>>> +   // 09.08.18 ed: the following statement was modified.
>>> +   //
>>>const unsigned long viewport[] =
>>> -{ static_cast(x), static_cast(y) };
>>> +{ static_cast(x), static_cast>> long>(y) }; setProperty(target, XA_CARDINAL, net_desktop_viewport,
>>>reinterpret_cast(viewport),
>>> 2); }
>>> @@ -644,8 +647,10 @@
>>>  }
>>>  
>>>  
>>> -bool bt::EWMH::getProperty(Window target, Atom type, Atom property,
>>> -unsigned char** data) const {
>>> +bool bt::EWMH::getProperty (Window target, Atom type, Atom
>>> property,
>>> +unsigned char  ** data)
>>> const { Atom atom_return;
>>>int size;
>>>unsigned long nitems, bytes_left;
>>> ___
>>> freebsd-ports@freebsd.org mailing list
>>> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
>>> To unsubscribe, send any mail to
>>> "freebsd-ports-unsubscr...@freebsd.org" 
>>
> 

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Blackbox does not compile, diff in here

2018-08-08 Thread Erich Dollansky
Hi,

On Thu, 9 Aug 2018 14:34:17 +1000
Kubilay Kocak  wrote:

> On 9/08/2018 12:29 pm, Erich Dollansky wrote:
> > 
> > I do not know if somebody spotted this already. Some casting was
> > done to the wrong types.  
> 
> This looks like
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708
> 
yes, it is the same. But why could I compile blackbox without a problem
up to one or two months ago? Did the compiler to comprehend the problem
before?

Erich


> The first and third chunks below appear to be
> noise/spurious/unnecessary though.
> 
> > Erich
> > 
> > PS I am not experienced in creating diffs for ports. This one was
> > done in the working directory's lib entry: 
> > 
> > 
> > --- EWMH.cc.180809  2005-01-24
> > 15:50:56.0 +0800 +++ EWMH.cc 2018-08-09
> > 10:10:05.630203000 +0800 @@ -204,7 +204,7 @@
> >  bool bt::EWMH::readNumberOfDesktops(Window target,
> >   unsigned int* number) const {
> >unsigned char* data = 0;
> > -  if (getProperty(target, XA_CARDINAL, net_number_of_desktops,
> > )) {
> > +  if (getProperty (target, XA_CARDINAL, net_number_of_desktops,
> > )) { *number =
> >static_cast(*(reinterpret_cast > *>(data)));   
> > @@ -246,8 +246,11 @@
> >  
> >  
> >  void bt::EWMH::setDesktopViewport(Window target, int x, int y)
> > const {
> > +   //
> > +   // 09.08.18 ed: the following statement was modified.
> > +   //
> >const unsigned long viewport[] =
> > -{ static_cast(x), static_cast(y) };
> > +{ static_cast(x), static_cast > long>(y) }; setProperty(target, XA_CARDINAL, net_desktop_viewport,
> >reinterpret_cast(viewport),
> > 2); }
> > @@ -644,8 +647,10 @@
> >  }
> >  
> >  
> > -bool bt::EWMH::getProperty(Window target, Atom type, Atom property,
> > -unsigned char** data) const {
> > +bool bt::EWMH::getProperty (Window target, Atom type, Atom
> > property,
> > +unsigned char  ** data)
> > const { Atom atom_return;
> >int size;
> >unsigned long nitems, bytes_left;
> > ___
> > freebsd-ports@freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> > To unsubscribe, send any mail to
> > "freebsd-ports-unsubscr...@freebsd.org" 
> 

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Blackbox does not compile, diff in here

2018-08-08 Thread Kubilay Kocak
On 9/08/2018 12:29 pm, Erich Dollansky wrote:
> Hi,
> 
> I do not know if somebody spotted this already. Some casting was done
> to the wrong types.

Hi Erich,

This looks like https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708

The first and third chunks below appear to be noise/spurious/unnecessary
though.

> Erich
> 
> PS I am not experienced in creating diffs for ports. This one was done
> in the working directory's lib entry: 
> 
> 
> --- EWMH.cc.180809  2005-01-24
> 15:50:56.0 +0800 +++ EWMH.cc 2018-08-09 10:10:05.630203000
> +0800 @@ -204,7 +204,7 @@
>  bool bt::EWMH::readNumberOfDesktops(Window target,
>   unsigned int* number) const {
>unsigned char* data = 0;
> -  if (getProperty(target, XA_CARDINAL, net_number_of_desktops, ))
> {
> +  if (getProperty (target, XA_CARDINAL, net_number_of_desktops,
> )) { *number =
>static_cast(*(reinterpret_cast *>(data))); 
> @@ -246,8 +246,11 @@
>  
>  
>  void bt::EWMH::setDesktopViewport(Window target, int x, int y) const {
> +   //
> +   // 09.08.18 ed: the following statement was modified.
> +   //
>const unsigned long viewport[] =
> -{ static_cast(x), static_cast(y) };
> +{ static_cast(x), static_cast(y) };
>setProperty(target, XA_CARDINAL, net_desktop_viewport,
>reinterpret_cast(viewport), 2);
>  }
> @@ -644,8 +647,10 @@
>  }
>  
>  
> -bool bt::EWMH::getProperty(Window target, Atom type, Atom property,
> -unsigned char** data) const {
> +bool bt::EWMH::getProperty (Window target, Atom type, Atom property,
> +unsigned char  ** data) const {
>Atom atom_return;
>int size;
>unsigned long nitems, bytes_left;
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
> 

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Blackbox does not compile, diff in here

2018-08-08 Thread Erich Dollansky
Hi,

I do not know if somebody spotted this already. Some casting was done
to the wrong types.

Erich

PS I am not experienced in creating diffs for ports. This one was done
in the working directory's lib entry: 


--- EWMH.cc.180809  2005-01-24
15:50:56.0 +0800 +++ EWMH.cc 2018-08-09 10:10:05.630203000
+0800 @@ -204,7 +204,7 @@
 bool bt::EWMH::readNumberOfDesktops(Window target,
  unsigned int* number) const {
   unsigned char* data = 0;
-  if (getProperty(target, XA_CARDINAL, net_number_of_desktops, ))
{
+  if (getProperty (target, XA_CARDINAL, net_number_of_desktops,
)) { *number =
   static_cast(*(reinterpret_cast(data))); 
@@ -246,8 +246,11 @@
 
 
 void bt::EWMH::setDesktopViewport(Window target, int x, int y) const {
+   //
+   // 09.08.18 ed: the following statement was modified.
+   //
   const unsigned long viewport[] =
-{ static_cast(x), static_cast(y) };
+{ static_cast(x), static_cast(y) };
   setProperty(target, XA_CARDINAL, net_desktop_viewport,
   reinterpret_cast(viewport), 2);
 }
@@ -644,8 +647,10 @@
 }
 
 
-bool bt::EWMH::getProperty(Window target, Atom type, Atom property,
-unsigned char** data) const {
+bool bt::EWMH::getProperty (Window target,
+
Atom   type,
+
Atom   property,
+unsigned char  ** data) const {
   Atom atom_return;
   int size;
   unsigned long nitems, bytes_left;
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Dmitri Goutnik
On 18-08-09 01:16:51, Julian Elischer wrote:
> On 8/8/18 6:30 pm, Jan Beich wrote:
> > Julian Elischer  writes:
> >
> >> g++ -O2 -pipe -DPANZURA_DEV -DPZ_LONGNAMES -fstack-protector -isystem
> >> /usr/local/include -fno-strict-aliasing -isystem /usr/local/include
> >> -fPIC -c pam_module/pam_oslogin_login.cc -o
> >> pam_module/pam_oslogin_login.o
> >> g++ -fstack-protector -I/usr/local/include/json-c -o
> >> google_authorized_keys authorized_keys/authorized_keys.cc
> >> utils/oslogin_utils.cc -lcurl -ljson-c
> >> g++ -fstack-protector -Wall -Wstrict-prototypes -fPIC -shared
> >> -Wl,-soname,libnss_cache_oslogin.so.2 -o
> >> libnss_cache_google-compute-engine-oslogin-1.3.0.so
> >> libnss_cache_oslogin/nss_cache_oslogin.o
> >> libnss_cache_oslogin/compat/getpwent_r.o
> >> utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
> >> directory
> >> utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
> >> directory
> > - GCC 4.2.1 (patched) from base system is not a supported configuration
> >on i386/amd64/aarch64/armv6/armv7
> > - C*FLAGS aren't consistently respected, see
> >https://wiki.freebsd.org/WarnerLosh/UsrLocal#Include_paths
> >https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html
> >
> > $ g++7 -v -xc++ -
> > [...]
> > ignoring nonexistent directory 
> > "/usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/include-fixed"
> > ignoring nonexistent directory 
> > "/usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/../../../../../x86_64-portbld-freebsd12.0/include"
> > #include "..." search starts here:
> > #include <...> search starts here:
> >   /usr/local/lib/gcc7/include/c++/
> >   /usr/local/lib/gcc7/include/c++//x86_64-portbld-freebsd12.0
> >   /usr/local/lib/gcc7/include/c++//backward
> >   /usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/include
> >   /usr/local/include <-- HERE is why pkg-fallout@ is silent
> Sorry you are out of my area of knowledge..
> All I know is that the port no longer compiles under amd64.
> though It did some months back.
> How it selects the compiler to use I have no clue..
> I got my pkg using make.conf but that is not a sustainable answer.
> 
> >   /usr/include
> > End of search list.
> >
> 
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Hi Julian,

As Jan said, port's Makefile is broken in a sense that not all of its binary 
targets respect CXXFLAGS. I took a stab at unbreaking the build, see 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230466

BTW, it compiles fine on 112a and 104i with base clang, not sure why original 
Makefile had USE_GCC.

-- Dmitri Goutnik
d...@syrec.org | https://syrec.org/d...@syrec.org.asc
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Julian Elischer

On 8/8/18 6:30 pm, Jan Beich wrote:

Julian Elischer  writes:


g++ -O2 -pipe -DPANZURA_DEV -DPZ_LONGNAMES -fstack-protector -isystem
/usr/local/include -fno-strict-aliasing -isystem /usr/local/include
-fPIC -c pam_module/pam_oslogin_login.cc -o
pam_module/pam_oslogin_login.o
g++ -fstack-protector -I/usr/local/include/json-c -o
google_authorized_keys authorized_keys/authorized_keys.cc
utils/oslogin_utils.cc -lcurl -ljson-c
g++ -fstack-protector -Wall -Wstrict-prototypes -fPIC -shared
-Wl,-soname,libnss_cache_oslogin.so.2 -o
libnss_cache_google-compute-engine-oslogin-1.3.0.so
libnss_cache_oslogin/nss_cache_oslogin.o
libnss_cache_oslogin/compat/getpwent_r.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
directory
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
directory

- GCC 4.2.1 (patched) from base system is not a supported configuration
   on i386/amd64/aarch64/armv6/armv7
- C*FLAGS aren't consistently respected, see
   https://wiki.freebsd.org/WarnerLosh/UsrLocal#Include_paths
   https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html

$ g++7 -v -xc++ -
[...]
ignoring nonexistent directory 
"/usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/include-fixed"
ignoring nonexistent directory 
"/usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/../../../../../x86_64-portbld-freebsd12.0/include"
#include "..." search starts here:
#include <...> search starts here:
  /usr/local/lib/gcc7/include/c++/
  /usr/local/lib/gcc7/include/c++//x86_64-portbld-freebsd12.0
  /usr/local/lib/gcc7/include/c++//backward
  /usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/include
  /usr/local/include <-- HERE is why pkg-fallout@ is silent

Sorry you are out of my area of knowledge..
All I know is that the port no longer compiles under amd64.
though It did some months back.
How it selects the compiler to use I have no clue..
I got my pkg using make.conf but that is not a sustainable answer.


  /usr/include
End of search list.



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


FreeBSD ports you maintain which are out of date

2018-08-08 Thread portscout
Dear port maintainer,

The portscout new distfile checker has detected that one or more of your
ports appears to be out of date. Please take the opportunity to check
each of the ports listed below, and if possible and appropriate,
submit/commit an update. If any ports have already been updated, you can
safely ignore the entry.

You will not be e-mailed again for any of the port/version combinations
below.

Full details can be found at the following URL:
http://portscout.freebsd.org/po...@freebsd.org.html


Port| Current version | New version
+-+
games/py-mnemosyne  | 2.6 | 2.6.1
+-+


If any of the above results are invalid, please check the following page
for details on how to improve portscout's detection and selection of
distfiles on a per-port basis:

http://portscout.freebsd.org/info/portscout-portconfig.txt

Thanks.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Jan Beich
Julian Elischer  writes:

> g++ -O2 -pipe -DPANZURA_DEV -DPZ_LONGNAMES -fstack-protector -isystem
> /usr/local/include -fno-strict-aliasing -isystem /usr/local/include
> -fPIC -c pam_module/pam_oslogin_login.cc -o
> pam_module/pam_oslogin_login.o
> g++ -fstack-protector -I/usr/local/include/json-c -o 
> google_authorized_keys authorized_keys/authorized_keys.cc
> utils/oslogin_utils.cc -lcurl -ljson-c
> g++ -fstack-protector -Wall -Wstrict-prototypes -fPIC -shared
> -Wl,-soname,libnss_cache_oslogin.so.2 -o 
> libnss_cache_google-compute-engine-oslogin-1.3.0.so
> libnss_cache_oslogin/nss_cache_oslogin.o
> libnss_cache_oslogin/compat/getpwent_r.o
> utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
> directory
> utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
> directory

- GCC 4.2.1 (patched) from base system is not a supported configuration
  on i386/amd64/aarch64/armv6/armv7
- C*FLAGS aren't consistently respected, see
  https://wiki.freebsd.org/WarnerLosh/UsrLocal#Include_paths
  https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html

$ g++7 -v -xc++ -
[...]
ignoring nonexistent directory 
"/usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/include-fixed"
ignoring nonexistent directory 
"/usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/../../../../../x86_64-portbld-freebsd12.0/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/lib/gcc7/include/c++/
 /usr/local/lib/gcc7/include/c++//x86_64-portbld-freebsd12.0
 /usr/local/lib/gcc7/include/c++//backward
 /usr/local/lib/gcc7/gcc/x86_64-portbld-freebsd12.0/7.3.0/include
 /usr/local/include <-- HERE is why pkg-fallout@ is silent
 /usr/include
End of search list.
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: Stage-qa doesn't complain about unstripped elfs in many cases

2018-08-08 Thread Mathieu Arnold
On Tue, Aug 07, 2018 at 11:29:39PM -0700, Yuri wrote:
> For example, on the misc/orange3 port:
> 
> > $ make stage-qa
> > > Running Q/A tests (stage-qa)
> > [yuri@yv /usr/ports/misc/orange3]$ file 
> > ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so
> > ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so:
> ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically
> linked, not stripped
> 
> 
> This is because the stage-qa check only looks at .debug sections, and
> file(1) looks at more sections.
> 
> My proposed partial fix was rejected:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230371 on the grounds that
> it goes against some other commit. So stage-qa doesn't check what it is
> supposed to check, and this is somehow ok.
> 
> 
> Should this stage-qa check be changed to just run file(1) and check if the
> output contains "not stripped" in it? What would be the downside of this? I
> also don't understand what is the downside of the rejected patch in
> bug#230371 that expands the list of sections.

I do not understand the point of this email.

I already told you that this was going against our policy.

The QA check does exactly what it needs to do.

-- 
Mathieu Arnold


signature.asc
Description: PGP signature


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Julian Elischer

On 8/8/18 2:30 pm, Julian Elischer wrote:

On 8/8/18 1:59 pm, Fernando Apesteguía wrote:
On Wed, Aug 8, 2018 at 7:40 AM Julian Elischer  
wrote:

On 8/8/18 1:02 pm, Julian Elischer wrote:

It says it can not find the file curl/curl.h which IS PRESENT as
/usr/local/include/curl/curl.h

There are Makefile BROKEN annotations for this error in mips etc but
I'm seeing it now on amd64.

I would think that all ports should have /usr/local/include in their
Include list but maybe not?

is this something that is supplied by the framework?


ports tree checked out from a week ago and today... same issue.


there is no /usr/local/include in the failing command line...

gmake[1]: Entering directory
'/usr/ports/sysutils/google-compute-engine-oslogin/work/compute-image-packages-20180611/google_compute_engine_oslogin' 


g++ -O2 -pipe  -fstack-protector  -fPIC -I/usr/local/include/json-c
-c utils/oslogin_utils.cc -o utils/oslogin_utils.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
directory


I'm guessing there should be but who's responsibility is it to put
it there?

I got past it by adding (temporarily) the following to make.conf

for some faiign g++ commands
CFLAGS+-I /usr/local/include

and for others
LDFLAGS+=-L/usr/local/lib -I /usr/local/include

but that stinks

better suggestions welcome..

Is this what you are looking for?

USES=localbase

https://www.freebsd.org/doc/en/books/porters-handbook/uses-localbase.html 



nope..
g++  -fstack-protector -Wall -Wstrict-prototypes -fPIC -shared 
-Wl,-soname,libnss_cache_oslogin.so.2 -o 
libnss_cache_google-compute-engine-oslogin-1.3.0.so 
libnss_cache_oslogin/nss_cache_oslogin.o 
libnss_cache_oslogin/compat/getpwent_r.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or 
directory
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or 
directory


seems that --system is being inconsistently applied

g++ -O2 -pipe -DPANZURA_DEV -DPZ_LONGNAMES -fstack-protector -isystem 
/usr/local/include -fno-strict-aliasing  -isystem /usr/local/include 
-fPIC -c pam_module/pam_oslogin_login.cc -o pam_module/pam_oslogin_login.o
g++  -fstack-protector -I/usr/local/include/json-c -o 
google_authorized_keys authorized_keys/authorized_keys.cc 
utils/oslogin_utils.cc -lcurl -ljson-c
g++  -fstack-protector -Wall -Wstrict-prototypes -fPIC -shared 
-Wl,-soname,libnss_cache_oslogin.so.2 -o 
libnss_cache_google-compute-engine-oslogin-1.3.0.so 
libnss_cache_oslogin/nss_cache_oslogin.o 
libnss_cache_oslogin/compat/getpwent_r.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or 
directory
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or 
directory



(and where/how?)


Julian



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to
"freebsd-ports-unsubscr...@freebsd.org"



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to 
"freebsd-ports-unsubscr...@freebsd.org"



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to 
"freebsd-ports-unsubscr...@freebsd.org"





___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Julian Elischer

On 8/8/18 1:59 pm, Fernando Apesteguía wrote:

On Wed, Aug 8, 2018 at 7:40 AM Julian Elischer  wrote:

On 8/8/18 1:02 pm, Julian Elischer wrote:

It says it can not find the file curl/curl.h which IS PRESENT as
/usr/local/include/curl/curl.h

There are Makefile BROKEN annotations for this error in mips etc but
I'm seeing it now on amd64.

I would think that all ports should have /usr/local/include in their
Include list but maybe not?

is this something that is supplied by the framework?


ports tree checked out from a week ago and today... same issue.


there is no /usr/local/include in the failing command line...

gmake[1]: Entering directory
'/usr/ports/sysutils/google-compute-engine-oslogin/work/compute-image-packages-20180611/google_compute_engine_oslogin'
g++ -O2 -pipe  -fstack-protector  -fPIC -I/usr/local/include/json-c
-c utils/oslogin_utils.cc -o utils/oslogin_utils.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
directory


I'm guessing there should be but who's responsibility is it to put
it there?

I got past it by adding (temporarily) the following to make.conf

for some faiign g++ commands
CFLAGS+-I /usr/local/include

and for others
LDFLAGS+=-L/usr/local/lib -I /usr/local/include

but that stinks

better suggestions welcome..

Is this what you are looking for?

USES=localbase

https://www.freebsd.org/doc/en/books/porters-handbook/uses-localbase.html


nope..
g++  -fstack-protector -Wall -Wstrict-prototypes -fPIC -shared 
-Wl,-soname,libnss_cache_oslogin.so.2 -o 
libnss_cache_google-compute-engine-oslogin-1.3.0.so 
libnss_cache_oslogin/nss_cache_oslogin.o 
libnss_cache_oslogin/compat/getpwent_r.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or 
directory
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or 
directory



(and where/how?)


Julian



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to
"freebsd-ports-unsubscr...@freebsd.org"



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Stage-qa doesn't complain about unstripped elfs in many cases

2018-08-08 Thread Yuri

For example, on the misc/orange3 port:

> $ make stage-qa
> > Running Q/A tests (stage-qa)
> [yuri@yv /usr/ports/misc/orange3]$ file 
./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so
> 
./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so: 
ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically 
linked, not stripped



This is because the stage-qa check only looks at .debug sections, and 
file(1) looks at more sections.


My proposed partial fix was rejected: 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230371 on the grounds 
that it goes against some other commit. So stage-qa doesn't check what 
it is supposed to check, and this is somehow ok.



Should this stage-qa check be changed to just run file(1) and check if 
the output contains "not stripped" in it? What would be the downside of 
this? I also don't understand what is the downside of the rejected patch 
in bug#230371 that expands the list of sections.



Yuri


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Julian Elischer

On 8/8/18 1:59 pm, Fernando Apesteguía wrote:

On Wed, Aug 8, 2018 at 7:40 AM Julian Elischer  wrote:

On 8/8/18 1:02 pm, Julian Elischer wrote:

It says it can not find the file curl/curl.h which IS PRESENT as
/usr/local/include/curl/curl.h

There are Makefile BROKEN annotations for this error in mips etc but
I'm seeing it now on amd64.

I would think that all ports should have /usr/local/include in their
Include list but maybe not?

is this something that is supplied by the framework?


ports tree checked out from a week ago and today... same issue.


there is no /usr/local/include in the failing command line...

gmake[1]: Entering directory
'/usr/ports/sysutils/google-compute-engine-oslogin/work/compute-image-packages-20180611/google_compute_engine_oslogin'
g++ -O2 -pipe  -fstack-protector  -fPIC -I/usr/local/include/json-c
-c utils/oslogin_utils.cc -o utils/oslogin_utils.o
utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
directory


I'm guessing there should be but who's responsibility is it to put
it there?

I got past it by adding (temporarily) the following to make.conf

for some faiign g++ commands
CFLAGS+-I /usr/local/include

and for others
LDFLAGS+=-L/usr/local/lib -I /usr/local/include

but that stinks

better suggestions welcome..

Is this what you are looking for?

USES=localbase

https://www.freebsd.org/doc/en/books/porters-handbook/uses-localbase.html


yeah that would help for  libs but not for the includes..  actually 
maybe it would't help because I'd still want /lib in the path.
the link you give says that LIBS would be replaced?  what does that 
actually mean?





(and where/how?)


Julian



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to
"freebsd-ports-unsubscr...@freebsd.org"



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"



___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"


Re: has a framework change broken sysutils/google-compute-engine-oslogin?

2018-08-08 Thread Fernando Apesteguía
On Wed, Aug 8, 2018 at 7:40 AM Julian Elischer  wrote:
>
> On 8/8/18 1:02 pm, Julian Elischer wrote:
> > It says it can not find the file curl/curl.h which IS PRESENT as
> > /usr/local/include/curl/curl.h
> >
> > There are Makefile BROKEN annotations for this error in mips etc but
> > I'm seeing it now on amd64.
> >
> > I would think that all ports should have /usr/local/include in their
> > Include list but maybe not?
> >
> > is this something that is supplied by the framework?
> >
> >
> > ports tree checked out from a week ago and today... same issue.
> >
> >
> > there is no /usr/local/include in the failing command line...
> >
> > gmake[1]: Entering directory
> > '/usr/ports/sysutils/google-compute-engine-oslogin/work/compute-image-packages-20180611/google_compute_engine_oslogin'
> > g++ -O2 -pipe  -fstack-protector  -fPIC -I/usr/local/include/json-c
> > -c utils/oslogin_utils.cc -o utils/oslogin_utils.o
> > utils/oslogin_utils.cc:16:23: error: curl/curl.h: No such file or
> > directory
> >
> >
> > I'm guessing there should be but who's responsibility is it to put
> > it there?
>
> I got past it by adding (temporarily) the following to make.conf
>
> for some faiign g++ commands
> CFLAGS+-I /usr/local/include
>
> and for others
> LDFLAGS+=-L/usr/local/lib -I /usr/local/include
>
> but that stinks
>
> better suggestions welcome..

Is this what you are looking for?

USES=localbase

https://www.freebsd.org/doc/en/books/porters-handbook/uses-localbase.html

>
> >
> > (and where/how?)
> >
> >
> > Julian
> >
> >
> >
> > ___
> > freebsd-ports@freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> > To unsubscribe, send any mail to
> > "freebsd-ports-unsubscr...@freebsd.org"
> >
> >
>
> ___
> freebsd-ports@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"