Re: FreeBSD 11.1-STABLE #0 r331865: geomWatch compilation fails

[Michael Grimm]

Dimitry Andric  wrote:
> On 3 Apr 2018, at 21:23, Michael Grimm  wrote:
>> 
>> Dimitry Andric  wrote:
>>> On 3 Apr 2018, at 19:34, Michael Grimm  wrote:

 Well, this time, after adding "USE_CXXSTD=gnu++98" into that port's 
 Makefile, poudriere has not been able to compile that port. Sadly. But 
 thank you anyway.
>>> 
>>> Please try the patches in .
>> 
>> I did apply your patch "Make geomWatch obey USE_CXXSTD=gnu++98 option" to 
>> sysutils/geomWatch/files/patch-Makefile and "USE_CXXSTD=gnu++98" to 
>> sysutils/geomWatch/Makefile, and it compiles successfully. Thanks.
>> 
>> P.S. Do you want me to apply Harald's patch "zfs-sysevent.h: Insert 
>> whitespaces for C++11 compile werror." in addition and/or as well?
> 
> Either Harald's patch, or mine, both is superfluous.

I did apply both patches to vanilla sysutils/geomWatch ports, respectively.
Both patches are compiling this port successfully.

Congratulations and regards,
Michael


___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD 11.1-STABLE #0 r331865: geomWatch compilation fails

[Dimitry Andric]

On 3 Apr 2018, at 21:23, Michael Grimm  wrote:
> 
> Dimitry Andric  wrote:
>> On 3 Apr 2018, at 19:34, Michael Grimm  wrote:
> 
>>> Well, this time, after adding "USE_CXXSTD=gnu++98" into that port's 
>>> Makefile, poudriere has not been able to compile that port. Sadly. But 
>>> thank you anyway.
>> 
>> Please try the patches in .
> 
> I did apply your patch "Make geomWatch obey USE_CXXSTD=gnu++98 option" to 
> sysutils/geomWatch/files/patch-Makefile and "USE_CXXSTD=gnu++98" to 
> sysutils/geomWatch/Makefile, and it compiles successfully. Thanks.
> 
> P.S. Do you want me to apply Harald's patch "zfs-sysevent.h: Insert 
> whitespaces for C++11 compile werror." in addition and/or as well?

Either Harald's patch, or mine, both is superfluous.

-Dimitry



signature.asc
Description: Message signed with OpenPGP

Re: FreeBSD 11.1-STABLE #0 r331865: geomWatch compilation fails

[Michael Grimm]

Dimitry Andric  wrote:
> On 3 Apr 2018, at 19:34, Michael Grimm  wrote:

>> Well, this time, after adding "USE_CXXSTD=gnu++98" into that port's 
>> Makefile, poudriere has not been able to compile that port. Sadly. But thank 
>> you anyway.
> 
> Please try the patches in .

I did apply your patch "Make geomWatch obey USE_CXXSTD=gnu++98 option" to 
sysutils/geomWatch/files/patch-Makefile and "USE_CXXSTD=gnu++98" to 
sysutils/geomWatch/Makefile, and it compiles successfully. Thanks.

P.S. Do you want me to apply Harald's patch "zfs-sysevent.h: Insert whitespaces 
for C++11 compile werror." in addition and/or as well?

Regards,
Michael

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD 11.1-STABLE #0 r331865: geomWatch compilation fails

[Dimitry Andric]

On 3 Apr 2018, at 19:34, Michael Grimm  wrote:
> 
> Dimitry Andric  wrote:
>> On 2 Apr 2018, at 21:33, Michael Grimm  wrote:
>>> since the recent upgrade of llvm et al in STABLE-11.1 geomWatch fails to 
>>> compile (poudriere):
>>> 
>>> In file included from geomWatch.cpp:41:
>>> In file included from ./zpool.hpp:35:
>>> In file included from 
>>> zfs/v28/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h:38:
>>> In file included from 
>>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_ioctl.h:30:
>>> In file included from 
>>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h:29:
>>> In file included from 
>>> zfs/v28/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:83:
>>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:79:37: 
>>> error: invalid suffix on literal; C++11 requires a space between literal 
>>> and identifier [-Wreserved-user-defined-literal]
>>> #define SUNW_KERN_PUB   SUNW_VENDOR":"SE_KERN_PUB
>>>^
>>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:80:36: 
>>> error: invalid suffix on literal; C++11 requires a space between literal 
>>> and identifier [-Wreserved-user-defined-literal]
>>> #define SUNW_USR_PUBSUNW_VENDOR":"SE_USR_PUB
>>>^
>> 
>> This can be fixed either by adding spaces before the double quotes, or
>> it can be worked around by adding USE_CXXSTD=gnu++98 in the port
>> Makefile.
> 
> Well, this time, after adding "USE_CXXSTD=gnu++98" into that port's Makefile, 
> poudriere has not been able to compile that port. Sadly. But thank you anyway.

Please try the patches in .

-Dimitry



signature.asc
Description: Message signed with OpenPGP

Re: FreeBSD 11.1-STABLE #0 r331865: geomWatch compilation fails

[Michael Grimm]

Dimitry Andric  wrote:
> On 2 Apr 2018, at 21:33, Michael Grimm  wrote:

>> since the recent upgrade of llvm et al in STABLE-11.1 geomWatch fails to 
>> compile (poudriere):
>> 
>> In file included from geomWatch.cpp:41:
>> In file included from ./zpool.hpp:35:
>> In file included from 
>> zfs/v28/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h:38:
>> In file included from 
>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_ioctl.h:30:
>> In file included from 
>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h:29:
>> In file included from 
>> zfs/v28/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:83:
>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:79:37: error: 
>> invalid suffix on literal; C++11 requires a space between literal and 
>> identifier [-Wreserved-user-defined-literal]
>> #define SUNW_KERN_PUB   SUNW_VENDOR":"SE_KERN_PUB
>> ^
>> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:80:36: error: 
>> invalid suffix on literal; C++11 requires a space between literal and 
>> identifier [-Wreserved-user-defined-literal]
>> #define SUNW_USR_PUBSUNW_VENDOR":"SE_USR_PUB
>> ^
> 
> This can be fixed either by adding spaces before the double quotes, or
> it can be worked around by adding USE_CXXSTD=gnu++98 in the port
> Makefile.

Well, this time, after adding "USE_CXXSTD=gnu++98" into that port's Makefile, 
poudriere has not been able to compile that port. Sadly. But thank you anyway.

Regards,
Michael

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: FreeBSD 11.1-STABLE #0 r331865: geomWatch compilation fails

[Dimitry Andric]

On 2 Apr 2018, at 21:33, Michael Grimm  wrote:
> 
> since the recent upgrade of llvm et al in STABLE-11.1 geomWatch fails to 
> compile (poudriere):
> 
> In file included from geomWatch.cpp:41:
> In file included from ./zpool.hpp:35:
> In file included from 
> zfs/v28/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h:38:
> In file included from 
> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_ioctl.h:30:
> In file included from 
> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h:29:
> In file included from 
> zfs/v28/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h:83:
> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:79:37: error: 
> invalid suffix on literal; C++11 requires a space between literal and 
> identifier [-Wreserved-user-defined-literal]
> #define SUNW_KERN_PUB   SUNW_VENDOR":"SE_KERN_PUB
>  ^
> 
> zfs/v28/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h:80:36: error: 
> invalid suffix on literal; C++11 requires a space between literal and 
> identifier [-Wreserved-user-defined-literal]
> #define SUNW_USR_PUBSUNW_VENDOR":"SE_USR_PUB
>  ^

This can be fixed either by adding spaces before the double quotes, or
it can be worked around by adding USE_CXXSTD=gnu++98 in the port
Makefile.

-Dimitry



signature.asc
Description: Message signed with OpenPGP