Re: USE_GMAKE fails in QATty?
07.07.2012 13:14, Vitaly Magerya пишет:
Hi, folks. I'm getting strange errors when building ports with
USE_GMAKE=YES on redports. See for yourself: [1-3]. It seems
that gmake is first built, but when it's time to install it --
turns out that it is already installed.
This only happens in QATty (i.e. with custom LOCALBASE and
PREFIX).
Does anyone know what's going on?
Seems that Mk/bsd.port.mk assumes that LOCALBASE for gmake
is always /usr/local. Please, try the following patch.
--
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Index: bsd.port.mk
===
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.732
diff -u -r1.732 bsd.port.mk
--- bsd.port.mk 1 Jul 2012 20:57:48 - 1.732
+++ bsd.port.mk 7 Jul 2012 12:20:17 -
@@ -1647,7 +1647,7 @@
EXTRACT_DEPENDS+= unmakeself:${PORTSDIR}/archivers/unmakeself
.endif
.if defined(USE_GMAKE)
-BUILD_DEPENDS+=gmake:${PORTSDIR}/devel/gmake
+BUILD_DEPENDS+=${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake
CONFIGURE_ENV+=MAKE=${GMAKE}
.endif
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: USE_GMAKE fails in QATty?
On 07/07/2012, Boris Samorodov b...@passap.ru wrote:
Seems that Mk/bsd.port.mk assumes that LOCALBASE for gmake
is always /usr/local. Please, try the following patch.
--- bsd.port.mk 1 Jul 2012 20:57:48 - 1.732
+++ bsd.port.mk 7 Jul 2012 12:20:17 -
@@ -1647,7 +1647,7 @@
EXTRACT_DEPENDS+=unmakeself:${PORTSDIR}/archivers/unmakeself
.endif
.if defined(USE_GMAKE)
-BUILD_DEPENDS+= gmake:${PORTSDIR}/devel/gmake
+BUILD_DEPENDS+= ${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake
CONFIGURE_ENV+= MAKE=${GMAKE}
.endif
It helps partially: gmake is correctly recognized as installed,
but building ports with it still does not work since GMAKE is
still gmake. This is additionally needed:
--- bsd.commands.mk.orig2012-07-07 16:59:52.0 +0300
+++ bsd.commands.mk 2012-07-07 16:59:44.0 +0300
@@ -43,7 +43,7 @@
FIND?= /usr/bin/find
FLEX?= /usr/bin/flex
FMT?= /usr/bin/fmt
-GMAKE?=gmake
+GMAKE?=${LOCALBASE}/bin/gmake
GREP?= /usr/bin/grep
GUNZIP_CMD?= /usr/bin/gunzip -f
GZCAT?=/usr/bin/gzcat
The problem comes down to the fact that redports/QATty changes
LOCALBASE, but does not put it into PATH. Are ports are supposed
to work without $LOCALBASE/bin in PATH? Maybe it's just a glitch
in redports setup?
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: USE_GMAKE fails in QATty?
07.07.2012 18:13, Vitaly Magerya пишет:
On 07/07/2012, Boris Samorodov b...@passap.ru wrote:
Seems that Mk/bsd.port.mk assumes that LOCALBASE for gmake
is always /usr/local. Please, try the following patch.
--- bsd.port.mk 1 Jul 2012 20:57:48 - 1.732
+++ bsd.port.mk 7 Jul 2012 12:20:17 -
@@ -1647,7 +1647,7 @@
EXTRACT_DEPENDS+=unmakeself:${PORTSDIR}/archivers/unmakeself
.endif
.if defined(USE_GMAKE)
-BUILD_DEPENDS+= gmake:${PORTSDIR}/devel/gmake
+BUILD_DEPENDS+= ${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake
CONFIGURE_ENV+= MAKE=${GMAKE}
.endif
It helps partially: gmake is correctly recognized as installed,
but building ports with it still does not work since GMAKE is
still gmake. This is additionally needed:
--- bsd.commands.mk.orig2012-07-07 16:59:52.0 +0300
+++ bsd.commands.mk 2012-07-07 16:59:44.0 +0300
@@ -43,7 +43,7 @@
FIND?= /usr/bin/find
FLEX?= /usr/bin/flex
FMT?= /usr/bin/fmt
-GMAKE?=gmake
+GMAKE?=${LOCALBASE}/bin/gmake
GREP?= /usr/bin/grep
GUNZIP_CMD?= /usr/bin/gunzip -f
GZCAT?=/usr/bin/gzcat
Yes, this is the right fix. I've overlooked this.
The problem comes down to the fact that redports/QATty changes
LOCALBASE, but does not put it into PATH. Are ports are supposed
to work without $LOCALBASE/bin in PATH? Maybe it's just a glitch
in redports setup?
All ports should support non standard LOCALBASE. Please, submit
a PR on the case with both patches and ask to assign to portmgr@.
This change needs to be tested at an exp-run.
--
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: USE_GMAKE fails in QATty?
On 07/07/2012 07:30, Boris Samorodov wrote: The problem comes down to the fact that redports/QATty changes LOCALBASE, but does not put it into PATH. Are ports are supposed to work without $LOCALBASE/bin in PATH? All ports should support non standard LOCALBASE. That wasn't the question. The ports system definitely has to have LOCALBASE/[s]bin in PATH, otherwise dependency detection won't work. See the changes I made (with input from others) to sys/conf/kern.post.mk for example. This smells like a problem with the redports configuration. Doug -- This .signature sanitized for your protection ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: USE_GMAKE fails in QATty?
On Jul 7, 2012 3:30 PM, Boris Samorodov b...@passap.ru wrote:
07.07.2012 18:13, Vitaly Magerya пишет:
On 07/07/2012, Boris Samorodov b...@passap.ru wrote:
Seems that Mk/bsd.port.mk assumes that LOCALBASE for gmake
is always /usr/local. Please, try the following patch.
--- bsd.port.mk 1 Jul 2012 20:57:48 - 1.732
+++ bsd.port.mk 7 Jul 2012 12:20:17 -
@@ -1647,7 +1647,7 @@
EXTRACT_DEPENDS+=unmakeself:${PORTSDIR}/archivers/unmakeself
.endif
.if defined(USE_GMAKE)
-BUILD_DEPENDS+= gmake:${PORTSDIR}/devel/gmake
+BUILD_DEPENDS+= ${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake
CONFIGURE_ENV+= MAKE=${GMAKE}
.endif
It helps partially: gmake is correctly recognized as installed,
but building ports with it still does not work since GMAKE is
still gmake. This is additionally needed:
--- bsd.commands.mk.orig2012-07-07 16:59:52.0 +0300
+++ bsd.commands.mk 2012-07-07 16:59:44.0 +0300
@@ -43,7 +43,7 @@
FIND?= /usr/bin/find
FLEX?= /usr/bin/flex
FMT?= /usr/bin/fmt
-GMAKE?=gmake
+GMAKE?=${LOCALBASE}/bin/gmake
GREP?= /usr/bin/grep
GUNZIP_CMD?= /usr/bin/gunzip -f
GZCAT?=/usr/bin/gzcat
Yes, this is the right fix. I've overlooked this.
The problem comes down to the fact that redports/QATty changes
LOCALBASE, but does not put it into PATH. Are ports are supposed
to work without $LOCALBASE/bin in PATH? Maybe it's just a glitch
in redports setup?
All ports should support non standard LOCALBASE. Please, submit
a PR on the case with both patches and ask to assign to portmgr@.
This change needs to be tested at an exp-run.
These patches make no sense. Loads of ports just depend on a binary name;
this is correct behaviour.
LOCALBASE/bin etc just needs adding to PATH.
Chris
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
