Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module
The following reply was made to PR usb/125736; it has been noted by GNATS.
From: Daniel Gerzo dan...@freebsd.org
To: bug-follo...@freebsd.org
Cc: h...@freebsd.org, ad...@lissyara.su
Subject: Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if
ukbd loaded as a module
Date: Sun, 8 Aug 2010 13:09:08 +
--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hello,
attached, I am sending patch which fixes other modules similarly.
--
Best regards,
Danile Gerzo
--X1bOJ3K7DJ5YkBrT
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename=hps.diff
Index: if_ndis/if_ndis_usb.c
===
--- if_ndis/if_ndis_usb.c (revision 211066)
+++ if_ndis/if_ndis_usb.c (working copy)
@@ -107,6 +107,7 @@
static devclass_t ndis_devclass;
DRIVER_MODULE(ndis, uhub, ndis_driver, ndis_devclass, ndisdrv_modevent, 0);
+MODULE_VERSION(ndis, 1);
static int
ndisusb_devcompare(interface_type bustype, struct ndis_usb_type *t, device_t
dev)
Index: usb/serial/u3g.c
===
--- usb/serial/u3g.c (revision 211066)
+++ usb/serial/u3g.c (working copy)
@@ -178,6 +178,7 @@
DRIVER_MODULE(u3g, uhub, u3g_driver, u3g_devclass, u3g_driver_loaded, 0);
MODULE_DEPEND(u3g, ucom, 1, 1, 1);
MODULE_DEPEND(u3g, usb, 1, 1, 1);
+MODULE_VERSION(u3g, 1);
static const struct usb_device_id u3g_devs[] = {
#define U3G_DEV(v,p,i) { USB_VPI(USB_VENDOR_##v, USB_PRODUCT_##v##_##p,
i) }
Index: usb/serial/ucycom.c
===
--- usb/serial/ucycom.c(revision 211066)
+++ usb/serial/ucycom.c(working copy)
@@ -176,6 +176,7 @@
DRIVER_MODULE(ucycom, uhub, ucycom_driver, ucycom_devclass, NULL, 0);
MODULE_DEPEND(ucycom, ucom, 1, 1, 1);
MODULE_DEPEND(ucycom, usb, 1, 1, 1);
+MODULE_VERSION(ucycom, 1);
/*
* Supported devices
Index: usb/serial/uark.c
===
--- usb/serial/uark.c (revision 211066)
+++ usb/serial/uark.c (working copy)
@@ -169,6 +169,7 @@
DRIVER_MODULE(uark, uhub, uark_driver, uark_devclass, NULL, 0);
MODULE_DEPEND(uark, ucom, 1, 1, 1);
MODULE_DEPEND(uark, usb, 1, 1, 1);
+MODULE_VERSION(uark, 1);
static const struct usb_device_id uark_devs[] = {
{USB_VPI(USB_VENDOR_ARKMICRO, USB_PRODUCT_ARKMICRO_ARK3116, 0)},
Index: usb/serial/ufoma.c
===
--- usb/serial/ufoma.c (revision 211066)
+++ usb/serial/ufoma.c (working copy)
@@ -326,6 +326,7 @@
DRIVER_MODULE(ufoma, uhub, ufoma_driver, ufoma_devclass, NULL, 0);
MODULE_DEPEND(ufoma, ucom, 1, 1, 1);
MODULE_DEPEND(ufoma, usb, 1, 1, 1);
+MODULE_VERSION(ufoma, 1);
static int
ufoma_probe(device_t dev)
Index: usb/serial/umct.c
===
--- usb/serial/umct.c (revision 211066)
+++ usb/serial/umct.c (working copy)
@@ -219,6 +219,7 @@
DRIVER_MODULE(umct, uhub, umct_driver, umct_devclass, NULL, 0);
MODULE_DEPEND(umct, ucom, 1, 1, 1);
MODULE_DEPEND(umct, usb, 1, 1, 1);
+MODULE_VERSION(umct, 1);
static int
umct_probe(device_t dev)
Index: usb/serial/uftdi.c
===
--- usb/serial/uftdi.c (revision 211066)
+++ usb/serial/uftdi.c (working copy)
@@ -205,6 +205,7 @@
DRIVER_MODULE(uftdi, uhub, uftdi_driver, uftdi_devclass, NULL, 0);
MODULE_DEPEND(uftdi, ucom, 1, 1, 1);
MODULE_DEPEND(uftdi, usb, 1, 1, 1);
+MODULE_VERSION(uftdi, 1);
static struct usb_device_id uftdi_devs[] = {
#define UFTDI_DEV(v,p,t) \
Index: usb/serial/uchcom.c
===
--- usb/serial/uchcom.c(revision 211066)
+++ usb/serial/uchcom.c(working copy)
@@ -855,3 +855,4 @@
DRIVER_MODULE(uchcom, uhub, uchcom_driver, uchcom_devclass, NULL, 0);
MODULE_DEPEND(uchcom, ucom, 1, 1, 1);
MODULE_DEPEND(uchcom, usb, 1, 1, 1);
+MODULE_VERSION(uchcom, 1);
Index: usb/serial/uipaq.c
===
--- usb/serial/uipaq.c (revision 211066)
+++ usb/serial/uipaq.c (working copy)
@@ -1085,6 +1085,7 @@
DRIVER_MODULE(uipaq, uhub, uipaq_driver, uipaq_devclass, NULL, 0);
MODULE_DEPEND(uipaq, ucom, 1, 1, 1);
MODULE_DEPEND(uipaq, usb, 1, 1, 1);
+MODULE_VERSION(uipaq, 1);
static int
uipaq_probe(device_t dev)
Index: usb/serial/ubser.c
===
--- usb/serial/ubser.c (revision 211066)
+++ usb/serial/ubser.c (working copy)
@@ -215,6 +215,7 @@
DRIVER_MODULE(ubser, uhub, ubser_driver, ubser_devclass, NULL, 0);
MODULE_DEPEND(ubser, ucom, 1, 1, 1);
MODULE_DEPEND(ubser, usb, 1, 1, 1);
Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module
The following reply was made to PR usb/125736; it has been noted by GNATS. From: Hans Petter Selasky hsela...@c2i.net To: Daniel =?iso-8859-15?q?Ger=B8o?= dan...@rulez.sk, Martin Matuska m...@freebsd.org Cc: bug-follo...@freebsd.org Subject: Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module Date: Sun, 8 Aug 2010 16:49:29 +0200 On Thursday 29 July 2010 23:03:28 Martin Matuska wrote: Hans Petter Selasky hsela...@freebsd.org recommended me to use MODULE_VERSION(ukbd, 1); in sys/dev/usb/input/ukbd.c I can confirm that this patch solves the problem and if there is nothing in the way I suggest importing it into HEAD and MFC-ing into stable/8 and stable/7. Thanks! Patch has been committed to USB P4. http://p4web.freebsd.org/@@182088?ac=10 Thanks for testing! --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module
The following reply was made to PR usb/125736; it has been noted by GNATS. From: Hans Petter Selasky hsela...@c2i.net To: Daniel =?iso-8859-15?q?Ger=B8o?= dan...@rulez.sk, Martin Matuska m...@freebsd.org Cc: bug-follo...@freebsd.org Subject: Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module Date: Sun, 8 Aug 2010 16:56:17 +0200 On Thursday 29 July 2010 23:03:28 Martin Matuska wrote: Hans Petter Selasky hsela...@freebsd.org recommended me to use MODULE_VERSION(ukbd, 1); in sys/dev/usb/input/ukbd.c I can confirm that this patch solves the problem and if there is nothing in the way I suggest importing it into HEAD and MFC-ing into stable/8 and stable/7. Thanks! Some typos: http://p4web.freebsd.org/@@182089?ac=10 Thanks for testing! --HPS ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module
The following reply was made to PR usb/125736; it has been noted by GNATS. From: Martin Matuska m...@freebsd.org To: bug-follo...@freebsd.org Cc: ad...@lissyara.su, Hans Petter Selasky hsela...@c2i.net Subject: Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module Date: Thu, 29 Jul 2010 23:03:28 +0200 This is a multi-part message in MIME format. --090802020002090909050102 Content-Type: text/plain; charset=windows-1250 Content-Transfer-Encoding: 7bit Hans Petter Selasky hsela...@freebsd.org recommended me to use MODULE_VERSION(ukbd, 1); in sys/dev/usb/input/ukbd.c I can confirm that this patch solves the problem and if there is nothing in the way I suggest importing it into HEAD and MFC-ing into stable/8 and stable/7. Thanks! --090802020002090909050102 Content-Type: text/plain; name=ukbd.c.patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=ukbd.c.patch Index: sys/dev/usb/input/ukbd.c === --- sys/dev/usb/input/ukbd.c (revision 210632) +++ sys/dev/usb/input/ukbd.c (working copy) @@ -1887,3 +1887,4 @@ DRIVER_MODULE(ukbd, uhub, ukbd_driver, ukbd_devclass, ukbd_driver_load, 0); MODULE_DEPEND(ukbd, usb, 1, 1, 1); +MODULE_VERSION(ukbd, 1); --090802020002090909050102-- ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module
The following reply was made to PR usb/125736; it has been noted by GNATS. From: Martin Matuska m...@freebsd.org To: bug-follo...@freebsd.org, ad...@lissyara.su Cc: Subject: Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module Date: Tue, 27 Jul 2010 14:13:10 +0200 I can confirm this and narrow it down a little: - this happens only if ukbd is already present in the kernel (e.g. GENERIC) and ukbd.ko gets loaded at boot - I can reproduce it on all my FreeBSD machines of different versions with GENERIC or other kernel containing ukbd - reproducible in virtualbox Steps to reproduce: - use a GENERIC kernel - escape to loader prompt on boot, type load ukbd.ko - type boot or boot -v for verbose prompt Boot hangs at keyboard detection. ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to freebsd-usb-unsubscr...@freebsd.org
Re: usb/125736: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module
Old Synopsis: [hang] system hangs after keyboard detect New Synopsis: [ukbd] [hang] system hangs after AT keyboard detect if ukbd loaded as a module State-Changed-From-To: feedback-open State-Changed-By: gavin State-Changed-When: Wed Jul 23 10:52:33 UTC 2008 State-Changed-Why: Feedback received: This is a problem seen by two different users, where loading ukbd as a module will cause the boot process to hang while detecting an AT keyboard iff ukbd is also built into the kernel Responsible-Changed-From-To: gavin-freebsd-usb Responsible-Changed-By: gavin Responsible-Changed-When: Wed Jul 23 10:52:33 UTC 2008 Responsible-Changed-Why: Over to maintainer(s) http://www.freebsd.org/cgi/query-pr.cgi?pr=125736 ___ freebsd-usb@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to [EMAIL PROTECTED]
