[Freeciv-Dev] (PR#40463) Registration

2008-08-27 Thread Дмитрий

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40463 

Hello!

How can I register at bugs.freeciv.org? Registration on
freeciv.wikia.com doesn't works.

Regards. Dmitry.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40464)

2008-08-27 Thread Daniel Doran

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40464 

I've spent a week (starting Aug 20) with a checkout copy of Freeciv SVN 
2.2.99, compiled it for GTK on Linux and I've been collecting notes on 
what I've discovered.  I've even got a patch for a problem I had with 
the default ruleset.  Should I dump my discoveries here or submit them 
through the bugs.freeciv.org RT system?



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40464)

2008-08-27 Thread Madeline Book

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40464 

 [EMAIL PROTECTED] - Wed Aug 27 16:45:52 2008]:
 
 I've spent a week (starting Aug 20) with a checkout copy of
 Freeciv SVN 2.2.99, compiled it for GTK on Linux and I've
 been collecting notes on what I've discovered.  I've even
 got a patch for a problem I had with the default ruleset.
 Should I dump my discoveries here or submit them through
 the bugs.freeciv.org RT system?

Send in one bug report per issue/patch, and follow the
guidelines at http://freeciv.wikia.com/wiki/Bug_Reporting .


--
いただきます〜

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40465) [Patch] Remove hardcoded autotoggle=1 on savegame load

2008-08-27 Thread Madeline Book

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40465 

Patch removes the hardcoded sending of set autotoggle 1
when the client loads a savegame. This appears to be a
constant source of grief for players when the server
toggles them to AI under unexpected (yet somehow common)
circumstances (e.g. client crash).

See for example: http://forum.freeciv.org/viewtopic.php?p=21357


--
厄払いしなければなりません。
diff --git a/client/connectdlg_common.c b/client/connectdlg_common.c
index 9f0998c..3cf8ead 100644
--- a/client/connectdlg_common.c
+++ b/client/connectdlg_common.c
@@ -486,7 +486,6 @@ void send_start_saved_game(void)
   char buf[MAX_LEN_MSG];
 
   send_chat(/set timeout 0);
-  send_chat(/set autotoggle 1);
   my_snprintf(buf, sizeof(buf), /take \%s\ \%s\,
   	  user_name, leader_name);
   send_chat(buf);
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40466) [Patch] Do not allow positive timeout less than 30

2008-08-27 Thread Madeline Book

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40466 

As mentioned on the forums:
http://forum.freeciv.org/viewtopic.php?p=21251

Patch prevents setting timeout values greater than
zero but less than 30 seconds, preventing abuse
due to e.g. timeout=1.


--
犯罪者は処刑される。
diff --git a/server/settings.c b/server/settings.c
index e1bb83b..484fc45 100644
--- a/server/settings.c
+++ b/server/settings.c
@@ -196,6 +196,19 @@ static bool aifill_callback(int value, const char **error_string)
   return TRUE;
 }
 
+/*
+  Check that the timeout value is reasonable.
+*/
+static bool timeout_callback(int value, const char **error_string)
+{
+  if (0  value  value  30) {
+*error_string = _(That timeout value is too low.);
+return FALSE;
+  }
+  *error_string = NULL;
+  return TRUE;
+}
+
 #define GEN_BOOL(name, value, sclass, scateg, slevel, to_client,	\
 		 short_help, extra_help, func, default)			\
   {name, sclass, to_client, short_help, extra_help, SSET_BOOL,		\
@@ -884,11 +897,13 @@ struct settings_s settings[] = {
 	  N_(Maximum seconds per turn),
 	  N_(If all players have not hit \Turn Done\ before this 
 	 time is up, then the turn ends automatically. Zero 
-	 means there is no timeout. In servers compiled with 
+	 means there is no timeout, and positive values below 
+	 30 are not allowed. In servers compiled with 
 	 debugging, a timeout 
 	 of -1 sets the autogame test mode. Use this with the command 
-	 \timeoutincrease\ to have a dynamic timer.), NULL, 
-	   GAME_MIN_TIMEOUT, GAME_MAX_TIMEOUT, GAME_DEFAULT_TIMEOUT)
+	 \timeoutincrease\ to have a dynamic timer.),
+	  timeout_callback, GAME_MIN_TIMEOUT, GAME_MAX_TIMEOUT,
+	  GAME_DEFAULT_TIMEOUT)
 
   GEN_INT(timeaddenemymove, game.timeoutaddenemymove,
 	  SSET_META, SSET_INTERNAL, SSET_VITAL, SSET_TO_CLIENT,
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40467) [Patch] Wonder status character in German translation

2008-08-27 Thread Nicolas R. Wadhwani

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40467 

Am Donnerstag, 28. August 2008 02:26:02 schrieb Madeline Book:
 URL: http://bugs.freeciv.org/Ticket/Display.html?id=40467 

 Of course, I would perfer if a translator could had
 a look and possibly think of better abbreviations that
 would be both intuitive and consistent with the rest
 of the German translation.

Well, I'm not really a translator but I happen to be able to understand 
german, although not always really understanding Germans. ;) Germans really 
do like abbreviations, but to me that is mostly more confusing than helping. 
Maybe that is just because I have to memorize dozens of germans and english 
abbreviations... 

I always wondered about the w in the english native version as well as about 
the + in the translation. Now you posted this I finally get it. :D Is it 
really so crucial for the length of a message string that you can't just 
write wonder or built in it? Though I don't really see why this info text 
is particulary necessary anyways, as this particulary piece of news is the 
very reason of the message itself. I would like to see it only in the 
production info or progress bar as available (verfügbar) or built 
(gebaut), but that would mean some more work for all the other language 
translators...

Greetings,
Nico



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40444) Simultaneous Phases in 2.1.x

2008-08-27 Thread Marko Lindqvist

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40444 

2008/8/28 Madeline Book:
 Version 3 remains compatible with pre 2.2 savegames by
 checking for the presence of the old settings in the
 secfile.

 It's generally not a good idea to rely on version number for checking
savegame options. It should be possible to use values really present
in savegame in the lines of:

 old = look_bool_default(TRUE...)
 if (old)
new_default = 1
 else
new_default = 1
 final = look_int_default(new_default...)

 Failing that, you should use savegame options.

 In any case your check against 020200 means that current S2_2
development version 2.1.99 is not reading new values.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev