[Freeciv-Dev] [bug #13542] [Patch] Game scenario properties in property editor
URL: http://gna.org/bugs/?13542 Summary: [Patch] Game scenario properties in property editor Project: Freeciv Submitted by: mbook Submitted on: Thursday 05/21/2009 at 06:04 Category: editor Severity: 3 - Normal Priority: 1 - Later Status: Ready For Test Assigned to: mbook Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: Attached patch implements the 4 new scenario fields of the game struct as editable properties of the game object in the property editor, and a few other small changes I did not feel like splitting into separate patches. Depends on RT#40229, GNA#13540. The main novelty is that the extviewer property widget is augmented so that the 'description' property can be edited in a full, multi-line textview. Some small improvements/changes in nearby code: - Removed the 'is_scenario' if-test in handle_scenario _info(), on both the client side and the server side (this is because the property editor expects that fields can be set individually). - Added editable gtktextviews to the types of widgets allowed to grab keyboard events in toplevel_handler() in gui_main.c (man was this annoying to track down). - Updated network capstring due to new packet fields. - Added error message for missing handler in extviewer_view_cell_toggled(). - Split up propval_free() into itself and propval_free _data() (I thought this would be needed, but then it turned out not to be; I left it anyway for posterity). - Factored out some common code in extviewer_clear _widgets() switch cases. - Fixed typo extviwer (twice). I'm not sure if the duplicated work in handle_scenario _info() and handle_edit_game() is ideal. Sure if there were a specialized gui widget for setting scenario parameters it would have to use the scenario info packet, but I think the property editor is enough (I will fix it up soon so that it is less annoying to use). I also noticed that I am basically reimplementing the delta code in the edit handlers... it would be great if the handler functions could access the delta bitfields so that the if-checks would not need to be run twice, but I suppose the delta compression could also just be turned off with the 'no-delta' flag in the packet definitions. I'll check which solution would be best later. 私のシナリオにある役割が欲しいか。 ___ File Attachments: --- Date: Thursday 05/21/2009 at 06:04 Name: game_scenario_properties.patch Size: 21kB By: mbook http://gna.org/bugs/download.php?file_id=5799 ___ Reply to this item at: http://gna.org/bugs/?13542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13542] [Patch] Game scenario properties in property editor
Update of bug #13542 (project freeciv): Priority: 1 - Later = 5 - Normal ___ Reply to this item at: http://gna.org/bugs/?13542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13543] [Patch] Sanitize strings in object list columns
URL: http://gna.org/bugs/?13543 Summary: [Patch] Sanitize strings in object list columns Project: Freeciv Submitted by: mbook Submitted on: Thursday 05/21/2009 at 06:26 Category: editor Severity: 2 - Minor Priority: 3 - Low Status: Ready For Test Assigned to: mbook Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: A small patch to pretty-print strings in columns of the object list in the property editor. Newlines, tabs, etc. are replaced by spaces and if the string is longer than 28 characters, it is truncated and suffixed with 絶妙な証明を発見した… ___ File Attachments: --- Date: Thursday 05/21/2009 at 06:26 Name: sanitize_object_list_strings.diff Size: 1kB By: mbook http://gna.org/bugs/download.php?file_id=5800 ___ Reply to this item at: http://gna.org/bugs/?13543 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13544] [Patch] Menu item for game/scenario properties
URL: http://gna.org/bugs/?13544 Summary: [Patch] Menu item for game/scenario properties Project: Freeciv Submitted by: mbook Submitted on: Thursday 05/21/2009 at 06:37 Category: editor Severity: 2 - Minor Priority: 3 - Low Status: Ready For Test Assigned to: mbook Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: Patch implements a menu item in the Edit menu that when activated brings up the property editor showing the game property page. To support this, editgui_popup_properties() is made to take a preferred page argument, and all occurences and stubs are updated. メニューを見せていただけませんか。 ___ File Attachments: --- Date: Thursday 05/21/2009 at 06:37 Name: scenario_properties_menu_item.patch Size: 10kB By: mbook http://gna.org/bugs/download.php?file_id=5801 ___ Reply to this item at: http://gna.org/bugs/?13544 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40229) [Patch] SaveScenario
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40229 [book - Tue May 12 16:17:19 2009]: [cazf...@gmail.com - Tue May 12 15:21:56 2009]: 2009/5/6 Marko Lindqvist cazf...@gmail.com: 2008/5/4 Marko Lindqvist cazf...@gmail.com: This adds server command for saving current game as scenario (and not as regular savegame) New version Scenario info structure now contains information whether current players or start positions should be saved to scenario. This patch has no client side UI for adjusting scenario parameters. I have been testing this just by sending hardcoded scenario info packets from client to server. Madeline, what kind of UI would best fit overall editor design? We should be able to set generic scenario parameters such as name, description and whether scenario has preset players or only starting locations. You can use the property editor system: add the scenario parameters as properties of the game object. The steps to do this are documented near the top of editprop.c, in the objprop declaration header. I can do this for you in the next few days if you like, I have done this now in GNA#13542. --- 失敗は構わん。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13404] -R ranklog flag does not produce ranklog
Follow-up Comment #3, bug #13404 (project freeciv): Verified that ranklog is indeed produced at game end, and implemented a parser for it in my PHP code to determine game winner (solves cases where game winner might not be the player with the highest score) and exact turncount for parsing savegames. The fact that ranklog is only produced at game end also appears to be a handy way for cron scripts to figure out when the game has ended, for the purpose of triggering automatic processing of the game files and starting a new game on the port. So yeah, please close this bug as not a bug, thanks (: ___ Reply to this item at: http://gna.org/bugs/?13404 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13546] [Patch] Always select first object in property editor object list
URL: http://gna.org/bugs/?13546 Summary: [Patch] Always select first object in property editor object list Project: Freeciv Submitted by: mbook Submitted on: Thursday 05/21/2009 at 22:33 Category: editor Severity: 2 - Minor Priority: 5 - Normal Status: Ready For Test Assigned to: mbook Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: Attached patch makes the property editor always automatically select the first object in the object list, for the convenience of the user. 懐中電灯を持ってきておきます。 ___ File Attachments: --- Date: Thursday 05/21/2009 at 22:33 Name: always_select_first_objbind.diff Size: 684B By: mbook http://gna.org/bugs/download.php?file_id=5803 ___ Reply to this item at: http://gna.org/bugs/?13546 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
