[Freeciv-Dev] [patch #1292] /cancelvote command

2009-09-30 Thread pepeto 

Follow-up Comment #7, patch #1292 (project freeciv):

Uploading the right patches.


(file #6837, file #6838)
___

Additional Item Attachment:

File name: trunk_S2_2_cancelvote_command4.diff Size:4 KB
File name: S2_1_cancelvote_command2.diff  Size:4 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1292] /cancelvote command

2009-09-30 Thread pepeto 

Follow-up Comment #6, patch #1292 (project freeciv):

Update patch for S2_1 and remove one useless test before displaying the same
message anyway.


(file #6835, file #6836)
___

Additional Item Attachment:

File name: trunk_S2_2_cancelvote_command4.diff Size:12 KB
File name: S2_1_cancelvote_command2.diff  Size:7 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1296] restructure basic notify functions

2009-09-30 Thread pepeto 

Follow-up Comment #9, patch #1296 (project freeciv):

> One remark: if the packet should be used for another function,
> it should not be changed at all. Does this mean a 'const'
> keyword would be needed? This would again require to make a copy
> of the packet to change the coordinates.

Ok, I took your idea.


(file #6834)
___

Additional Item Attachment:

File name: trunk_S2_2_restructure_notify_conn3.diff Size:7 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1254] generalize bounce_unit()

2009-09-30 Thread pepeto 

Update of patch #1254 (project freeciv):

Priority:  5 - Normal => 3 - Low
  Status:None => Postponed  
 Assigned to:  pepeto => None   

___

Follow-up Comment #3:

Then, I think it would need at least comments about this, and maybe macros
defined at the same place.

I leave this ticket open for the moment, waiting for a interesting need of
it...


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1254] generalize bounce_unit()

2009-09-30 Thread Matthias Pfafferodt 

Follow-up Comment #2, patch #1254 (project freeciv):

Let's check; bouncing is used in:

* game_load_internal(); dist = 2; corrupt savegame; use dist = 1 to consider
only the surrounding tiles?

* throw_units_from_illegal_cities(); dist = 2; check units in a city after an
owner change, ...; dist could here be equal to city radius so that the units
are spread within this area

* resolve_stack_conflicts(); dist = 2; after an alliance break; use dist = 1
(no teleporting!)

* (possible use) transfer_unit(); I want to check this function again ...

As listed above the distance could be fixed to 1 for checks (savegame; stack
resolve) and to the city radius.

Is it possible to go from alliance to war? If yes, dist = 1 for stack resolve
would mean that the units could attack each over directly after this.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1296] restructure basic notify functions

2009-09-30 Thread Matthias Pfafferodt 

Follow-up Comment #8, patch #1296 (project freeciv):

>> I think the reset of the coordinates (x,y) within the packet
>> is needed, as the same packet struct could also be used for 
>> offline events. 

One remark: if the packet should be used for another function, it should not
be changed at all. Does this mean a 'const' keyword would be needed? This
would again require to make a copy of the packet to change the coordinates.

> I do the same. I am working on Freeciv code for 3 years, and I 
> still ignore some things. 

Nice to know that I'm not alone ;-)

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev