[Freeciv-Dev] [bug #17579] Ocean city gfx uses memory many times

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?17579

 Summary: Ocean city gfx uses memory many times
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 26 Jan 2011 01:55:36 PM EET
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

I write this bug report just to save my old notes (from the time when
separate ocean city gfx was added). I have not checked if all of this apply to
current codebase.

It's likely that tileset has more styles for land cities than for ocean
cities. Both land and ocean city gfx are defined in same city_style structure.
In practice there is one city_style structure / land city style, and multiple
city_styles use same ocean city style.
Problem is that each city_style loads ocean city gfx to memory independently.
Even if they in fact use same gfx, each of them use separate copy in memory.
There should be way to different city_style structures to share same gfx in
memory.




___

Reply to this item at:

  http://gna.org/bugs/?17579

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17579] Ocean city gfx uses memory many times

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #1, bug #17579 (project freeciv):

Same problem probably applies to multiple bases sharing same gfx. Sensible
use-case for such bases would be scenario where somewhat different (maybe only
differently named) unbuildable bases are already placed on map.

___

Reply to this item at:

  http://gna.org/bugs/?17579

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2287] Vedic nation

2011-01-26 Thread J.M. Maalderink

Update of patch #2287 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2287

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17576] connectmsg command does not work

2011-01-26 Thread Matthias Pfafferodt

Follow-up Comment #2, bug #17576 (project freeciv):

this seems to be similar to patch #2294 and bug #16948 ...

___

Reply to this item at:

  http://gna.org/bugs/?17576

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2350] Callbacks to AI Interface to be called on phase begin and finishing

2011-01-26 Thread Marko Lindqvist

Update of patch #2350 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2350

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2415] Correct experimental ruleset descriptions to say they belong to experimental

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2415

 Summary: Correct experimental ruleset descriptions to say
they belong to experimental
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 26 Jan 2011 04:42:38 PM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0, 2.4.0

___

Details:

Most experimental rulesets have description saying they are default
ruleset. Fix attached.



___

File Attachments:


---
Date: Wed 26 Jan 2011 04:42:38 PM EET  Name: ExperimentalDesc.diff  Size: 3kB
  By: cazfi

http://gna.org/patch/download.php?file_id=12109

___

Reply to this item at:

  http://gna.org/patch/?2415

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17581] No trade_priority in ai_data

2011-01-26 Thread anonymous

URL:
  http://gna.org/bugs/?17581

 Summary: No trade_priority in ai_data
 Project: Freeciv
Submitted by: None
Submitted on: Wed Jan 26 14:57:05 2011
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: freecivforum5...@live.co.uk
 Open/Closed: Open
 Release: 2.3.0-beta1
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There is no trade_priority variable defined in server/advisors/advdata.h
along with the other dynamic weights (beginning on line 141 in beta1) - and
consequently no want modification for improvements that give a trade bonus in
city_want in advbuilding.c.

Considering the importance of trade this looks like a serious mistake,
although I might have missed something elsewhere.





___

Reply to this item at:

  http://gna.org/bugs/?17581

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2416] Threads safe logging

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2416

 Summary: Threads safe logging
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 26 Jan 2011 06:29:46 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This patch makes logfile appending thread safe.



___

File Attachments:


---
Date: Wed 26 Jan 2011 06:29:46 PM EET  Name: ThreadSafeLogging.diff  Size:
5kB   By: cazfi

http://gna.org/patch/download.php?file_id=12110

___

Reply to this item at:

  http://gna.org/patch/?2416

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2219] [autosettler] use aiplayer framework

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2219 (project freeciv):

  Depends on: = patch #2374


___

Reply to this item at:

  http://gna.org/patch/?2219

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2376] Fetching general files with curl

2011-01-26 Thread Marko Lindqvist

Update of patch #2376 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2376

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17557] Max_Rates effect with tech requirement causes assert failure

2011-01-26 Thread Matthias Pfafferodt

Update of bug #17557 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17557

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2379] add new option revealmap

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2379 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = syntron
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2379

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2378] Server - metaserver post with curl

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #3, patch #2378 (project freeciv):

- Free http post structure after use

(file #12111)
___

Additional Item Attachment:

File name: CurlMeta_2378-4.diff   Size:13 KB


___

Reply to this item at:

  http://gna.org/patch/?2378

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2298] Metaserver update thread

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #2, patch #2298 (project freeciv):

- Updated against changes in other patches in series
- Build post in main thread and only do the actual sending in new thread.
Building the post requires accessing numerous data structures that are
currently not protected by mutexes, so accessing them from metaserver thread
would risk them being simultaneously modified by main thread and them being in
inconsistent state (player counter being different from number of player
structures allocated being most severe possibility)

(file #12112)
___

Additional Item Attachment:

File name: MetaSrvThread_2298-3.diff  Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?2298

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2298] Metaserver update thread

2011-01-26 Thread Marko Lindqvist

Update of patch #2298 (project freeciv):

  Depends on: = patch #2416


___

Reply to this item at:

  http://gna.org/patch/?2298

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2396] Tech Cost Styles 3 4

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2396 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2396

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2404] update debugging of upkeep calculation

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2404 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2404

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2367] [citizens13] poison citizens of the city owner

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #1, patch #2367 (project freeciv):

I have not checked other nationality patches so I don't understand what
exactly this patch does, but isn't this unrealistic?
If spy poisons city water supply, how come it affects only citizens of
certain nationality?

___

Reply to this item at:

  http://gna.org/patch/?2367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2395] Call Qt-client add_ggz_input() via function pointer layer

2011-01-26 Thread Marko Lindqvist

Update of patch #2395 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2395

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17518] [citizens01] use PLR_DLG_COL_* constants in plrdlg.c (gtk)

2011-01-26 Thread Matthias Pfafferodt

Update of bug #17518 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17518

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2357] [citizens03] cleanup naming of *vision_site* functions

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2357 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2357

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2405] First Qt-Client layout

2011-01-26 Thread Marko Lindqvist

Update of patch #2405 (project freeciv):

  Status:None = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?2405

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2358] [citizens04] accessor function for vision_site-size

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2358 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2358

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17582] [metaticket] Headers depend on config.h

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?17582

 Summary: [metaticket] Headers depend on config.h
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 26 Jan 2011 09:58:20 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

One goal for ai module support development is that it would be possible to
develop alternative AIs outside freeciv source tree, in independent project
that would only use Freeciv, not be part of it.

One thing preventing this is that some of our headers depend on macros
defined on freeciv config.h. For a number of reasons, it's not advisable to
include freeciv config.h from sources of some other project. And implementing
such an include from freeciv *build* directory would be ugly.

Workarounds such as copying config.h from freeciv and modifying it exist, so
I don't consider this Blocker for ai modules support of 2.4. If time runs
short, this refactoring can be retargeted to 2.5.




___

Reply to this item at:

  http://gna.org/bugs/?17582

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2359] [citizens05] accessor function for city-size

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2359 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2359

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2361] [citizens07] add sg_warn() macro to savegame2.c

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2361 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2361

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2367] [citizens13] poison citizens of the city owner

2011-01-26 Thread Matthias Pfafferodt

Follow-up Comment #2, patch #2367 (project freeciv):

 I have not checked other nationality patches so I don't
 understand what exactly this patch does, but isn't this
 unrealistic? 
 If spy poisons city water supply, how come it affects only
 citizens of certain nationality?

It is an example how the citizens information can be used. If I poison a city
I want to harm the owner of the city. This is simplified in poisoning one of
its citizens 

___

Reply to this item at:

  http://gna.org/patch/?2367

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17563] Nation ruleset warnings when making update-po

2011-01-26 Thread Jacob Nevins

Update of bug #17563 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17563

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17583] games-strategy/freeciv-2.2.2 aborts after loading certain old saved games

2011-01-26 Thread anonymous

URL:
  http://gna.org/bugs/?17583

 Summary: games-strategy/freeciv-2.2.2 aborts after loading
certain old saved games
 Project: Freeciv
Submitted by: None
Submitted on: Mi 26 Jan 2011 20:37:04 UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: johannes.ge...@web.de
 Open/Closed: Open
 Release: 2.2.2
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

FreeCiv cannot load old games:

freeciv-server -f Dunedain2521m.sav.gz

This is the server for Freeciv version 2.2.2
You can learn a lot about Freeciv at http://www.freeciv.org/ [^]
2: Loading rulesets
1: Value read for key player0.c0.did_sell isn't boolean: 9306124
0: player0.c0.currently_building: version mismatch.




___

File Attachments:


---
Date: Mi 26 Jan 2011 20:37:04 UTC  Name: Dunedain2521m.sav.gz  Size: 834kB  
By: None
One of the save files which do not work.
http://gna.org/bugs/download.php?file_id=12113

___

Reply to this item at:

  http://gna.org/bugs/?17583

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2359] [citizens05] accessor function for city-size

2011-01-26 Thread Matthias Pfafferodt

Update of patch #2359 (project freeciv):

  Status:Done = Ready For Test 
 Open/Closed:  Closed = Open   

___

Follow-up Comment #2:

I compiles quit nice but a check showed that one direct access to the city
size is still in the code ... (cityturn.c)

(file #12114)
___

Additional Item Attachment:

File name: 20110126-add-missing-access-to-pcity-size-in-cityturn.c.patch
Size:1 KB


___

Reply to this item at:

  http://gna.org/patch/?2359

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17583] games-strategy/freeciv-2.2.2 aborts after loading certain old saved games

2011-01-26 Thread Matthias Pfafferodt

Follow-up Comment #1, bug #17583 (project freeciv):

This is quite an old savegame (1.12). I do not know if this version is still
supported. The answer seems to be NO.

You could try to load it by freeciv 1.14(?) save it again and then go up to
2.0 = 2.1 = 2.2 = 2.3?

___

Reply to this item at:

  http://gna.org/bugs/?17583

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17583] games-strategy/freeciv-2.2.2 aborts after loading certain old saved games

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #2, bug #17583 (project freeciv):

 This is quite an old savegame (1.12). I do not know if this
 version is still supported. The answer seems to be NO.

We have never officially dropped support for even oldest of the savegames.
As savegame loading code become more and more complicated as over decade
worth of different savegame formats were supposed to be supported, I proposed
at one point policy that we support situation where user skips one feature
release, but not that user skips two feature releases. Had that proposal been
accepted (instead of effectively ignored), 2.3 would support loading savegames
from 2.2 and 2.1, but not from 2.0 or older.

 You could try to load it by freeciv 1.14(?) save it again and
 then go up to 2.0 = 2.1 = 2.2 = 2.3?

In any case going through every step should not be necessary. But it's hard
to know which steps are the correct ones.

___

Reply to this item at:

  http://gna.org/bugs/?17583

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2417] Stub of threaded ai module

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2417

 Summary: Stub of threaded ai module
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Jan 2011 01:21:28 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This patch adds threaded ai module stub.

Developing this ai will require, not only developing ai module itself, but
also building support for ai module that uses threads to server common code.
So, to keep challenge manageable (= it can be finished some day even with
limited time I have for Freeciv hacking), thread usage will be main difference
between current ai and new module. I don't plan to design completely new AI,
but instead I'll use default ai as reference and try to reuse as much as
possible from it. Effective thread usage alone requires differences big enough
that I consider it easier to write completely new module, and not to try to
modify existing ai to use threads.

I'm currently targeting generally usable version of threaded ai to freeciv
2.5. But groundwork for it starts already with this patch. I expect there to
be sort of technology demo version of it in freeciv 2.4.



___

File Attachments:


---
Date: Thu 27 Jan 2011 01:21:28 AM EET  Name: ThreadedAi.diff  Size: 3kB   By:
cazfi

http://gna.org/patch/download.php?file_id=12117

___

Reply to this item at:

  http://gna.org/patch/?2417

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2417] Stub of threaded ai module

2011-01-26 Thread Marko Lindqvist

Update of patch #2417 (project freeciv):

  Depends on: = patch #2399


___

Reply to this item at:

  http://gna.org/patch/?2417

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17564] Negative endturn

2011-01-26 Thread Marko Lindqvist

Update of bug #17564 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17564

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15090] Replace BC and AD by CE and BCE

2011-01-26 Thread Marko Lindqvist

Update of bug #15090 (project freeciv):

  Status:  Ready For Test = None   


___

Reply to this item at:

  http://gna.org/bugs/?15090

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2286] AI module directory structure

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #4, patch #2286 (project freeciv):

Even when code has been refactored so that there is clean module interface
between server common code and default ai, default ai is not modular
internally. It's not trivial to take some part of it as common ai code that
does not depend (call functions) on remaining parts.
So, I'm even more convinced than before that next step as soon as remaining
direct calls from server common code are weeded out, is to move all current
default ai code to ai/default directory and to default ai module. Once we
reach that point, we can consider this ticket finished.

I'm not against later refactoring of the code so that some parts of the code
are again moved from default ai module to common ai code. I'm just saying that
it requires refactoring = work = time, and meanwhile we can have default ai as
real module only by moving all the code to that module.

___

Reply to this item at:

  http://gna.org/patch/?2286

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2418

 Summary: Add impr_want and impr_keep_want to AI interface
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Jan 2011 03:18:04 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This patch replaces direct want_tech_for_improvement_effect() calls from
server common code with calls to new impr_want and impr_keep_want
functions in AI interface.



___

File Attachments:


---
Date: Thu 27 Jan 2011 03:18:04 AM EET  Name: AIIImprWant.diff  Size: 10kB  
By: cazfi

http://gna.org/patch/download.php?file_id=12118

___

Reply to this item at:

  http://gna.org/patch/?2418

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-01-26 Thread Marko Lindqvist

Update of patch #2418 (project freeciv):

  Depends on: = patch #2399


___

Reply to this item at:

  http://gna.org/patch/?2418

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2419] Move city building_want from default ai data to advisor data

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2419

 Summary: Move city building_want from default ai data to
advisor data
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Jan 2011 03:41:24 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

As building_want is used by building advisor, it belongs to common advisors,
not only to default ai. Attached patch moves it from city-ai[x] to
city-adv.

This reduces number of direct calls to default ai code from server common
code.



___

File Attachments:


---
Date: Thu 27 Jan 2011 03:41:24 AM EET  Name: AdvBuildingWant.diff  Size: 10kB
  By: cazfi

http://gna.org/patch/download.php?file_id=12119

___

Reply to this item at:

  http://gna.org/patch/?2419

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2419] Move city building_want from default ai data to advisor data

2011-01-26 Thread Marko Lindqvist

Update of patch #2419 (project freeciv):

  Depends on: = patch #2418


___

Reply to this item at:

  http://gna.org/patch/?2419

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2420] Define dummy fc_thread and fc_mutex as char instead of void

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2420

 Summary: Define dummy fc_thread and fc_mutex as char instead
of void
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Jan 2011 03:52:11 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

fc_thread and fc_mutex can be used in context where 'void' cannot be used.
So, even when no real thread implementation is used, they should be defined as
something else than 'void'. Attached patch makes them 'char'.



___

File Attachments:


---
Date: Thu 27 Jan 2011 03:52:11 AM EET  Name: CharDummyMutex.diff  Size: 472B 
 By: cazfi

http://gna.org/patch/download.php?file_id=12120

___

Reply to this item at:

  http://gna.org/patch/?2420

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2421] Explicitly create pthreads joinable

2011-01-26 Thread Marko Lindqvist

URL:
  http://gna.org/patch/?2421

 Summary: Explicitly create pthreads joinable
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Jan 2011 04:39:07 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

If pthreads are used as thread implementation, explicitly set them as
joinable. Some pthread implementations do not do it by default.



___

File Attachments:


---
Date: Thu 27 Jan 2011 04:39:07 AM EET  Name: PthreadCreateJoinable.diff 
Size: 1011B   By: cazfi

http://gna.org/patch/download.php?file_id=12121

___

Reply to this item at:

  http://gna.org/patch/?2421

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2421] Explicitly create pthreads joinable

2011-01-26 Thread Marko Lindqvist

Update of patch #2421 (project freeciv):

  Depends on: = patch #2298


___

Reply to this item at:

  http://gna.org/patch/?2421

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2416] Threads safe logging

2011-01-26 Thread Marko Lindqvist

Update of patch #2416 (project freeciv):

  Depends on: = patch #2420


___

Reply to this item at:

  http://gna.org/patch/?2416

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2378] Server - metaserver post with curl

2011-01-26 Thread Marko Lindqvist

Follow-up Comment #4, patch #2378 (project freeciv):

- Consider it an error if http-server responds with code other than 200.
Previously getting (any) response from http-server was considered success.


Same bug was in old code already, but it was trivial to fix now that we use
libcurl.

(file #12122)
___

Additional Item Attachment:

File name: CurlMeta_2378-5.diff   Size:13 KB


___

Reply to this item at:

  http://gna.org/patch/?2378

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev