[Freeciv-Dev] [bug #19304] Double Vision with a small map

2012-01-19 Thread Jacob Nevins

Follow-up Comment #1, bug #19304 (project freeciv):

Clearly the minimap indication box is wrong here. But... what *should* happen
to the main view when it's bigger than the actual map?

About the only alternative I can think of is that the main view canvas width
should be restricted to match the map dimensions, so that there are permanent
black bars down the sides.

(If/when we get zoom -- bug #17760 -- then limiting the zoom size will be
another option which will make better use of the screen.)

___

Reply to this item at:

  http://gna.org/bugs/?19304

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19307] Some More Warnings from Clang

2012-01-19 Thread David Lowe

URL:
  http://gna.org/bugs/?19307

 Summary: Some More Warnings from Clang
 Project: Freeciv
Submitted by: doctorjlowe
Submitted on: Thu 19 Jan 2012 08:00:47 AM PST
Category: bootstrap
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.1
 Discussion Lock: Any
Operating System: Mac OS
 Planned Release: 

___

Details:

Herein are the results from building 2.3.1 with clang.  Again, i don't yet
have access to clang myself, so this is from one of the users of my package. 
This particular build was done with --enable-debug; the build completed
successfully when debug was disabled.
***

Making all in ftwl
make[4]: Nothing to be done for `all'.
  CC astring.lo
/bin/sh ../libtool --preserve-dup-deps --silent --tag=CC   --mode=compile gcc
-DHAVE_CONFIG_H -I. -I..   -I/sw/include -DLOCALEDIR=\/sw/share/locale\
-DBINDIR=\/sw/bin\
-DDEFAULT_DATA_PATH=\.:data:~/.freeciv/2.3:/sw/share/freeciv\
-DDEFAULT_SAVES_PATH=\\
-DDEFAULT_SCENARIO_PATH=\.:data/scenario:~/.freeciv/2.3/scenarios:~/.freeciv/scenarios:/sw/share/freeciv/scenario\
 -Wall -Wpointer-arith -Wcast-align -Wmissing-prototypes
-Wmissing-declarations -Wno-unused-but-set-variable -Werror -g -O2
-fsigned-char -c -o astring.lo astring.c
warning: unknown warning option '-Wno-unused-but-set-variable'
[-Wunknown-warning-option]
1 warning generated.

***
This warning happens 18 times in total; for the rest i will only note the
offending object files: bitvector.lo, capability.lo, distribute.lo,
fc_utf8.lo, fciconv.lo, fcintl.lo, genhash.lo, genlist.lo, inputfile.lo,
ioz.lo, iterator.lo, log.lo, netintf.lo, pqueue.lo, mem.lo, rand.lo,
registry.lo.
***

registry.c:1713:3: error: incompatible pointer to integer conversion
returning 'void *' from a function with result type 'fc_bool' (aka 'unsigned
int') [-Werror]
 SECFILE_RETURN_VAL_IF_FAIL(secfile, NULL, NULL != secfile, NULL);
 ^~~~
registry.c:1713:62: note: instantiated from:
 SECFILE_RETURN_VAL_IF_FAIL(secfile, NULL, NULL != secfile, NULL);
^~~~
In file included from registry.c:153:
/usr/include/stdlib.h:115:14: note: instantiated from:
#define NULL __DARWIN_NULL
^
In file included from registry.c:153:
In file included from /usr/include/stdlib.h:63:
In file included from /usr/include/_types.h:27:
/usr/include/sys/_types.h:91:23: note: instantiated from:
#define __DARWIN_NULL ((void *)0)
 ^~~

***
This error happens 12 times in total.  Since the others are identical except
for the source line, i will only note the offending lines: registry.c:2116,
registry.c:2117, registry.c:2118, registry.c:2119, registry.c:2258,
registry.c:2259, registry.c:2260, registry.c:2261, registry.c:2440,
registry.c:2441, registry.c:2442.



___

File Attachments:


---
Date: Thu 19 Jan 2012 08:00:47 AM PST  Name:
fink-build-log_freeciv_2.3.1-12_2012.01.14-07.27.42  Size: 222kB   By:
doctorjlowe
warnings start at line 4796
http://gna.org/bugs/download.php?file_id=14826

___

Reply to this item at:

  http://gna.org/bugs/?19307

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)

2012-01-19 Thread Matthias Pfafferodt

Follow-up Comment #5, bug #19296 (project freeciv):

 pkg-config --libs MagickWand
 -lMagickWand -lMagickCore
 and at least as of ImageMagick 6.7.4.0
 MagickWand-config --libs 
 MagickWand-config --libs
 the output is the same. 
Correct - but it wasn't on opensuse. If you got to the bug I opened you will
find that it will be fixed in the next version. I think, doing the compiling
check is a save way to go.

 On the other hand, it might just be another (odd) freciv policy 
 - you still use the whole AM_PATH_GTK_2_0 macro; most packages 
 simply rely on pkg-config here, instead of that compile check. 
No, I do not think is is a policy to use use old macros. But often the old
ones are not changed till they do not work anymore. In the case you mentioned,
the information of the macro is also available via a pkg-config call? Do you
know other things which should be checked?

___

Reply to this item at:

  http://gna.org/bugs/?19296

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev