[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)

2012-10-20 Thread Jacob Nevins
Follow-up Comment #11, bug #19977 (project freeciv):

Looks like a typo in the S2_3 patch: in fc_version there's a single capability
'rules_finishedtrademindist_size' (broken over 80 columns).

___

Reply to this item at:

  http://gna.org/bugs/?19977

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] cannot compile S2.3 on gentoo amd64

2012-10-20 Thread Michal Mazurek
I'm trying to compile S2.3 on gentoo/amd64, but autogen.sh fails:

[22:04:pts/4][dude@bender:~/src/freeciv:14]$ svn info
Path: .
URL: svn://svn.gna.org/svn/freeciv/branches/S2_3
Repository Root: svn://svn.gna.org/svn/freeciv
Repository UUID: a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Revision: 21966
Node Kind: directory
Schedule: normal
Last Changed Author: cazfi
Last Changed Rev: 21957
Last Changed Date: 2012-10-17 03:23:32 +0200 (Wed, 17 Oct 2012)

[22:04:pts/4][dude@bender:~/src/freeciv:15]$ svn up
At revision 21966.
[22:04:pts/4][dude@bender:~/src/freeciv:16]$ ./autogen.sh 
--prefix=/home/dude/local/
+ checking for autoconf = 2.59 ... found 2.68, ok.
+ checking for autoheader = 2.59 ... found 2.68, ok.
+ checking for automake = 1.7 ... found 1.11.6, ok.
+ checking for aclocal = 1.7 ... found 1.11.6, ok.
+ checking for libtoolize = 1.4.3 ... found 2.4, ok.
+ checking for xgettext = 0.10.36 ... found 0.18.1, ok.
+ checking for msgfmt = 0.10.36 ... found 0.18.1, ok.
+ running /usr/bin/aclocal-1.11 ...
+ running autoheader ... 
+ running autoconf ... 
+ running libtoolize ... 
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `bootstrap'.
libtoolize: linking file `bootstrap/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: linking file `m4/libtool.m4'
libtoolize: linking file `m4/ltoptions.m4'
libtoolize: linking file `m4/ltsugar.m4'
libtoolize: linking file `m4/ltversion.m4'
libtoolize: linking file `m4/lt~obsolete.m4'
+ running /usr/bin/automake-1.11 ... 
common/Makefile.am:103: `%'-style pattern rules are a GNU make extension
utility/Makefile.am:65: `%'-style pattern rules are a GNU make extension
+ removing config.cache ... 
+ running configure ... 

using:  --prefix=/home/dude/local/

checking build system type... Invalid configuration `x86_64-unknown-linux-': 
machine `x86_64-unknown-linux' not recognized
configure: error: /bin/sh bootstrap/config.sub x86_64-unknown-linux- failed

configure failed
[22:05:pts/4][dude@bender:~/src/freeciv:17]$ uname -a
Linux bender 3.3.8-gentoo #8 SMP Tue Aug 7 17:26:48 CEST 2012 x86_64 AMD 
FX(tm)-8150 Eight-Core Processor AuthenticAMD GNU/Linux
[22:05:pts/4][dude@bender:~/src/freeciv:18]$ tail config.log

/* confdefs.h */
#define PACKAGE_NAME freeciv
#define PACKAGE_TARNAME freeciv
#define PACKAGE_VERSION 2.3.2+
#define PACKAGE_STRING freeciv 2.3.2+
#define PACKAGE_BUGREPORT 
#define PACKAGE_URL 

configure: exit 1
[22:05:pts/4][dude@bender:~/src/freeciv:19]$ 


-- 
Michal Mazurek

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] cannot compile S2.3 on gentoo amd64

2012-10-20 Thread Marko Lindqvist
On 20 October 2012 15:10, Michal Mazurek akf...@jasminek.net wrote:
 I'm trying to compile S2.3 on gentoo/amd64, but autogen.sh fails:

 [22:05:pts/4][dude@bender:~/src/freeciv:18]$ tail config.log

 Can you send full config.log? The actual error is way up from the
config.h stuff listed in the end, and shown by tail.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] cannot compile S2.3 on gentoo amd64

2012-10-20 Thread Michal Mazurek
On Sat, Oct 20, 2012 at 03:46:43PM +0300, Marko Lindqvist wrote:
 On 20 October 2012 15:10, Michal Mazurek akf...@jasminek.net wrote:
  I'm trying to compile S2.3 on gentoo/amd64, but autogen.sh fails:
 
  [22:05:pts/4][dude@bender:~/src/freeciv:18]$ tail config.log
 
  Can you send full config.log? The actual error is way up from the
 config.h stuff listed in the end, and shown by tail.

config.log:

This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.

It was created by freeciv configure 2.3.2+, which was
generated by GNU Autoconf 2.68.  Invocation command line was

  $ ./configure --prefix=/home/dude/local/

## - ##
## Platform. ##
## - ##

hostname = bender
uname -m = x86_64
uname -r = 3.3.8-gentoo
uname -s = Linux
uname -v = #8 SMP Tue Aug 7 17:26:48 CEST 2012

/usr/bin/uname -p = AMD FX(tm)-8150 Eight-Core Processor
/bin/uname -X = unknown

/bin/arch  = unknown
/usr/bin/arch -k   = unknown
/usr/convex/getsysinfo = unknown
/usr/bin/hostinfo  = unknown
/bin/machine   = unknown
/usr/bin/oslevel   = unknown
/bin/universe  = unknown

PATH: /bin
PATH: /sbin
PATH: /usr/bin
PATH: /usr/sbin
PATH: /usr/local/bin
PATH: /usr/local/sbin
PATH: /home/dude/local/bin
PATH: /home/dude/bin
PATH: /usr/games/bin


## --- ##
## Core tests. ##
## --- ##

configure:2610: checking build system type
configure:2621: error: /bin/sh bootstrap/config.sub x86_64-unknown-linux- failed

##  ##
## Cache variables. ##
##  ##

ac_cv_build=
ac_cv_env_CAIRO_CFLAGS_set=
ac_cv_env_CAIRO_CFLAGS_value=
ac_cv_env_CAIRO_LIBS_set=
ac_cv_env_CAIRO_LIBS_value=
ac_cv_env_CC_set=
ac_cv_env_CC_value=
ac_cv_env_CFLAGS_set=
ac_cv_env_CFLAGS_value=
ac_cv_env_CPPFLAGS_set=
ac_cv_env_CPPFLAGS_value=
ac_cv_env_CPP_set=
ac_cv_env_CPP_value=
ac_cv_env_GTHREAD_CFLAGS_set=
ac_cv_env_GTHREAD_CFLAGS_value=
ac_cv_env_GTHREAD_LIBS_set=
ac_cv_env_GTHREAD_LIBS_value=
ac_cv_env_LDFLAGS_set=
ac_cv_env_LDFLAGS_value=
ac_cv_env_LIBS_set=
ac_cv_env_LIBS_value=
ac_cv_env_PKG_CONFIG_set=
ac_cv_env_PKG_CONFIG_value=
ac_cv_env_PNG_CFLAGS_set=
ac_cv_env_PNG_CFLAGS_value=
ac_cv_env_PNG_LIBS_set=
ac_cv_env_PNG_LIBS_value=
ac_cv_env_XMKMF_set=
ac_cv_env_XMKMF_value=
ac_cv_env_build_alias_set=
ac_cv_env_build_alias_value=
ac_cv_env_host_alias_set=
ac_cv_env_host_alias_value=
ac_cv_env_target_alias_set=
ac_cv_env_target_alias_value=

## - ##
## Output variables. ##
## - ##

ACLOCAL=''
AMDEPBACKSLASH=''
AMDEP_FALSE=''
AMDEP_TRUE=''
AMTAR=''
AM_BACKSLASH=''
AM_DEFAULT_V=''
AM_DEFAULT_VERBOSITY=''
AM_V=''
AR=''
AUDIO_SDL_FALSE=''
AUDIO_SDL_TRUE=''
AUTH_CFLAGS=''
AUTH_LIBS=''
AUTOCONF=''
AUTOHEADER=''
AUTOMAKE=''
AUTO_DEPS=''
AWK=''
BUG_URL=''
CAIRO_CFLAGS=''
CAIRO_LIBS=''
CATALOGS=''
CATOBJEXT=''
CC=''
CCDEPMODE=''
CFLAGS=''
CLIENT_FALSE=''
CLIENT_GUI_BEOS_FALSE=''
CLIENT_GUI_BEOS_TRUE=''
CLIENT_GUI_FTWL_FALSE=''
CLIENT_GUI_FTWL_TRUE=''
CLIENT_GUI_GTK_2_0_FALSE=''
CLIENT_GUI_GTK_2_0_TRUE=''
CLIENT_GUI_SDL_FALSE=''
CLIENT_GUI_SDL_TRUE=''
CLIENT_GUI_STUB_FALSE=''
CLIENT_GUI_STUB_TRUE=''
CLIENT_GUI_WIN32_FALSE=''
CLIENT_GUI_WIN32_TRUE=''
CLIENT_GUI_XAW_FALSE=''
CLIENT_GUI_XAW_TRUE=''
CLIENT_LIBS=''
CLIENT_TRUE=''
COMMON_LIBS=''
CONFIGURE_DEPENDENCIES=''
CPP=''
CPPFLAGS=''
CYGPATH_W=''
DATADIRNAME=''
DATASUBDIR=''
DEFS=''
DEPDIR=''
DLLTOOL=''
DSYMUTIL=''
DUMPBIN=''
ECHO_C=''
ECHO_N='-n'
ECHO_T=''
EGREP=''
EXEEXT=''
FGREP=''
FT2_CFLAGS=''
FT2_CONFIG=''
FT2_LIBS=''
FTWL_CFLAGS=''
FTWL_FALSE=''
FTWL_OPENGL_FALSE=''
FTWL_OPENGL_TRUE=''
FTWL_SDL_FALSE=''
FTWL_SDL_TRUE=''
FTWL_TRUE=''
FTWL_X11_FALSE=''
FTWL_X11_TRUE=''
GGZDMOD_INCLUDES=''
GGZDMOD_LDFLAGS=''
GGZMOD_INCLUDES=''
GGZMOD_LDFLAGS=''
GGZ_CLIENT_FALSE=''
GGZ_CLIENT_TRUE=''
GGZ_CONFIG=''
GGZ_GTK_FALSE=''
GGZ_GTK_INCLUDES=''
GGZ_GTK_LDFLAGS=''
GGZ_GTK_TRUE=''
GGZ_SERVER_FALSE=''
GGZ_SERVER_TRUE=''
GMOFILES=''
GMSGFMT=''
GNULIB_CALLOC_POSIX=''
GNULIB_GETSUBOPT=''
GNULIB_MALLOC_POSIX=''
GNULIB_MKDTEMP=''
GNULIB_MKSTEMP=''
GNULIB_PUTENV=''
GNULIB_REALLOC_POSIX=''
GNULIB_RPMATCH=''
GNULIB_SETENV=''
GNULIB_STRTOD=''
GNULIB_UNSETENV=''
GREP=''
GTHREAD_CFLAGS=''
GTHREAD_LIBS=''
GTK_CFLAGS=''
GTK_LIBS=''
GUI_beos_CFLAGS=''
GUI_beos_LDFLAGS=''
GUI_beos_LIBS=''
GUI_ftwl_CFLAGS=''
GUI_ftwl_LDFLAGS=''
GUI_ftwl_LIBS=''
GUI_gtk2_CFLAGS=''
GUI_gtk2_LDFLAGS=''
GUI_gtk2_LIBS=''
GUI_sdl_CFLAGS=''
GUI_sdl_LDFLAGS=''
GUI_sdl_LIBS=''
GUI_stub_CFLAGS=''
GUI_stub_LDFLAGS=''
GUI_stub_LIBS=''
GUI_win32_CFLAGS=''
GUI_win32_LDFLAGS=''
GUI_win32_LIBS=''
GUI_xaw_CFLAGS=''
GUI_xaw_LDFLAGS=''
GUI_xaw_LIBS=''
GZIP=''
HAVE_CALLOC_POSIX=''
HAVE_GETSUBOPT=''
HAVE_MALLOC_POSIX=''
HAVE_MKDTEMP=''
HAVE_REALLOC_POSIX=''
HAVE_RPMATCH=''
HAVE_SETENV=''
HAVE_STRTOD=''
HAVE_UNSETENV=''
HOST_PATH_SEPARATOR=''
INSTALL_DATA=''
INSTALL_PROGRAM=''
INSTALL_SCRIPT=''
INSTALL_STRIP_PROGRAM=''
INSTOBJEXT=''
INTLLIBS=''
LD=''
LDFLAGS=''
LIBGGZ_INCLUDES=''
LIBGGZ_LDFLAGS=''

Re: [Freeciv-Dev] cannot compile S2.3 on gentoo amd64

2012-10-20 Thread Marko Lindqvist
On 20 October 2012 16:16, Michal Mazurek akf...@jasminek.net wrote:

 configure:2610: checking build system type
 configure:2621: error: /bin/sh bootstrap/config.sub x86_64-unknown-linux- 
 failed

 I guess that should be x86_64-unknown-linux-gnu? Now where does
that broken triplet come from... is it possibly something you have
given yourse lf somewhere? What does running bootstrap/config.guess
give?


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1921] Komi nation

2012-10-20 Thread J.M. Maalderink
Update of patch #1921 (project freeciv):

  Status:   Need Info = Ready For Test 

___

Follow-up Comment #3:

Some edits

(file #16706, file #16707)
___

Additional Item Attachment:

File name: komi.ruleset   Size:1 KB
File name: komi.svg   Size:0 KB


___

Reply to this item at:

  http://gna.org/patch/?1921

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20254] Code assumes that there's old traderoute(s) when all slots in use

2012-10-20 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20254

 Summary: Code assumes that there's old traderoute(s) when all
slots in use
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 21 Oct 2012 01:57:54 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

Even after we fixed one part in AI caravan handling code, some places still
think that there must be traderoutes (of which one is producing least trade)
when city has max routes, ignoring the max routes = 0 case.

Fix attached.



___

File Attachments:


---
Date: Sun 21 Oct 2012 01:57:54 AM EEST  Name: Routes0.patch  Size: 3kB   By:
cazfi

http://gna.org/bugs/download.php?file_id=16708

___

Reply to this item at:

  http://gna.org/bugs/?20254

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-10-20 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3550

 Summary: Merge update_rect_at_mouse_pos into move_mapcanvas
(patch 11/60)
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 21 Oct 2012 02:08:41 AM EEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

This ticket is about handling patch 11/60 (merge update_rect_at_mouse_pos into
move_mapcanvas) from Rafał Mużyło's patchset in patch #3469

The patch inlines contents of update_rect_at_mouse_pos() to move_mapcanvas()
leaving former function empty. This results in simpler implementation.

I have not investigated issue very deeply, but update_rect_at_mouse_pos() is
part of gui API towards client common code, and it is in fact called from
there too. Leaving that function empty, i.e., it not doing what API promises,
seems wrong. Or can wew be sure that in case of gtk3 its (API defined)
implementation would be always redundant?




___

Reply to this item at:

  http://gna.org/patch/?3550

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3469] Get rid of most deprecated warning

2012-10-20 Thread Marko Lindqvist
Follow-up Comment #36, patch #3469 (project freeciv):

I've raised 11/60 as patch #3550 for discussion as from quick glance it seems
unacceptable to me.

___

Reply to this item at:

  http://gna.org/patch/?3469

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

2012-10-20 Thread RafałMużyło
Follow-up Comment #1, patch #3550 (project freeciv):

Well, TBH, there's one major catch here: while things work as-is both in gtk2
and gtk3 clients, technically they only do that due to luck.

Even back in gtk2 its devs stressed that *all* of the drawing should be done
in 'expose-event' handler. It's still the same for gtk3 and 'draw'. The way
update_rect_at_mouse_pos() works (well, more exactly
update_selection_rectangle(x, y)), regardless of whether it's merged or not,
already pushes it.

But I don't see any way of implementing this without a major rewrite of not
only the client, but probably common code too.

I've merged it, cause while due to human reaction time, doing it like
city_activated_callback (cityrep.c) and impr_callback (citydlg.c) do (which I
didn't touched and already explained why it's IMHO unfixably broken) would
*seem* to work, it's the most natural place with access to the required data,
but at the same time, that data can't be as reliably retrieved anywhere else.

___

Reply to this item at:

  http://gna.org/patch/?3550

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev