[Freeciv-Dev] [bug #20304] Some requirement types always required even with RPT_POSSIBLE

2012-11-18 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20304

 Summary: Some requirement types always required even with
RPT_POSSIBLE
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 18 Nov 2012 01:04:14 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Noticed with TerrainClass requirement, but from the source code it seems also
many other requirement types lack related handling.

When are_reqs_active is passed NULL tile (tile is not known) and RPT_POSSIBLE
(asking if it's *possible* that requirements are active), TerrainClass
requirements are considered not active.




___

Reply to this item at:

  http://gna.org/bugs/?20304

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20072] Any unit can_unit_do_connect() when start tile has road already

2012-11-18 Thread Marko Lindqvist
Update of bug #20072 (project freeciv):

Category:None = client 
  Status:None = Ready For Test 
 Planned Release: = 2.5.0  

___

Follow-up Comment #1:

Fix attempt. While testing this, I found bug #20304. Until that one is fixed,
this one should wait - committing this alone would make things only worse.

(file #16780)
___

Additional Item Attachment:

File name: RoadConnectFix.patch   Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?20072

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19975] dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]

2012-11-18 Thread Matthias Pfafferodt
Follow-up Comment #2, bug #19975 (project freeciv):

Is this to be solved for 2.4.x? Or can this version only be compiled without
extra checks?

___

Reply to this item at:

  http://gna.org/bugs/?19975

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20269] Unit with move rate 0 cannot be unloaded

2012-11-18 Thread David Lowe
Follow-up Comment #3, bug #20269 (project freeciv):

 Would it be better or worse for the usability if Shift + T behavior
depended
 on whether cargo can exist in current tile or not - all units would get
 activated, but those that can exist in transporter tile would also get
 automatically unloaded to that tile.

This is ideal: fully unload all units that can exist in the target hex.  Those
that can't, stay in the transport.  It is also exactly what i'm seeing now
[2.4.0b1]

One case worth considering is when there is a second transport in the same
hex.  Is it unrealistic/impractical to move, say, Freight from one ship to
another in the middle of the ocean?  Hmm, i seem to recall there was another
tracker item about this topic but i can't find it just now.

 Or should this work (as I suppose it currently somehow does) that you first
use 
 Shift + T to activate cargo, and then U)nload them, or unload them using

 citydlg present units area.

That's certainly not the way it works for me now, and i don't remember it ever
having been that way.  After Shift + T the units are out [or at least awake]
and ready to go to work when it is their turn to be activated.  'Manually'
unloading them can be done without Shift + T - this is what i do when i wish
unload different units in different cities.


___

Reply to this item at:

  http://gna.org/bugs/?20269

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20237] Possible to pillage roads under railroads

2012-11-18 Thread Marko Lindqvist
Follow-up Comment #2, bug #20237 (project freeciv):

- Free created virtual tile

(file #16781)
___

Additional Item Attachment:

File name: RoadPillageDep-2.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?20237

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3564] Use grids in helpdlg (patch 28/60)

2012-11-18 Thread Marko Lindqvist
Update of patch #3564 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3564

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20305] Closing helpbrowser gives gtk assert

2012-11-18 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20305

 Summary: Closing helpbrowser gives gtk assert
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 19 Nov 2012 05:32:30 AM EET
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

When ever closing help browser:
(freeciv-gtk3:19092): Gtk-CRITICAL **: gtk_tree_model_get_iter: assertion
`GTK_IS_TREE_MODEL (tree_model)' failed





___

Reply to this item at:

  http://gna.org/bugs/?20305

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20304] Some requirement types always required even with RPT_POSSIBLE

2012-11-18 Thread Marko Lindqvist
Update of bug #20304 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.3.3, 2.4.0, 2.5.0

___

Follow-up Comment #1:

Patches

(file #16782, file #16783, file #16784)
___

Additional Item Attachment:

File name: RPTPossible.patch  Size:8 KB
File name: RPTPossible-S2_4.patch Size:7 KB
File name: RPTPossible-S2_3.patch Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?20304

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev