[Freeciv-Dev] [patch #3840] tile_roads() to return tile roads vector

2013-04-11 Thread Marko Lindqvist
Update of patch #3840 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3840

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20728] Pointer to barbarian leader who has died while moving used afterwards

2013-04-11 Thread Marko Lindqvist
Update of bug #20728 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20728

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3833] Consider base dependencies for bases

2013-04-11 Thread Marko Lindqvist
Follow-up Comment #3, patch #3833 (project freeciv):

- Set dep_tgt.obj.base instead dep_tgt.obj.road in autosettler code
- Add empty line between dep_tgt declaration and first line of actual code

(file #17738)
___

Additional Item Attachment:

File name: BaseBaseDep.patch  Size:4 KB


___

Reply to this item at:

  http://gna.org/patch/?3833

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3826] Allow bases on city tiles

2013-04-11 Thread Marko Lindqvist
Follow-up Comment #3, patch #3826 (project freeciv):

- git commit message claims that pcity is needed for requirements preventing
building base/road in cities, but CityTile, Center, Local requirement is
used for that.
It's probably a good idea to pass that city information to requirement
parsing, but it's out of scope for this patch.
- FIXME comment about removal of roads/bases from city tiles should be
removed, or changed to point out that in that sense city tiles act like any
other tile - extras are removed in tile_change_terrain()

___

Reply to this item at:

  http://gna.org/patch/?3826

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3830] Change shore bombardment model to use nativity rather than UMT_*

2013-04-11 Thread Marko Lindqvist
Follow-up Comment #1, patch #3830 (project freeciv):

Reading the patch it seems to me that it does change behavior when sea unit
attacks against another sea unit in harbour.

Old code would check if defender is land unit (native to tile it defends) and
as sea unit in harbour is not that, it wouldn't adjust either of att_fp or
def_fp.

New code will adjust att_fp regardless of defender properties. And actually it
also adjusts def_fp regardless of attacker properties - attacker might be air
unit for which both tiles are native.

___

Reply to this item at:

  http://gna.org/patch/?3830

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

2013-04-11 Thread Marko Lindqvist
Follow-up Comment #7, bug #20706 (project freeciv):

btw Noticed that freeciv-web has interface where entire tax rates dialog is
constructed so that max value for the ruler is current maxrate value.

___

Reply to this item at:

  http://gna.org/bugs/?20706

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20507] Barbarian nations in unknown group in civ2 ruleset

2013-04-11 Thread Jacob Nevins
Update of bug #20507 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20507

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3845] Minor updates to README.ruleset_civ2civ3

2013-04-11 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3845

 Summary: Minor updates to README.ruleset_civ2civ3
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 12 Apr 2013 02:38:52 AM EEST
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

- National traderoutes now simply disabled as new ruleset format allows
- MAYOR - MAJOR


While reading the doc, I noticed that several wonders are supposed to give lux
or sci from city central tile. I suspect that not to work - there's no output
of those types from tiles. Those output types are generated only when all gold
from all tiles is split to tax/sci/lux.




___

File Attachments:


---
Date: Fri 12 Apr 2013 02:38:52 AM EEST  Name: civ2civ3RMUp.patch  Size: 1kB  
By: cazfi

http://gna.org/patch/download.php?file_id=17739

___

Reply to this item at:

  http://gna.org/patch/?3845

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev