[Freeciv-Dev] [patch #4373] Silence some compiler warnings and fix some severe bugs along the way
Follow-up Comment #4, patch #4373 (project freeciv): I have updated the patches for trunk and S2_5, since the cast that allowed to hide the memory corruption in client/tilespec.c is no longer needed. I have also submitted patches for S2_4 and S2_3. (I finally got them to compile.) They silence a few more warnings, but none of them are actual bugs. So, for S2_5, S2_4, and S2_3, the only detected bug is the one in client/tilespec.c. For trunk, there are some more. As for the compiler, it is clang. It produces about 200 warnings when compiling Freeciv. (I feel sorry for people compiling it under MacOSX.) Most of them are pointless, if not outright wrong. But sometimes it does spot actual bugs. (file #19581, file #19582, file #19583, file #19584) ___ Additional Item Attachment: File name: warning.patch Size:4 KB File name: warning_S2_4.patch Size:2 KB File name: warning_S2_5.patch Size:2 KB File name: warning_S2_3.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?4373 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21293] Tab completion on empty line references invalid memory
Update of bug #21293 (project freeciv): Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21293 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21393] update_player_tile_knowledge() doesn't handle foggedborders correctly
Update of bug #21393 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21393 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21395] Chatline completion can cause client segfault in the presence of unused player slots
Update of bug #21395 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21395 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21384] Client segfault in fill_grid_sprite_array on server shutdown or player /remove
Update of bug #21384 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21384 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21392] Editor vision tool should always refresh player's knowledge
Update of bug #21392 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21392 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4365] Propose a ceasefire on first contact only in case of war
Update of patch #4365 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4365 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21399] luac.c main() built to lua library
Follow-up Comment #2, bug #21399 (project freeciv): Thank you for looking into this issue. I applied the LuacRm-S2_4.patch to the sources fetched using MacPorts (so got rid of the luac.c entries in the lua-5.1/src Makefiles) and rebuilt, but unfortunately still the same behavior when running freeciv-sdl. grep -r 'no input files given' * dependencies/lua-5.1/src/.libs/liblua.a dependencies/lua-5.1/src/luac.o dependencies/lua-5.1/src/luac.c client/freeciv-sdl grep -r luac.c ChangeLog: M /branches/S2_2/dependencies/lua-5.1/src/luac.c ChangeLog: A /trunk/dependencies/lua-5.1/src/luac.c ChangeLog: D /trunk/dependencies/lua/src/luac.c ChangeLog: M /trunk/dependencies/lua/src/luac.c ChangeLog: A /trunk/dependencies/lua/src/luac.c dependencies/lua-5.1/src/.deps/luac.Plo:luac.lo luac.o: luac.c /usr/include/errno.h /usr/include/sys/errno.h dependencies/lua-5.1/src/luac.c:** $Id: luac.c,v 1.54 2006/06/02 17:37:11 lhf Exp $ dependencies/lua-5.1/src/luac.c:#define luac_c dependencies/lua-5.1/src/lundump.h:#ifdef luac_c dependencies/lua-5.1/src/print.c:#define luac_c Devander ___ Reply to this item at: http://gna.org/bugs/?21399 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3468] Metaticket: Clang clean build
Update of patch #3468 (project freeciv): Depends on: = patch #4373 ___ Reply to this item at: http://gna.org/patch/?3468 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4378] Minimize the gold clause when exchanging technologies
URL: http://gna.org/patch/?4378 Summary: Minimize the gold clause when exchanging technologies Project: Freeciv Submitted by: silene Submitted on: Tue 31 Dec 2013 03:20:26 PM CET Category: ai Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: In ai/default/advdiplomacy.c:suggest_tech_exchange, the AI computes how much the technologies of both players are worth. It then suggests the first two technologies such that the difference of their worth, once converted to gold, can be paid by the players. Notice I just said first. As a consequence, the AI sometimes suggests really dumb treaties. (No, I won't pay 300 gold and one of my technologies, for some technology I can research in just two turns! [1]) This patch alleviates the issue by not stopping at the first two technologies. Instead, it suggests the technology exchange that minimizes the gold clause. That way, the subjectivity of how much a technology is worth as gold no longer matters: the treaties seem much more sensible when the AI asks for tens of gold only rather than hundreds. And just so that there is no misunderstanding, I do not change the way technologies are evaluated, just the way they are selected. For instance, if only one treaty was possible before the patch, this is the treaty that will be suggested after the patch. [1] This may indicate a bug in the function used to evaluate how much the technologies are worth. Still, I think the patch is relevant, even if this hypothetical bug were to be fixed. ___ File Attachments: --- Date: Tue 31 Dec 2013 03:20:26 PM CET Name: tech_exchange.patch Size: 2kB By: silene http://gna.org/patch/download.php?file_id=19585 ___ Reply to this item at: http://gna.org/patch/?4378 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4280] Appdata file for freeciv
Update of patch #4280 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.4.2, 2.5.0, 2.6.0 ___ Follow-up Comment #2: Attached patches add appdata file corresponding to each desktop file. I replaced overall freeciv description (the one there was from some distribution's packet description, I think) with description from www.freeciv.org main page, and added part specific to component program in question. Set correct homepage. (file #19586, file #19587, file #19588) ___ Additional Item Attachment: File name: Appdata.patch Size:12 KB File name: Appdata-S2_5.patch Size:10 KB File name: Appdata-S2_4.patch Size:9 KB ___ Reply to this item at: http://gna.org/patch/?4280 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21406] Alien, civ/2 nation translations searched from wrong domain
URL: http://gna.org/bugs/?21406 Summary: Alien, civ/2 nation translations searched from wrong domain Project: Freeciv Submitted by: cazfi Submitted on: Tue 31 Dec 2013 08:28:33 PM EET Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0, 2.6.0 ___ Details: Nations of alien, civ1, and civ2 rulesets are included in core translation domain, but they are not marked like that, so their translations will be looked from extended nations domain. Fix attached. ___ File Attachments: --- Date: Tue 31 Dec 2013 08:28:33 PM EET Name: AlienCiv12Domain.patch Size: 10kB By: cazfi http://gna.org/bugs/download.php?file_id=19589 ___ Reply to this item at: http://gna.org/bugs/?21406 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4379] Autosaving based on timer
URL: http://gna.org/patch/?4379 Summary: Autosaving based on timer Project: Freeciv Submitted by: cazfi Submitted on: Tue 31 Dec 2013 11:31:50 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: In a long-turn style play autosave only once a turn is not sufficient. I'd want actions of the players who acted in the beginning of the turn saved before waiting another 48 hours for turn to finish. Attached patch adds autosave type Timer that causes game to be saved in savefrequency intervals. ___ File Attachments: --- Date: Tue 31 Dec 2013 11:31:50 PM EET Name: TimerSaves.patch Size: 8kB By: cazfi http://gna.org/patch/download.php?file_id=19590 ___ Reply to this item at: http://gna.org/patch/?4379 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
