[Freeciv-Dev] [bug #22834] City map not greyed out when governor enabled

2014-10-27 Thread Frank
Follow-up Comment #1, bug #22834 (project freeciv):

bug #20509 discusses this unnecessary fog.  I always have to disable the
governor only to check what they are doing, and I still haven't found out what
causes this fog, maybe it's the amplio(2) tx.fog tile.

___

Reply to this item at:

  http://gna.org/bugs/?22834

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5357] common/tech.c: player_invention_reachable call cost is exponential with deep technology trees: fixed with memoization

2014-10-27 Thread pepeto
Follow-up Comment #10, patch #5357 (project freeciv):

I think they can be solved, without reverting the speedup part of the ticket.
I could do it easy when I will be back at home (in about one week).

___

Reply to this item at:

  http://gna.org/patch/?5357

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22847] reset in server/commands.c

2014-10-27 Thread Frank
Follow-up Comment #4, bug #22847 (project freeciv):

When I look in voting.c it has LF, while commands.c has CRLF. 

svn proplist server/voting.c reports no properties. 
svn proplist server/commands.c reports svn:eol-style (and two other
properties).

svn propget svn:eol-style server/commands.c says native. Sigh. 

svn propset svn:eol-style LF -R . 

svn propget svn:eol-style server/commands.c says LF. Better.

Okay, now those diffs should be able to preserve trailing white space at least
when I say so.

___

Reply to this item at:

  http://gna.org/bugs/?22847

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22876] root_req propagation can no longer stop at root_req=None

2014-10-27 Thread Marko Lindqvist
Update of bug #22876 (project freeciv):

  Status:  Ready For Test = In Progress
 Assigned to:None = pepeto 

___

Follow-up Comment #8:

In patch #5357 pepeto said that he will create fix instead of reverting it.

___

Reply to this item at:

  http://gna.org/bugs/?22876

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in base_transporter_for_unit()

2014-10-27 Thread Jacob Nevins
Follow-up Comment #10, patch #5367 (project freeciv):

 In the case you compute all values at the beginning of the unit 
 process
My patch is a hybrid; it only hoists the 'expensive' calculations to the top,
to avoid iterating over the transport stack multiple times. Cheap data
collection happens next to the relevant test. So it's still necessary to
structure the code as you had it.

I'm assuming this isn't an objection to commit so will commit this now, as
we've probably spent too long on it as it is. I'll revisit it if requested.

___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22846] typo in README

2014-10-27 Thread Jacob Nevins
Update of bug #22846 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22846

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22869] freeciv-manual claims to support -- --help but doesn't

2014-10-27 Thread Jacob Nevins
Update of bug #22869 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22869

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22803] City struck by plague should not grow again immediately

2014-10-27 Thread Jacob Nevins
Update of bug #22803 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22803

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5388] Lower expectations in freeciv-manual(6)

2014-10-27 Thread Jacob Nevins
Update of patch #5388 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5388

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22805] civ2civ3: should more Apollo Program effects survive its destruction?

2014-10-27 Thread Jacob Nevins
Update of bug #22805 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22805

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22840] The science stock cannot be set in the editor

2014-10-27 Thread Jacob Nevins
Update of bug #22840 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22840

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22804] civ2civ3: Sewer System doesn't need Aqueduct, but help implies it does

2014-10-27 Thread Jacob Nevins
Update of bug #22804 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22804

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5367] Consider move_rate when picking a transport in base_transporter_for_unit()

2014-10-27 Thread Jacob Nevins
Update of patch #5367 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5367

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5390] Tidy recent requirement text

2014-10-27 Thread Jacob Nevins
Update of patch #5390 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5390

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22871] Nation requirement with Alliance range isn't unchanging

2014-10-27 Thread Jacob Nevins
Update of bug #22871 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22871

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5383] NationGroup requirement

2014-10-27 Thread Jacob Nevins
Update of patch #5383 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5383

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5389] Improve 'unitwaittime' docs

2014-10-27 Thread Jacob Nevins
Update of patch #5389 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5389

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22870] MinCulture at =Player range doesn't include national culture

2014-10-27 Thread Jacob Nevins
Follow-up Comment #4, bug #22870 (project freeciv):

 checking the *sum* of all culture values provided would make 
 sense, while we currently check if *any* single contributor has 
 high enough culture value.
I think the latter is more obviously a term you'd want to use in real
rulesets, so I'm happy with the current implementation.

If we want to sum different players, invent a new TotalCulture requirement
which does that (supporting ranges Team/Alliance/World).
(Could do the same for cities, at Traderoute range, although that would be a
bit mad.)

___

Reply to this item at:

  http://gna.org/bugs/?22870

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5383] NationGroup requirement

2014-10-27 Thread Jacob Nevins
Follow-up Comment #3, patch #5383 (project freeciv):

Oops, inadvertently included unrelated changes to culture requirements
descriptions in this patch. Will clean up in patch #5393.

___

Reply to this item at:

  http://gna.org/patch/?5383

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5393] Tweak culture requirement text

2014-10-27 Thread Jacob Nevins
Update of patch #5393 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-culture-req-text.patch   Size:5 KB


___

Reply to this item at:

  http://gna.org/patch/?5393

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5394] Propagate updated nation groups comments to all rulesets

2014-10-27 Thread Jacob Nevins
Update of patch #5394 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-rulesetdoc-nation-groups.patch Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?5394

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22784] Problem configuring the Qt client

2014-10-27 Thread Marko Lindqvist
Update of bug #22784 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22784

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5298] missing Amplio2 mountains.spec [info] section header

2014-10-27 Thread Marko Lindqvist
Update of patch #5298 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 
 Planned Release: 2.4.4, 2.5.0, 2.6.0 = 2.4.4, 2.5.0-beta2, 2.6.0


___

Reply to this item at:

  http://gna.org/patch/?5298

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22845] civ2civ3: StackDeath on trench (pre-fortress)

2014-10-27 Thread Marko Lindqvist
Update of bug #22845 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22845

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5387] Autosettlers to use activity_to_extra_cause()

2014-10-27 Thread Marko Lindqvist
Update of patch #5387 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5387

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5386] diplbulbcost diplgoldcost

2014-10-27 Thread Marko Lindqvist
Update of patch #5386 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5386

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5395] Name freeciv-manual produced html-files by the ruleset

2014-10-27 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5395

 Summary: Name freeciv-manual produced html-files by the
ruleset
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 28 Oct 2014 01:22:47 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

To avoid accidentally assuming manual1.html refers to one ruleset when it has
actually been regenerated to refer another one.



___

File Attachments:


---
Date: Tue 28 Oct 2014 01:22:47 AM EET  Name: ManualName.patch  Size: 528B  
By: cazfi

http://gna.org/patch/download.php?file_id=22771

___

Reply to this item at:

  http://gna.org/patch/?5395

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22781] Windows start script issues

2014-10-27 Thread Jacob Nevins
Follow-up Comment #5, bug #22781 (project freeciv):

 Set property svn:eol-style=native for .cmd files.
Presumably this won't help with what we ship in Windows installers, because
our I build our tarballs from svn on Unix.

___

Reply to this item at:

  http://gna.org/bugs/?22781

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

2014-10-27 Thread Jacob Nevins
Follow-up Comment #15, bug #22381 (project freeciv):

(FWIW, the original description of this change I wrote for release notes
before it was reverted: Units can now attack out of cities on non-native
terrain regardless of whether their class has the AttFromNonNative flag. For
instance, land units can now attack out of ocean cities in the Alien
ruleset.)

___

Reply to this item at:

  http://gna.org/bugs/?22381

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22794] Resolve rules regarding which source tiles can be attacked from

2014-10-27 Thread Jacob Nevins
Update of bug #22794 (project freeciv):

Severity: 5 - Blocker = 3 - Normal 
Priority:7 - High = 5 - Normal 
 Planned Release:  2.5.0-beta2, 2.6.0 = 2.6.0  


___

Reply to this item at:

  http://gna.org/bugs/?22794

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22882] diplbulbcost diplgoldcost short descriptions

2014-10-27 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22882

 Summary: diplbulbcost  diplgoldcost short descriptions
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 28 Oct 2014 01:55:32 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

From patch #5386:
Both new settings have the same short description Penalty when getting tech
or gold from treaty.





___

Reply to this item at:

  http://gna.org/bugs/?22882

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22824] multiplayer ruleset: Savegames not portable against ruleset changes due to saved script variables

2014-10-27 Thread Jacob Nevins
Follow-up Comment #4, bug #22824 (project freeciv):

I don't think this would ever have caused trouble, as I think the order/number
of techs and buildings has not changed since the ruleset was added in patch
#1838. It's future-proofing.

___

Reply to this item at:

  http://gna.org/bugs/?22824

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22636] pathfinding useless code

2014-10-27 Thread Jacob Nevins
Follow-up Comment #5, bug #22636 (project freeciv):

For release notes, did this cause any actual misbehaviour?

___

Reply to this item at:

  http://gna.org/bugs/?22636

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22829] alien ruleset: A translation of the story opening therefore won't be shown (Lua i18n)

2014-10-27 Thread Marko Lindqvist
Update of bug #22829 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.6.0  

___

Follow-up Comment #1:

Attached patch puts all the text to one line in .lua file (with '\n' linefeeds
to actually display)
That's what tutorial scenario seems to be doing.

(file #22772)
___

Additional Item Attachment:

File name: TranslatePicnic.patch  Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22829

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22882] diplbulbcost diplgoldcost short descriptions

2014-10-27 Thread Marko Lindqvist
Update of bug #22882 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Fix

(file #22773)
___

Additional Item Attachment:

File name: ShortDiplcost.patchSize:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?22882

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22722] Client goto crash when taking an AI player

2014-10-27 Thread Jacob Nevins
Follow-up Comment #3, bug #22722 (project freeciv):

 It is due to the recent changes in client goto.
How recent -- since the last release?
Guess -- was this introduced by bug #22624?

___

Reply to this item at:

  http://gna.org/bugs/?22722

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5397] Switch from glib-gettext.m4 to gettext.m4

2014-10-27 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5397

 Summary: Switch from glib-gettext.m4 to gettext.m4
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 28 Oct 2014 03:37:34 AM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Do not use glib version of gettext macros, but upstream gettext.

In addition to applying this patch, remove m4/glib-gettext.m4.

I can't believe how easy this was! Nothing of the stuff we had implemented on
top of glib-gettext.m4 needed porting - current gettext macros automatically
detect that we are using multiple translation domains and that those are
located in translations/[freeciv|nations|ruledit].

The translations/*/Makefile.in.in (and other gettext files to those
directories) should be updated too, to match macro versions, but it seems that
can wait for later ticket.




___

File Attachments:


---
Date: Tue 28 Oct 2014 03:37:34 AM EET  Name: UpstreamGettext.patch  Size: 2kB 
 By: cazfi

http://gna.org/patch/download.php?file_id=22774

___

Reply to this item at:

  http://gna.org/patch/?5397

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] 2.5 Release Goals (and 2.5.0-beta2)

2014-10-27 Thread Jacob Nevins
I wrote:
 Summary: I'm not aware of any major reasons not to spin a beta2 release
 soonish. In particular, I haven't spotted anything outstanding in the
 beta1 bug reports that would block another beta.
 Anyone got anything? Otherwise I'll suggest a date.

Bugs have come out of the woodwork, and blockers are now tracked at
http://gna.org/task/?7861.

Anyway, here's a first draft of the release notes.
http://www.freeciv.org/wiki/NEWS-2.5.0-beta2

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev