[Freeciv-Dev] [bug #23884] Some segmentation faults seen in production

2015-09-20 Thread Marko Lindqvist 
Follow-up Comment #1, bug #23884 (project freeciv):

All of these are unit data out-of-sync issues. Numbers 1 and 3 have ai_task of
the unit set to one that requires destination tile, but destination tile is
NULL (maybe it gets improperly set to NULL somewhere where entire task should
be changed to AIUNIT_NOT instead). Number 2 is about unit having an targeted
activity, but no target (this has high probability of being freeciv-web
specific, as it has its own target setting logic since the web-client lacks
the functionality to request correct target)

While the root-cause(s) are unknown, I at least updated the freeciv-web patch
so that units won't get forever stuck to unusable state, AI just bypassing
their handling, in cases 1 & 3.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6366] Document num2char()'s limit on actions

2015-09-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Document num2char()'s limit on actions
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 20 Sep 2015 11:21:41 AM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

even if the number of actions are *far* away from being limited by it.



___

File Attachments:


---
Date: Sun 20 Sep 2015 11:21:41 AM UTC  Name:
0001-Document-num2char-s-limit-on-actions.patch  Size: 753B   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6350] Descriptions for current tileset in the Help menu

2015-09-20 Thread Marko Lindqvist 
Update of patch #6350 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23889] Missing return from activity_requires_target() when fc_assert_ret_val() not in use

2015-09-20 Thread Marko Lindqvist 
URL:
  

 Summary: Missing return from activity_requires_target() when
fc_assert_ret_val() not in use
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 20 Sep 2015 01:47:06 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

activity_requires_target() causes "control reaches end of non-void function"
when fc_assert_ret_val() of the default branch is not in use.

Fix attached.




___

File Attachments:


---
Date: Sun 20 Sep 2015 01:47:06 PM EEST  Name:
DefaultFALSEActRequiresTarget.patch  Size: 370B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6362] Unhardcode that Caravans only can help wonders

2015-09-20 Thread Sveinung Kvilhaugsvik 
Update of patch #6362 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6365] Document num2char() limits the number of extras

2015-09-20 Thread Sveinung Kvilhaugsvik 
Update of patch #6365 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23884] Some segmentation faults seen in production

2015-09-20 Thread Andreas Røsdal 
Follow-up Comment #2, bug #23884 (project freeciv):

Thanks! Pushed to production.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

2015-09-20 Thread Marko Lindqvist 
URL:
  

 Summary: explorer_goto() can mess goto_tile for AI task using
it
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 20 Sep 2015 01:19:53 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

explorer_goto() is called based on unit ACTIVITY, and there's no direct
linkage between ACTIVITY and AITASK. So it's possible (or at least not
prevented by design. It might be hard to find a special case code path where
this happens) that unit has a AITASK that requires goto_tile set correctly,
but then unit does exploring and the goto_tile gets mangled.

Proper fix is not as easy as restoring the old goto_tile after exploring. As
the comment says, if exploring is going to continue next turn, we may want to
send destination currently considered final to the client.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6363] Save unit order targets as a vector

2015-09-20 Thread Sveinung Kvilhaugsvik 
Update of patch #6363 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: unit_order_target_vector.patch Size:10 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23891] Loading XZ compressed savefiles goes fail

2015-09-20 Thread Christian Knoke 
URL:
  

 Summary: Loading XZ compressed savefiles goes fail
 Project: Freeciv
Submitted by: chrisk
Submitted on: Sun 20 Sep 2015 03:13:39 PM CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:


Vers. 2.5.1 compiled from source on debian oldstable, gtk3 client

In server options, I set compression=xz and complevel=9

Starting game, auto save file writing all fine.

Loading savefile, client console:

chris: 'load /home/chris/.freeciv/saves/mouldy-T0032-Y-2400-manual.sav.xz'
/load: Could not load savefile:
/home/chris/.freeciv/saves/mouldy-T0032-Y-2400-manual.sav.xz

I can read savefile with xzless, looks sane on first view

savefile attached

debug level 3 log attached

all saves are affected so far

Christian





___

File Attachments:


---
Date: Sun 20 Sep 2015 03:13:39 PM CEST  Name:
mouldy-T0032-Y-2400-manual.sav.xz  Size: 12kB   By: chrisk


---
Date: Sun 20 Sep 2015 03:13:39 PM CEST  Name: xz-noload.debug3.log  Size: 4kB 
 By: chrisk



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23892] tinycthread.h not found from include paths of some components including genlist.h

2015-09-20 Thread Marko Lindqvist 
URL:
  

 Summary: tinycthread.h not found from include paths of some
components including genlist.h
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 20 Sep 2015 06:47:57 PM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 3.0.0

___

Details:

TRUNK compilation fails with tinycthread enabled since genlist.h now includes
fcthread.h.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23892] tinycthread.h not found from include paths of some components including genlist.h

2015-09-20 Thread Marko Lindqvist 
Update of bug #23892 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix

(file #25169)
___

Additional Item Attachment:

File name: ClassicTinyCThread.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23891] Loading XZ compressed savefiles goes fail

2015-09-20 Thread Marko Lindqvist 
Update of bug #23891 (project freeciv):

  Status:None => In Progress
 Planned Release: => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #1:

It seems that this file loads fine once one makes xz decompression buffers big
enough (70Mb is not enough, 100Mb is).

So the file is fine (saved ok), but cannot be loaded. As a workaround (if you
need this file) you can decompress it outside freeciv and load as plain file.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23890] alien and civ2civ3 has BuildingGenus req on wrong action enabler

2015-09-20 Thread Sveinung Kvilhaugsvik 
Update of bug #23890 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix attached.

(file #25166)
___

Additional Item Attachment:

File name: 0002-Fix-alien-and-civ2civ3-action-enablers.patch Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23886] Does not save settings from one game to the next

2015-09-20 Thread anonymous 
Follow-up Comment #1, bug #23886 (project freeciv):

In my Win7x64 system, Freeciv saves the changes to "More Game Options" in the
file (or folder?) below:
C:/Users/Jim/AppData/Roaming/.freeciv-client-rc-2.5
but then 2.5.1 does not see those saved changes for the start of the next new
game. Previous versions did see the saved changes, so my guess is that 2.5.1
has a "typo" and neglects to specify the Roaming/.Freeciv folder that 2.5.1
can see (since that is where the saved games are kept). With some difficulty,
I was able to copy .freeciv-client-rc-2.5 from Roaming/ to Roaming/.Freeciv/
and now a new game does remember some, but not all, of the previously saved
game options.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23891] Loading XZ compressed savefiles goes fail

2015-09-20 Thread Marko Lindqvist 
Update of bug #23891 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Well, it IS enough to increase memory limit to 65Mb (for loading this
particular file).

Attached fix has an implementation to increase it further if needed, but in my
tests falling back to that implementation never really helped as it always
resulted in corrupted stream error then. Regardless having that part does not
hurt (failing already failing case in a different way) but might help in some
case.

(file #25167, file #25168)
___

Additional Item Attachment:

File name: Xz65Mb.patch   Size:3 KB
File name: Xz65Mb-S2_5.patch  Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23890] alien and civ2civ3 has BuildingGenus req on wrong action enabler

2015-09-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: alien and civ2civ3 has BuildingGenus req on wrong
action enabler
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 20 Sep 2015 01:01:50 PM UTC
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: Any
 Planned Release: 3.0.0

___

Details:






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23891] Loading XZ compressed savefiles goes fail

2015-09-20 Thread Marko Lindqvist 
Follow-up Comment #4, bug #23891 (project freeciv):

>> Well, it IS enough to increase memory limit to 65Mb (for loading this
particular file). 

> The savegame file 135 Kb uncompressed.

The main reason I'm not so thrilled about the idea of dropping .bz2 support
completely.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23692] Prevent unauthorized login name

2015-09-20 Thread taka 
Follow-up Comment #2, bug #23692 (project freeciv):

Another incorrect player name:

[link (incomplete featured text, doesn't show any chat messages)


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6358] Read alient description from the README

2015-09-20 Thread Marko Lindqvist 
Update of patch #6358 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6367] orders system: support targeted steal tech

2015-09-20 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6367 (project freeciv):

Logmessage type: "unspported"

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6367] orders system: support targeted steal tech

2015-09-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: orders system: support targeted steal tech
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 20 Sep 2015 09:06:47 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Use the existing target field to specify the target tech.



___

File Attachments:


---
Date: Sun 20 Sep 2015 09:06:47 PM UTC  Name:
0004-orders-system-support-targeted-steal-tech.patch  Size: 6kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6367] orders system: support targeted steal tech

2015-09-20 Thread Sveinung Kvilhaugsvik 
Update of patch #6367 (project freeciv):

  Depends on: => patch #6363


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23891] Loading XZ compressed savefiles goes fail

2015-09-20 Thread Christian Knoke 
Follow-up Comment #3, bug #23891 (project freeciv):

> Well, it IS enough to increase memory limit to 65Mb (for loading this
particular file). 

The savegame file 135 Kb uncompressed.

Christian


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev