[Freeciv-Dev] [bug #23957] pollution during disorder

2015-10-21 Thread log65536 
URL:
  

 Summary: pollution during disorder
 Project: Freeciv
Submitted by: log65536
Submitted on: Wed 21 Oct 2015 11:15:37 PM JST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.0
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

A city is in disorder and produces no shields.
In the gtk2 client, city dialog, the pollution value is displayed as positive
(like it would be without the disorder), but the tooltip on mouse-click shows
0 pollution from shields and 0 pollution from citizens adding up to 0 total
pollution. Which is the correct value?

Attached savegame verifies that tiles do get polluted on Turn Done.

So the tooltip is in error, though I would think that it is more logical than
the actual server behavior. You don't produce, you don't burn the fuel, no
harmful gasses should get released at all.

If there are units with shield upkeep, the tooltip shows their shields as
generating pollution, which is only fair; this production actually does occur
during disorder.

So I would vote for a rule change to embrace the tooltip calculation but just
fixing the tooltip is fine too.




___

File Attachments:


---
Date: Wed 21 Oct 2015 11:15:37 PM JST  Name: TheIronPlanet.sav.bz2  Size: 5kB 
 By: log65536



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23951] Tile and units targets aren't invalid

2015-10-21 Thread Sveinung Kvilhaugsvik 
Update of bug #23951 (project freeciv):

Severity:  3 - Normal => 2 - Minor  
  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22934] Spaceship part not placed if client not connected when it's built

2015-10-21 Thread HanduMan 
Follow-up Comment #1, bug #22934 (project freeciv):

Verified. :(

Online game, ongoing, so no savegame to offer. But the story goes...

T192 - Built 12 Space Modules and 8 Space Components.
T193 - Built 8 Space Components and 12 Space Structurals.
T194 - Built 20 Space Structurals.

That makes the maximum of everything, right? Only, I was not logged in on
ending of T193 nor T194 and all I can see on my Spaceship report are the
Modules and half of the Components built on T192. And all the stats are at
zero because the parts are not connected due to missing Structurals.
Furthermore, I cannot build any more spaceship parts because I have already
built everything.

So no Alpha Centauri for me. :(

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6458] Make sure that message_buffer exist before appending to it

2015-10-21 Thread Marko Lindqvist 
URL:
  

 Summary: Make sure that message_buffer exist before appending
to it
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 21 Oct 2015 07:45:32 PM EEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

Noticed as possible explanation for chatline.c assert message seen in bug
#23861.

Both gtk2- and gtk3-clients handled.



___

File Attachments:


---
Date: Wed 21 Oct 2015 07:45:32 PM EEST  Name:
RealOutputExistingBufferOnly.patch  Size: 3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-21 Thread Marko Lindqvist 
Update of bug #23861 (project freeciv):

 Planned Release: => 2.5.x, 2.6.0, 3.0.0

___

Follow-up Comment #12:

> "in scroll_if_necessary()
[../../../../../client/gui-gtk-2.0/chatline.c::561]: assertion 'scroll_target
!= ((void *)0)' failed."

It's hard to see how that would be directly related, but at least it's a clear
error message (and one I've never seen before) to start investigating.
Patch #6458 adds a check against the only case that I can figure out as a
possibility for that error situation to raise, except such a memory/stack
corruption that causes program execution to jump practically randomly.
Then to overall picture could be something like that yet-unknown error (the
main error we would like to get to) causes client to start shutdown, message
buffer gets destroyed as part of that process, and then there's an attempt to
write something to it (possibly the original error message), causing the
chatline assert.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22934] Spaceship part not placed if client not connected when it's built

2015-10-21 Thread Marko Lindqvist 
Update of bug #22934 (project freeciv):

 Planned Release: => 2.5.2, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22934] Spaceship part not placed if client not connected when it's built

2015-10-21 Thread HanduMan 
Follow-up Comment #2, bug #22934 (project freeciv):

Sorry, forgot to mention. The game runs on 2.5.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23956] diplomats.c has many 'unit_alive(were_checking_if_this_is_illegal_ptr->id)' -constructs

2015-10-21 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #1, bug #23956 (project freeciv):

Is it OK if I take this or have you started to work on it?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23956] diplomats.c has many 'unit_alive(were_checking_if_this_is_illegal_ptr->id)' -constructs

2015-10-21 Thread Marko Lindqvist 
Update of bug #23956 (project freeciv):

 Assigned to:None => sveinung   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6448] Split disband unit from packet handling

2015-10-21 Thread Sveinung Kvilhaugsvik 
Update of patch #6448 (project freeciv):

  Status:  Ready For Test => Done   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6451] i18n: the Freeciv source files are UTF-8

2015-10-21 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #4, patch #6451 (project freeciv):

The --from-code option was introduced in version 0.12. 2.6 needs 0.14 or
better. 3.0 needs 0.15 or better.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6449] Support enabler controlled actions with no target

2015-10-21 Thread Sveinung Kvilhaugsvik 
Update of patch #6449 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6448] Split disband unit from packet handling

2015-10-21 Thread Sveinung Kvilhaugsvik 
Update of patch #6448 (project freeciv):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5911] Load gfx files with gdk-pixbuf

2015-10-21 Thread Marko Lindqvist 
Update of patch #5911 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23956] diplomats.c has many 'unit_alive(were_checking_if_this_is_illegal_ptr->id)' -constructs

2015-10-21 Thread Sveinung Kvilhaugsvik 
Update of bug #23956 (project freeciv):

Category:None => general
  Status:None => In Progress
 Release:S2_6 => TRUNK, S2_6
Operating System:None => Any
 Planned Release: => 3.0.0, 2.6.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6459] Fix xgettext warnings

2015-10-21 Thread Marko Lindqvist 
URL:
  

 Summary: Fix xgettext warnings
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 21 Oct 2015 09:40:35 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

There's currently one 'unterminated character constant' warning from civ2 and
two from alien ruleset. Attached patch fixes those.



___

File Attachments:


---
Date: Wed 21 Oct 2015 09:40:36 PM EEST  Name: UnterminatedCharConstants.patch 
Size: 1kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-21 Thread Jarkko Huttunen 
Follow-up Comment #13, bug #23861 (project freeciv):

Actually, executing the test build (r30116) from freeciv-gtk2.exe seems to
work. It only hangs up when executed via freeciv-gtk2.cmd for different
language.

It still gave the same stderr.txt log, and following error message when
quitting the program:
"Command in address "0x7c91168b" pointed to memory in address"0x0004",
memory cannot be "read"."

This applies only to that test build, release version always hangs up.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-21 Thread Marko Lindqvist 
Follow-up Comment #14, bug #23861 (project freeciv):

> It only hangs up when executed via freeciv-gtk2.cmd for different language.

Am I righto assume that the language in question has 'ääkkösiä'?

Does freeciv-gtk2.exe hang the same way if you run it directly with LANG set
to 'fi'?


That 0x0004 sounds like NULL + offset of 4, so it might indeed be
something that patch #6458 will fix, and then it should reveal in the console
what was the message that it was unable to write to the chatline.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6460] MinTechs requirement

2015-10-21 Thread Marko Lindqvist 
URL:
  

 Summary: MinTechs requirement
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 21 Oct 2015 11:30:40 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Requirement type to track how far the game has progressed, or the "World" or
single "Player", in the means of number of techs known.



___

File Attachments:


---
Date: Wed 21 Oct 2015 11:30:40 PM EEST  Name: MinTechs.patch  Size: 11kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-21 Thread Jarkko Huttunen 
Follow-up Comment #15, bug #23861 (project freeciv):

"Am I righto assume that the language in question has 'ääkkösiä'?

Does freeciv-gtk2.exe hang the same way if you run it directly with LANG set
to 'fi'?"

The opposite. Due to automatic localization, game uses finnish when run
directly. Test version seems to hang up only when run other than systems
native language (finnish in my case).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6463] Send actor and target, not id, to action doers

2015-10-21 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Send actor and target, not id, to action doers
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 21 Oct 2015 09:08:37 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

Functions that have performing an action enabler controlled action as their
only job should deal in actors and targets, not actor ids and target ids.
Taking id numbers is a fossil from the time when they were responsible for
handling packets sent over the network.

Noticed by Marko Lindqvist  in bug #23956



___

File Attachments:


---
Date: Wed 21 Oct 2015 09:08:37 PM UTC  Name:
3.0-Send-actor-and-target-not-id-to-action-doers.patch  Size: 5kB   By:
sveinung


---
Date: Wed 21 Oct 2015 09:08:37 PM UTC  Name:
2.6-Send-actor-and-target-not-id-to-action-doers.patch  Size: 5kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6464] Partially restore --preserve-dup-deps

2015-10-21 Thread Marko Lindqvist 
URL:
  

 Summary: Partially restore --preserve-dup-deps
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 22 Oct 2015 12:27:11 AM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

When minimum libtool version was updated, hack to add --preserve-dup-deps was
also removed.
It turns out that it's still needed on some configurations while linking the
client.

Bring it back, but in a better way than it was. Instead of the hack to affect
all libtool invocations, add the flag just to client/Makefile and cleanly via
AM_LIBTOOLFLAGS.



___

File Attachments:


---
Date: Thu 22 Oct 2015 12:27:11 AM EEST  Name: PreserveClientDupDeps.patch 
Size: 498B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6462] Remove unused trade route target finder

2015-10-21 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Remove unused trade route target finder
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 21 Oct 2015 08:45:44 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

The function do_unit_establish_trade() is never called without a target city.
Remove the code that tries to find a target city at the actor's tile when no
target city is specified.



___

File Attachments:


---
Date: Wed 21 Oct 2015 08:45:44 PM UTC  Name:
0002-Remove-unused-trade-route-target-finder.patch  Size: 953B   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6465] Abort some actions on domestic target

2015-10-21 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Abort some actions on domestic target
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 21 Oct 2015 09:28:04 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

Have the action doer functions responsible for map theft, gold theft, city
inciting and unit bribery abort if the target is domestic.

Note that the functions currently aren't called with domestic targets because
doing so is against the hard coded rules.



___

File Attachments:


---
Date: Wed 21 Oct 2015 09:28:04 PM UTC  Name:
3.0-Abort-some-actions-on-domestic-target.patch  Size: 2kB   By: sveinung


---
Date: Wed 21 Oct 2015 09:28:04 PM UTC  Name:
2.6-Abort-some-actions-on-domestic-target.patch  Size: 2kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6461] Explicitly send target tile to city_build()

2015-10-21 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Explicitly send target tile to city_build()
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 21 Oct 2015 08:43:17 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

rather than sending it implicitly (the actor unit's location).



___

File Attachments:


---
Date: Wed 21 Oct 2015 08:43:17 PM UTC  Name:
0001-Explicitly-send-target-tile-to-city_build.patch  Size: 2kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-21 Thread Marko Lindqvist 
Follow-up Comment #16, bug #23861 (project freeciv):

> Test version seems to hang up only when run other than systems
> native language (finnish in my case).

Just to make sure: Does this happens both when the other language is en_US
(which is freeciv internal language - we actually get en_US to use by not
using any localization at all) and when it's something completely different,
such as en_UK ?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22934] Spaceship part not placed if client not connected when it's built

2015-10-21 Thread Marko Lindqvist 
Update of bug #22934 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #3:

Untested patch for stop-gag solution attached. TRUNK version only at this time
(It's the only branch that has the spaceship part autoplace code on the server
common code, as it has already been requried by freeciv-web solution. Other
branches need to backport these changes first.)

If player (client) does not place the spaceship parts during the turn
following their production, server autoplaces them.


(file #25391)
___

Additional Item Attachment:

File name: AutoplaceSpaceAfterTurn.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6467] Make target/actor exists sanity checks asserts

2015-10-21 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Make target/actor exists sanity checks asserts
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 21 Oct 2015 11:07:22 PM UTC
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

The checks that actor and target survived the Lua in the action doer functions
are redundant because of the checks in unit_perform_action(). Change them into
asserts.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6466] Wooden Fort art for Amplio2

2015-10-21 Thread Marko Lindqvist 
URL:
  

 Summary: Wooden Fort art for Amplio2
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 22 Oct 2015 01:34:31 AM EEST
Category: art
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

GriffonSpade's new Fort art from:

http://forum.freeciv.org/f/viewtopic.php?f=12=466=25

In S2_6/TRUNK the art is in bases.png and activities.png.
In S2_5 they are in modenrcities.png and tiles.png.



___

File Attachments:


---
Date: Thu 22 Oct 2015 01:34:31 AM EEST  Name: bases.png  Size: 44kB   By:
cazfi


---
Date: Thu 22 Oct 2015 01:34:31 AM EEST  Name: activities.png  Size: 13kB   By:
cazfi


---
Date: Thu 22 Oct 2015 01:34:31 AM EEST  Name: moderncities-S2_5.png  Size:
158kB   By: cazfi


---
Date: Thu 22 Oct 2015 01:34:31 AM EEST  Name: tiles-S2_5.png  Size: 83kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23956] diplomats.c has many 'unit_alive(were_checking_if_this_is_illegal_ptr->id)' -constructs

2015-10-21 Thread Sveinung Kvilhaugsvik 
Update of bug #23956 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Use the already existing actor_id and target_id when unit_perform_action()
checks that actor and target survived the Lua.

The checks in the action doer functions are redundant because of the checks in
unit_perform_action(). Drop them.

Drop the check in do_unit_disband(). It is called by handle_unit_disband() and
unit_do_disband_trad(). handle_unit_disband() gets its unit by looking it up
by id. unit_do_disband_trad() will return before the call if it manages to
disband the unit.

(file #25396, file #25397)
___

Additional Item Attachment:

File name: 3.0-Don-t-get-the-id-from-a-potentially-dead-struct.patch Size:12
KB
File name: 2.6-Don-t-get-the-id-from-a-potentially-dead-struct.patch Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3481] en_US locale (to restore diacritics etc)

2015-10-21 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #7, patch #3481 (project freeciv):

> See patch #6451.

Note that patch #6451 only touches the gettext side. An en_US locale could
still be useful if we want to use non ASCII characters in a C *string literal*
msgid. See https://www.gnu.org/software/gettext/FAQ.html#nonascii_strings (The
options -finput-charset, -fexec-charset and -fwide-exec-charset are GCC
specific)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev