[Freeciv-Dev] (PR#39885) Picks same nation twice from civil war list from same host nation

2007-11-24 Thread Jason Short

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39885 

It doesn't look the same as 17436.

From split_player()

  player_set_nation(cplayer, pick_a_nation(civilwar_nations, TRUE, 
FALSE,
   NOT_A_BARBARIAN));

The FALSE indicates that the is_available flag is to be ignored thus 
allowing any nation that has no player to be chosen.

Yet I don't see how a nation chosen through civil war can avoid having 
pnation-player set.

Will look at this in more detail later.  Perhaps a debug command for 
triggering civil war would be useful.

-jason


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39885) Picks same nation twice from civil war list from same host nation

2007-11-23 Thread [EMAIL PROTECTED]

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39885 

 On 11/23/07, [EMAIL PROTECTED]
 [EMAIL PROTECTED] wrote:
 
  I managed to take the Poles' capital and provoke civil war twice in
  succession in a single game. Both times, Freeciv decided to name the
  seceding faction as the Silesians, so the game ended up with two
  identically-named but separate nations.
 
 Could it have been before this patch was applied?
 
 http://bugs.freeciv.org/Ticket/Display.html?id=17436

I don't think so -- that patch was applied in January 2007, I didn't
start the game until May, and I believe I was always using the latest
available beta of 2.1.0.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39885) Picks same nation twice from civil war list from same host nation

2007-11-22 Thread Daniel Markstedt

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39885 

On 11/23/07, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:

 URL: http://bugs.freeciv.org/Ticket/Display.html?id=39885 

 I managed to take the Poles' capital and provoke civil war twice in
 succession in a single game. Both times, Freeciv decided to name the
 seceding faction as the Silesians, so the game ended up with two
 identically-named but separate nations. It would be good if this could
 be avoided.

 In polish.ruleset, we have
   civilwar_nations = lithuanian, silesian, ukrainian
 so it's not as if the server was pushed for choice (neither the
 Lithuanians nor the Ukrainians had ever been in the game).

 This would have been with one of the 2.1.0 betas (client and server); I
 don't know precisely which one offhand, but I have the savegames, and
 can probably guess what version I was using at the time.



Could it have been before this patch was applied?

http://bugs.freeciv.org/Ticket/Display.html?id=17436

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev