[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #10: Switched to tolua-5.1 (tolua 5.1.3) ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #11, bug #13709 (project freeciv): I get errors trying to compile S2_2 and trunk S2_2: dependencies/Makefile.am:3: required directory dependencies/tolua-5.1 does not exist utility/Makefile.am:60: `%'-style pattern rules are a GNU make extension configure.ac:942: required file `dependencies/tolua-5.1/Makefile.in' not found configure.ac:942: required file `dependencies/tolua-5.1/src/Makefile.in' not found configure.ac:942: required file `dependencies/tolua-5.1/src/lib/Makefile.in' not found configure.ac:942: required file `dependencies/tolua-5.1/src/bin/Makefile.in' not found make: *** [Makefile.in] Error 1 here it is the directory tolua-5.1b trunk: tolua.c: In function ‘main’: tolua.c:109: error: nested extern declaration of ‘tolua_tolua_open’ make[5]: *** [tolua.o] Error 1 make[5]: Leaving directory `/home/matthias/data/git/freeciv.svn/trunk/dependencies/tolua-5.1/src/bin' make[4]: *** [all-recursive] Error 1 make[4]: Leaving directory `/home/matthias/data/git/freeciv.svn/trunk/dependencies/tolua-5.1/src' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/matthias/data/git/freeciv.svn/trunk/dependencies/tolua-5.1' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/matthias/data/git/freeciv.svn/trunk/dependencies' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/matthias/data/git/freeciv.svn/trunk' make: *** [all] Error 2 This function is defined in a tolua.c and toluabind.c with different definitions? ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Status: Fixed = In Progress Planned Release: 2.3.0 = 2.2.1, 2.3.0 ___ Follow-up Comment #14: The trunk error might be a warning from a newer gcc (I compiled with v 4.3). Here is a diff that might fix that (Attached). Do you see an error or warning before / after the patch? I will update 2.2 to tolua 5.1.3 now. (file #8937) ___ Additional Item Attachment: File name: tolua_no_nested_decl.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Status: In Progress = Fixed ___ Follow-up Comment #17: The compilation error is tracked in a separate bug #15860 ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #6, bug #13709 (project freeciv): Perhaps you could add the patches to this external program code in an extra directory. This way they are available if a new version has to be patched. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #7, bug #13709 (project freeciv): That's a good idea. I think we can be without the first patch for tolua_outside, see bug #15841. The second patch for tolua_notnil is still interesting since there is a lot less duplicate code/duplicate checks needed with it. But we don't need to decide about that before we check in the switch to tolua-5.1. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #2, bug #13709 (project freeciv): I do not know lua. But if there are no compatibility problems I think this can go into 2.2.1. Do we need toluaxx after this change? ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #3, bug #13709 (project freeciv): Replying in ticket so discussion can be found from tracker later. Is it okay to patch tolua-5.1 to use tolua_outside. The implementation is already attached and is relatively trivial. This is a feature that makes a lot of sense for Freeciv's object oriented C. Is it then okay, to add a further feature to tolua-5.1? Obvious disadvantage is that if we start patching tolua, we (and 'we' here might be group of people in which neither of us remain at the time) have to maintain those patches when we update to new versions of tolua. I guess you are the expert here. If you think that pros are bigger than cons, I'm not objecting such tolua patching. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Follow-up Comment #4, bug #13709 (project freeciv): Thanks for your thoughts. I've been missing more discussion about script/api changes. Given how little that happened with scripting before, and how much that is possible now given the momentum we have (right now), I think we should just go forward with tolua-5.1.. Depending on a small modification for tolua_outside is not so bad; it's not about mechanics but simply the syntax of our api.pkg file. .. Quoting the email I sent about the tolua_notnil suggestion: Followup question to Marko: Is it then okay, to add a further feature to tolua-5.1? I want a variable modifier 'tolua_notnil' to mark those API function arguments that may not be nil (converted to NULL). The intended change reduces overhead (less code in tolua, since explicit isnil || isusertype check is changed to isusertype) and we can remove almost all our SCRIPT_ASSERT / argument checking boilerplate (which is much less code), and user error messages will be easier to understand (for example: argument #2 is 'nil', expected 'Building_Type') I have a working prototype of tolua_notnil Compatibility notes: If we use tolua_outside, our api.pkg will depend on that modification of tolua (however toluaxx and tolua++ are compatible alternatives). If we use tolua_notnil, it is still possible to use an unpatched tolua (losing the safety) by just undefining tolua_notnil: $#ifndef tolua_notnil $#define tolua_notnil $#endif tolua_notnil is part of my project to make sure there can't be any wild pointers accessible from our Lua API (If you wonder how right now, start with just saving a unit pointer in lua until after the unit is killed. You can also use 'Unit[.get][owner](find.player(1))' for example to the equivalent of ((struct unit *)pplayer)-owner.). This is a much deeper question that will take lots of time. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Assigned to: cazfi = englabenny Depends on: = bugs #15841 ___ Follow-up Comment #5: I hope you don't mind, I'm assigning this bug to me. Added dependency on remove tolua_outside patch. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Priority: 1 - Later = 5 - Normal Status: In Progress = Ready For Test ___ Follow-up Comment #1: Here are patches 1 and 2 for switching to tolua-5.1 in api.pkg. I ported tolua_outside from toluaxx, it is a separate patch (and will be committed separately) to make it easier / easier to understand when patching tolua-5.1 later. I propose: Committing sooner rather than later. Backport to 2.2, maybe before 2.2.1, if no big issues crop up later. Backporting only to keep maintenence burden lighter. Thoughts? (file #8877, file #8878) ___ Additional Item Attachment: File name: 2010040901-Port-tolua_outside-to-Lua-5.1.patch Size:74 KB File name: 2010040902-Use-tolua-5.1.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Planned Release: = 2.3.0 ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
Update of bug #13709 (project freeciv): Category:None = bootstrap Status:None = In Progress Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13709] Switch from toluaxx to tolua-5.1b
URL: http://gna.org/bugs/?13709 Summary: Switch from toluaxx to tolua-5.1b Project: Freeciv Submitted by: cazfi Submitted on: Wednesday 06/17/2009 at 02:33 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: First some history: When we updated lua to 5.1 there was no lua-5.1 compatible version of tolua. We had to switch from tolua to toluaxx. Quality of toluaxx has been somewhat shaky and it seems that it's dead project. Nowadays there is lua-5.1 compatible version of tolua, tolua-5.1b. I think it's time to switch from toluaxx back to tolua. Consider this notification as patch to add tolua-5.1b directory under dependencies; if nobody objects within 24h I'll add it. ___ Reply to this item at: http://gna.org/bugs/?13709 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
