[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Update of bug #14448 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed Planned Release:None = 2.1.10 ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Update of bug #14448 (project freeciv): Status: Confirmed = Ready For Test ___ Additional Item Attachment: File name: trunk_S2_2_embassy_clause2.diff Size:9 KB File name: S2_1_embassy_clause2.diff Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #8, bug #14448 (project freeciv): Added that the client also don't try to take in account the embassy effect (in gtk2 and sdl clients). ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #9, bug #14448 (project freeciv): Don't include bug #14490 fix in the patch for S2_2 and trunk... (file #6963) ___ Additional Item Attachment: File name: trunk_S2_2_embassy_clause3.diff Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #2, bug #14448 (project freeciv): This patches fix what I described below. Unfortunately, there is a more important problem under this one. Actually in this savegame, German has embassy with you from the Marco Polo wonder. But, the client seems to ignore this effect, which is actually well known. So, this needs to: * Send player info with real embassy status (checking for the embassy effect) * Or, wonders should be checked to add player bonus. (file #6898, file #6899) ___ Additional Item Attachment: File name: trunk_S2_2_embassy_clause.diff Size:6 KB File name: S2_1_embassy_clause.diff Size:6 KB ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #3, bug #14448 (project freeciv): * Or, wonders should be checked to add player bonus. That's insufficient solution. Effect can come from other sources as well (In alien ruleset free embassies are given after certain tech is researched. Some modpack may want to give free embassies to certain nation...) This also means that client does not necessarily know if effect is active or not. ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #4, bug #14448 (project freeciv): Is there some reason for not allowing an embassy even if they already have one through some other means? It's always puzzled me that some wonders are 'blocking' while others are not. For instance, you can't build cathedrals if you have Michelangelo's Chapel, and you cannot create embassies if you have Marco Polo, but you can still build barracks I and II with Sun Tzu (and cities will even start building them if their worklists are empty) and you can still build walls in cities even if you have the Great Wall (in fact, it's a good idea, since the wonder is obsoleted rather quickly). Marco Polo is also obsoleted fairly quickly, so I can imagine that a player would want to acquire embassies by other means. Therefore, perhaps it would be acceptable to allow embassy creation even if another effect already gives an embassy? ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #6, bug #14448 (project freeciv): Therefore, perhaps it would be acceptable to allow embassy creation even if another effect already gives an embassy? The attached patch does this. ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Follow-up Comment #7, bug #14448 (project freeciv): Spliting this ticket in 3 parts: * bug #14448: embassy problems. * bug #14452: for non-logical wonders effects for buildings. * bug #14453: for player range effects for great wonders. ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14448] Cannot accept treaty which ally approves of
Update of bug #14448 (project freeciv): Status:None = Confirmed Assigned to:None = pepeto ___ Follow-up Comment #1: This happens to all branches (S2_1, S2_2 and trunk). The problem is that they already have an embassy with you. The correct client behaviour would be to set the embassy clause not sensitive. And the server shouldn't allow this clause at all because it's invalid! Thank you for the savegame which saved me precious time. ___ Reply to this item at: http://gna.org/bugs/?14448 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
