[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-30 Thread pepeto

Follow-up Comment #12, bug #14603 (project freeciv):

Of course file #7163 is not for this ticket but for bug #14624.


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-30 Thread pepeto

Update of bug #14603 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-29 Thread pepeto

Follow-up Comment #11, bug #14603 (project freeciv):

The attached patch splits the FREECIV_PATH in many others:
* FREECIV_DATA_PATH (default .:data:~/.freeciv/2.3:$datadir/freeciv)
* FREECIV_SAVE_PATH (default .:~/.freeciv/saves)
* FREECIV_SCENARIO_PATH (default
.:data/scenario:~/.freeciv/scenarios:$datadir/freeciv/scenario)

If one of the environment variable is not set, it will use FREECIV_PATH
instead (default .:data:~/.freeciv:~/.freeciv/2.3:$datadir/freeciv). 
Getting the save path or the scenario path from FREECIV_PATH will extend all
dirs with saves, scenario and scenarios suffixes.

Renamed the interface of datafile* to fileinfo*.  Every of this function
takes as first argument get_data_dirs(), get_save_dirs() or
get_scenario_dirs().  Also add constant flag to returned values which
shouldn't be modified or freed.


(file #7163)
___

Additional Item Attachment:

File name: trunk_data_save_scenario_path.diff.bz2 Size:12 KB


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-28 Thread pepeto

Update of bug #14603 (project freeciv):

  Status:   Confirmed = Ready For Test 
 Assigned to:None = pepeto 

___

Follow-up Comment #10:

I think now I have understood what this bug was about.  I attached the fix:
* A dot in the path is not considered as an extension.
* A dot at the start of the filename is not considered as an extension.
* If you give a path without filename (e.g. ~/.freeciv/saves/), the game will
be saved in this path with a generated filename.  The current behaviour is a
failure: cannot save (~/.freeciv/saves/.sav.gz)


(file #7153, file #7154)
___

Additional Item Attachment:

File name: S2_1_save_game.diffSize:2 KB
File name: trunk_S2_2_save_game.diff  Size:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-27 Thread Marko Lindqvist

Follow-up Comment #5, bug #14603 (project freeciv):

 It isn't HOME/.freeciv/saves by default if the server is
 forked from the client

connectdlg_common.c:client_start_server(): 231-232:
  argv[argc++] = --saves;
  argv[argc++] = ~/.freeciv/saves;


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-27 Thread Marko Lindqvist

Follow-up Comment #6, bug #14603 (project freeciv):

 The problem looks like to be something linked with patch #1289.  It
doesn't find the data path saves/ when loading the game
 because it assumes that only ~/.freeciv/2.3/ is a data path.

He was running server separately, so save location should be current
directory, not ~/.freeciv/saves. But you have a valid point about another bug
if saves really have to be under FREECIV_PATH (why would that be)

___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-27 Thread Marko Lindqvist

Follow-up Comment #7, bug #14603 (project freeciv):

I cannot reproduce. Autosaves work both when running server separately
(saving current directory) and when its forked by client (saves to
~/.freeciv/saves).

Are you sure you had write permissions to the directory where you run
civserver?

___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-27 Thread pepeto

Follow-up Comment #8, bug #14603 (project freeciv):

 I cannot reproduce. Autosaves work both when running server
 separately (saving current directory) and when its forked by
 client (saves to ~/.freeciv/saves).

Actually, my game is autosaved in ~/.freeciv/saves/, but I cannot find them
with the gui, because it searches them in ~/.freeciv/2.3/saves/ because of
patch #1289.  And the directory selector doesn't propose hiden directories. 
I open new ticket for this.


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-27 Thread Alvaro Rodriguez

Follow-up Comment #9, bug #14603 (project freeciv):

The problem was related with the fact that i don't have permissions to write
in the directory where i was executing it.

I was waiting to save the game at the same place as when i launch the
client.

I think that is not a critical issue.

i think that the small issue is that I don't understand why it tries to
remove extension, because when i wanted to save the game to:
/home/user/.freeciv/saves it removes what is after the dot and saves the
game in: /home/user/.sav.tgz

___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-25 Thread anonymous

URL:
  http://gna.org/bugs/?14603

 Summary: Error autosaving on trunk revision 16210 over
Ubuntu 9.04
 Project: Freeciv
Submitted by: None
Submitted on: Sunday 10/25/2009 at 14:35 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: alvar...@gmail.com
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: None

___

Details:

Error autosaving files on server.

I updated today the svn and i don't know what was my previous revision but it
was working before.

When server tries to save a file:

 save

Failed saving game as civgame-T026-Y2700BCm.sav.gz

Is only working for absoluth paths without . in the path:

I tried to debug a little but i'm a little bit lost:

* The srvarg.saves_pathname is empty, and i don't know ho to fill it.
* I'm not able to find make_dir function. 
* The search of the dot seems not to be very efficient.

With autosave is not working at all.

Regards.






___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-25 Thread Marko Lindqvist

Follow-up Comment #1, bug #14603 (project freeciv):

You are running server separately and not forked it from client, right?

 # The srvarg.saves_pathname is empty, and i don't know ho to
 fill it.

It comes from command line. This is mainly used by client that forks its own
server, and in that case value would be HOME/.freeciv/saves

 # I'm not able to find make_dir function.

utility/shared.c


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-25 Thread pepeto

Update of bug #14603 (project freeciv):

  Status:None = Confirmed  

___

Follow-up Comment #2:

I have the same problem.  It isn't  HOME/.freeciv/saves by default if the
server is forked from the client neither the server is launched separately.


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-25 Thread pepeto

Follow-up Comment #3, bug #14603 (project freeciv):

The problem looks like to be something linked with patch #1289.  It doesn't
find the data path saves/ when loading the game because it assumes that
only ~/.freeciv/2.3/ is a data path.

So would we need to add ~/.freeciv/ in the possible data pathes or pass to
the server --saves ~/.freeciv/2.3/saves --scenarios
~/.freeciv/2.3/scenarios?


___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14603] Error autosaving on trunk revision 16210 over Ubuntu 9.04

2009-10-25 Thread Alvaro Rodriguez

Follow-up Comment #4, bug #14603 (project freeciv):

Yes, i was running server separately.

The other problems is how the save_game look for the dot. I wasn't able to
save the gane in /home/user/.freeciv/saves.



___

Reply to this item at:

  http://gna.org/bugs/?14603

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev