[Freeciv-Dev] [bug #16411] Global warming nuclear winter may change a tile multiple times
Update of bug #16411 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16411 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16411] Global warming nuclear winter may change a tile multiple times
Update of bug #16411 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.1.12, 2.2.3, 2.3.0 ___ Follow-up Comment #1: Fixes attached. (file #9817, file #9818, file #9819) ___ Additional Item Attachment: File name: trunk_gw_nw_tile_only_once.diff Size:1 KB File name: S2_2_gw_nw_tile_only_once.diff Size:1 KB File name: S2_1_gw_nw_tile_only_once.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16411 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16411] Global warming nuclear winter may change a tile multiple times
Follow-up Comment #2, bug #16411 (project freeciv): Attached compilable fix for S2_1. (file #9820) ___ Additional Item Attachment: File name: S2_1_gw_nw_tile_only_once2.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16411 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16411] Global warming nuclear winter may change a tile multiple times
URL:
http://gna.org/bugs/?16411
Summary: Global warming nuclear winter may change a tile
multiple times
Project: Freeciv
Submitted by: handuman
Submitted on: Thursday 08/12/10 at 16:24
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.2.2
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
This is not a problem with default ruleset but a custom ruleset may have
sequental definitions for warmer_wetter_result (as well the three other
_results). The randomly chosen tile in
void global_warming(int effect) and
void nuclear_winter(int effect) (in maphand.c)
might hit one tile several times during one disaster resulting in unexpected
change of terrain.
For example, with following definitions
[terrain_plains]
warmer_wetter_result = terrain_swamp
...
[terrain_swamp]
warmer_wetter_result = terrain_ocean
a plains tile might collapse into ocean in just one occurrence of global
warming.
Also, the code seems to have been written assuming that the random tile
picker never hits twice on the same tile since the iteration is stopped after
{total number of tiles on the map} times.
___
Reply to this item at:
http://gna.org/bugs/?16411
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
