[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

[pepeto]

Update of bug #16491 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

[George Koehler]

Follow-up Comment #3, bug #16491 (project freeciv):

Your patch (file #9933) fixes the map editor. I watched as the AI players
killed most of the Prussian Warriors, without crashing the server.

I will discuss the Longturn bug at its page. You found the page at
http://redmine.pagema.net/issues/96

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

[pepeto]

Update of bug #16491 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Assigned to:None => pepeto 

___

Follow-up Comment #2:

Fix attached.

PS: It would also fix the issues for Longturn.


(file #9933)
___

Additional Item Attachment:

File name: S2_2_reset_player_shared_info.diff Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

[pepeto]

Update of bug #16491 (project freeciv):

  Status:None => Confirmed  
 Planned Release: => 2.2.3  

___

Follow-up Comment #1:

Thank you for the informations. It is really easier to debug. It doesn't look
like to make problems in trunk.

PS: Is this bug fixed in Longturn? Is there a mean to access the bug report
and the patch applied?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

[George Koehler]

URL:
  

 Summary: assertion fails in make_contact(), after using
editor
 Project: Freeciv
Submitted by: kernigh
Submitted on: Friday 08/20/2010 at 00:36
Category: editor
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_2
 Discussion Lock: Any
Operating System: *BSD
 Planned Release: 

___

Details:


> assertion "pplayer_get_diplstate(pplayer2, pplayer1)->type !=
DS_NO_CONTACT" failed: file "../../server/plrhand.c", line 1169, function
"make_contact"
Abort trap (core dumped)


I am running S2_2 r17795.

This sometimes happens after using the editor to remove a player and then
create a new player (in the same slot). The new player inherits some
diplomacy stuff (like embassies) from the old player. This seems to create an
inconsistency where the new player has "never met" the other players, but the
other players have already met the new player. This inconsistency can abort
the server in make_contact() at plrhand.c:1169.

Steps to reproduce:
0 Load attached game *fall-of-armenia-turn246.sav.bz2*.
0 Take Armenians, start game.
0 Disband last unit in last city.
0 Click "Turn Done". RIP Armenia.
0 Enable the editing mode.
0 Switch from Armenia to "Global Observer".
0 Open dialog to edit players.
0 Destroy Armenia.
0 Create new player. (I will call Prussia.)
0 Close dialog.
0 Select new unit, Warriors, Prussia.
0 Place some Prussian Warriors, near but not adjacent to existing cities and
warriors.
0 Switch from "Global Observer" to Prussia.
0 Disable the editing mode.
0 Click "Turn Done". Assertion fails, server aborts.

The other attached game *rise-of-prussia-turn247.sav.bz2* is from after
placing those Prussian Warriors but before clicking "Turn Done".

This bug is similar to bug #96  of
Longturn , where the same assertion fails. The
difference is that I am now crashing the vanilla S2_2 server instead of the
modified Longturn server, by using the map editor instead of LTeX newcomers.



___

File Attachments:


---
Date: Friday 08/20/2010 at 00:36  Name: fall-of-armenia-turn246.sav.bz2 
Size: 56kB   By: kernigh
save files from before and after usage of editor

---
Date: Friday 08/20/2010 at 00:36  Name: rise-of-prussia-turn247.sav.bz2 
Size: 54kB   By: kernigh
save files from before and after usage of editor


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev