[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Update of bug #16566 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Update of bug #16566 (project freeciv): Severity: 2 - Minor = 3 - Normal Status:None = Ready For Test ___ Follow-up Comment #7: Just occurred to me that this has another problem even with default ruleset. It says Build Fortress even when it actually results in Build Buoy (or even mixed set of bases if several units were selected). Attached patch makes them Build Type A Base and Build Type B Base. (file #13230) ___ Additional Item Attachment: File name: BasebuildMenu_16566.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Follow-up Comment #8, bug #16566 (project freeciv): Opened separate ticket, patch #2721, about making these ruleset definable in the future as suggested in comment #3 ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Follow-up Comment #9, bug #16566 (project freeciv): TRUNK version that takes care of gtk3-client also. (file #13235) ___ Additional Item Attachment: File name: BasebuildMenu_16566-TRUNK.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Update of bug #16566 (project freeciv): Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #6: Could we reveal the fact that division of bases to these two types model nothing in their properties to the UI? Can we just refer to them as Type A / Type B? - Base quick select 1 / Base quick select 2 - Base 1 / Base 2 - Type A base / Type B base Then we have to open another ticket about how client should display somewhere what category (A/B or 1/2) each base belongs to. It's not that obvious that one should press 'f', and not 'e', to build Buoy. ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Follow-up Comment #5, bug #16566 (project freeciv): For the record, there is two bases with gui type Fortress in default, multiplayer and experimental rulesets: Fortress and Buoy. They have one gui type Airbase base: Airbase ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Follow-up Comment #4, bug #16566 (project freeciv): So perhaps we could allow rulesets to specify the menu text to be displayed for the GUI types? But I still don't know what I'd call them in the default ruleset. That sounds quite good solution for trunk, but S2_3 is in datafile format freeze. ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Follow-up Comment #3, bug #16566 (project freeciv): It's not ideal. I think the menus should dynamically adapt where possible, so that when only one F-like or E-like base is possible for the selected units, the menu attaches the shortcut directly to that base type (as for the irrigate and mine actions on the Work menu when those actions lead to terrain conversion). However, we would still need fallback names for non-default rulesets where more than one kind of F-like or E-like base is possible for a single unit, or for when multiple units on different tiles are selected. I don't have any better ideas than your names. I think the problem stems from the fact that fortress and airbase don't represent two fundamentally different kinds of base, they just happen to be the two historic bases, so for new bases there's no clear answer as to whether they're fortress-like or airbase-like; if you were designing a ruleset I think you'd use the two classes to minimise the proportion of the time when the user couldn't select a base with a keyboard shortcut, without thinking about whether your bases fall into two basic types. (So perhaps we could allow rulesets to specify the menu text to be displayed for the GUI types? But I still don't know what I'd call them in the default ruleset.) ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Follow-up Comment #2, bug #16566 (project freeciv): Would it be understandable if those main level entries were Build Fortress-like and Build Airbase-like? ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Update of bug #16566 (project freeciv): Summary: Combat menu for workers = Duplicate base building actions on combat menu for workers ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
