[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Matthias Pfafferodt]

Update of bug #17110 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Matthias Pfafferodt]

Follow-up Comment #6, bug #17110 (project freeciv):

The size is not hard coded. The size of the array is dynamically adapted
depending on the number of images per city style. 250 is the greates number
freeciv will check for. I think such a limit should be there to get a sane
environment.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Goswin von Brederlow]

Follow-up Comment #5, bug #17110 (project freeciv):

Why? Resize the array as needed. If you hardcode the size then you will
always have either way to many entries or not enough.

I can also think of having a lot more images than 4 (or actually 8 with city
walls). For example risk of pollution can add a smoke cloud (0-4 none, 5-9
light, 10+ heavy) over the city and risk of plague a red cross (0-4 none, 5-9
small, 10+ large). That would require 72 images.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Matthias Pfafferodt]

Follow-up Comment #4, bug #17110 (project freeciv):

> With images being an rffect it makes no sense to limit the
> number of image by the size of a city. They are really
> independent. 

That's right - but a limit is needed. And I don't think that there will be
much more images than the current 4 for each city style ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Goswin von Brederlow]

Follow-up Comment #3, bug #17110 (project freeciv):

> You could simply change the number at the end of the description
> tag (city.electricage_city_4 => city.electricage_city_3).

The city radius, except for the first step, is changed by other things than
just size so this won't work. But I see you have already wrote a patch to
make city images an effect too.

One thing though:

+; The maximum number of images is only limited by the maximum size of a
city
+; (currently MAX_CITY_SIZE = 250). The constant is defined in
common/city.h.

With images being an rffect it makes no sense to limit the number of image by
the size of a city. They are really independent.

MfG
   Goswin


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Matthias Pfafferodt]

Update of bug #17110 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => syntron
 Planned Release: => 2.4.0  

___

Follow-up Comment #2:

Here is a patch for 2.4.0

configure the city images via the effects system

* [TODO] wiki => effect EFT_CITY_IMAGES
* [TODO] wiki => How to tilesets 2.3.x => 2.4.x
* [TODO] what spec should be defined for 2.4.x tilesets?

(file #11299)
___

Additional Item Attachment:

File name:
20101120-trunk-configure-the-city-images-via-the-effects-system.patch Size:42
KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[pepeto]

Update of bug #17110 (project freeciv):

Priority:  5 - Normal => 1 - Later  


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Matthias Pfafferodt]

Follow-up Comment #1, bug #17110 (project freeciv):

The size for the next city image are hardcoded (see for example
./data/amplio/moderncities.spec):

 2,  0, "city.electricage_city_0"
 2,  1, "city.electricage_city_4"
 2,  2, "city.electricage_city_8"
 2,  3, "city.electricage_city_12"
 2,  4, "city.electricage_city_16" 
 2,  5, "city.electricage_wall_0"
 2,  6, "city.electricage_wall_4"
 2,  7, "city.electricage_wall_8"
 2,  8, "city.electricage_wall_12"
 2,  9, "city.electricage_wall_16" 

You could simply change the number at the end of the description tag
(city.electricage_city_4 => city.electricage_city_3).

Something nice would be the possibility to change this in the ruleset ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17110] Synchronize images for city with city radius

[Goswin von Brederlow]

URL:
  

 Summary: Synchronize images for city with city radius
 Project: Freeciv
Submitted by: mrvn
Submitted on: Saturday 11/20/2010 at 03:14
Category: client
Severity: 1 - Wish
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There are images for cities of different size so bigger cities do look bigger
on the map. Currenty the first change happens with size 4. The city radius on
the other hand grows with size 3 (at least in my ruleset).

I think it would be nice if the image for a city would change based on city
radius instead of city size when the ruleset has variable city radii.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev