[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Follow-up Comment #6, bug #17334 (project freeciv): Rather late to comment, but: Quick: remove the survives flag and instead set the SaveSmallWonder flag for the Apollo Program, which will have much the same effect. (The latter will only make a difference once bug #17333 is fixed) SaveSmallWonder moves wonder to another city of the same player. If that player is completely wiped out, it's gone for good. But (prior to this change) the effect of the Apollo Program in the multiplayer ruleset was player-ranged -- everyone had to build their own Apollo before they could start their spaceship -- so it doesn't matter if a player's Apollo is lost when they die -- everyone else still has their Apollo? Unless I've missed something, for player-ranged effects, I think SaveSmallWonder is equivalent to survives. (Not that we shouldn't fix bug #17334 anyway.) ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Update of bug #17334 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Follow-up Comment #4, bug #17334 (project freeciv): - Make effect to work in World range instead of Player as that's the core problem (file #11993) ___ Additional Item Attachment: File name: ApolloGreatWonder_17334-3.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Follow-up Comment #3, bug #17334 (project freeciv): Attached a slightly tweaked version of the patch whose strings are aligned with the default ruleset as much as possible, to reduce the number of translations required. (file #11918) ___ Additional Item Attachment: File name: ApolloGreatWonder_17334_bis.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Follow-up Comment #1, bug #17334 (project freeciv): Quick: remove the survives flag and instead set the SaveSmallWonder flag for the Apollo Program, which will have much the same effect. (The latter will only make a difference once bug #17333 is fixed) SaveSmallWonder moves wonder to another city of the same player. If that player is completely wiped out, it's gone for good. For 2.3 I would take simple route of reverting to Great Wonder. For 2.4 surviving small wonders should be supported. ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Follow-up Comment #2, bug #17334 (project freeciv): Opened bug #17463 for 2.4 implementation. This ticket is reserved for 2.3 fix, which is attached. (file #11800) ___ Additional Item Attachment: File name: ApolloGreatWonder_17334.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
Update of bug #17334 (project freeciv): Status:None = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?17334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17334] Multiplayer ruleset: Apollo Program / space race broken
URL:
http://gna.org/bugs/?17334
Summary: Multiplayer ruleset: Apollo Program / space race
broken
Project: Freeciv
Submitted by: jtn
Submitted on: Fri Dec 17 01:34:11 2010
Category: rulesets
Severity: 4 - Important
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.3.0-beta1
Discussion Lock: Any
Operating System: None
Planned Release: 2.3.0
___
Details:
In the rewonder thread
http://forum.freeciv.org/viewtopic.php?t=5815postdays=0postorder=ascstart=0,
cazfi reported
http://forum.freeciv.org/viewtopic.php?t=5815postdays=0postorder=ascstart=30#24404
the following error in server logs:
1: Surviving requirements are only supported at world range.
and Munk reported that the Apollo Program didn't work.
The cause is the fact that the Apollo Program is a small wonder with a
surviving effect at player range:
[effect_apollo_program]
name= Enable_Space
value = 1
reqs=
{ type, name, range, survives
Building, Apollo Program, Player, 1
}
This causes the error message mentioned, and the effect is entirely ignored,
so no-one will ever be able to build spaceships.
For Longturn, this was apparently fixed
http://forum.freeciv.org/viewtopic.php?t=5815postdays=0postorder=ascstart=45#24759
by reverting the Apollo Program back to being a Great Wonder with global
range, as in the default ruleset.
The 'multiplayer' ruleset in 2.3.x has inherited this problem. There are a
couple of ways we could fix it without reverting to a great wonder:
* Quick: remove the survives flag and instead set the SaveSmallWonder
flag for the Apollo Program, which will have much the same effect. (The latter
will only make a difference once bug #17333 is fixed)
* As suggested by vasc
http://forum.freeciv.org/viewtopic.php?t=5815postdays=0postorder=ascstart=45#24901,
extend the code to allow surviving small wonder with player range, using the
per-player wonder cache. Will require extending that cache to record an
equivalent of WONDER_DESTROYED.
___
File Attachments:
---
Date: Fri Dec 17 01:34:11 2010 Name: apollo_broken.sav.bz2 Size: 9kB By:
jtn
Trunk savegame: cannot build spaceship parts despite all requirements
apparently being fulfilled
http://gna.org/bugs/download.php?file_id=11604
___
Reply to this item at:
http://gna.org/bugs/?17334
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
