[Freeciv-Dev] [bug #20541] in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed

2013-03-25 Thread Jacob Nevins 
Update of bug #20541 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 
Operating System:None => Any


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20541] in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed

2013-03-23 Thread Jacob Nevins 
Update of bug #20541 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => jtn
 Planned Release: => 2.5.0  

___

Follow-up Comment #2:

The problem is that the nationality happiness calculation added in patch #3628
does not preserve the number of citizens in cases of extreme unhappiness.
On the turn after this savegame (file #17282), pirates take over Westminster;
if you then look at its Happiness tab in the client, you can see that from
Nationality onwards, there are more citizens shown than there really are in
the city.
This can also been seen with Linz in file #17386 (immediately on load -- it
has recently been taken over).

The accounting in citizen_happiness_nationality() seems incomplete. Attached
patch copies the logic from citizen_happy_units(): "First make content =>
unhappy, then happy => unhappy, then happy => content."
It also has the same property of not creating angry citizens (notwithstanding
the comment /* FIXME: Why not? - Per */).

Is that the behaviour we want for nationality?

(file #17524)
___

Additional Item Attachment:

File name: trunk-nationality-unhappiness-accounting.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20541] in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed

2013-03-08 Thread Marko Lindqvist 
Follow-up Comment #1, bug #20541 (project freeciv):

I'm not entirely sure, but it seems a bit that cma now (after patch #3620)
gives results where some people are specialists of currently unavailable type.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20541] in auto_arrange_workers() [cityturn.c::397]: assertion 'city_size_get(pcity) - spe == sum' failed

2013-02-20 Thread pepeto 
URL:
  

 Summary: in auto_arrange_workers() [cityturn.c::397]:
assertion 'city_size_get(pcity) - spe == sum' failed
 Project: Freeciv
Submitted by: pepeto
Submitted on: mer. 20 févr. 2013 15:51:59 CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r22403
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Autogame with ruleset "experimental", lot of assertion failures like:

1: [T068 - 2013/02/20 15:18:56] in auto_arrange_workers() [cityturn.c::397]:
assertion 'city_size_get(pcity) - spe == sum' failed.
1: [T068 - 2013/02/20 15:18:56] in auto_arrange_workers() [cityturn.c::397]: (
 38,   47) in "Westminster"[4]


Attached previous turn savegame.




___

File Attachments:


---
Date: mer. 20 févr. 2013 15:51:59 CET  Name: freeciv-T0067-Y-0825-auto.sav.gz
 Size: 65 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev