[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Update of bug #21696 (project freeciv): Open/Closed:Open = Closed ___ Follow-up Comment #12: I check the changes between the last working version and the build with th error. Only this change was a possible source. Using the new ticket is OK. I will close this one (again). ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #8, bug #21696 (project freeciv): this patch breaks all builds using system lua libraries (--enable-sys-lua); see the rpm builds at https://build.opensuse.org/project/monitor/home:syntron:freeciv ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Update of bug #21696 (project freeciv): Open/Closed: Closed = Open ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #9, bug #21696 (project freeciv): this patch breaks all builds using system lua libraries (--enable-sys-lua) Intresting. The errors in your log are about luasql, not lua, so why is --enable-sys-lua relevant here? Are you sure it is? Anyway, I cannot reproduce in TRUNK (where --enable-sys-lua is the default). ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #10, bug #21696 (project freeciv): I can see how your --enable-fcdb=all could be relevant, as configure.ac then sets all the alternative libs to LUASQL_LIBS, with partly same content. What I don't get is why it would work any more when the linking was made directly to executable. Anyway, I think this should be a new ticket rather than reusing this old one. ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #11, bug #21696 (project freeciv): --enable-fcdb=all ... sets all the alternative libs to LUASQL_LIBS, with partly same content. - bug #21897 ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Update of bug #21696 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Update of bug #21696 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #4: Not only freeciv-server/libfreeciv-srv issue, but lua libraries should be added to correct libraries, and not executables, in general. ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Update of bug #21696 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: LuaSrvLib-2.patch Size:5 KB File name: LuaSrvLib-S2_5-2.patch Size:4 KB File name: LuaSrvLib-S2_4-2.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Update of bug #21696 (project freeciv): Status:None = Ready For Test Planned Release: = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #3: Sorry, I had misread your original report. Patches attached. (file #20353, file #20354) ___ Additional Item Attachment: File name: LuaSrvLib.patchSize:0 KB File name: LuaSrvLib-S2_4.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #2, bug #21696 (project freeciv): I am using the in-tree liblua: Makefile:LUA_CFLAGS = -I$(top_srcdir)/dependencies/lua-5.1/src Makefile:LUA_LIBS = $(top_builddir)/dependencies/lua-5.1/src/liblua.la Makefile:TOLUA = $(top_builddir)/dependencies/tolua-5.1/src/bin/tolua Makefile:TOLUA_CFLAGS = -I$(top_srcdir)/dependencies/tolua-5.1/include Makefile:TOLUA_LIBS = $(top_builddir)/dependencies/tolua-5.1/src/lib/libtolua.la Using the system shouldn't make a difference: it isn't the contents of those variables which is the issue. It is that it is the library libfreeciv-srv which depends on lua. The binary freeciv-server only depends on lua via the library. (At least, that must be true given the fix!) ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
URL: http://gna.org/bugs/?21696 Summary: [patch] build fix: libfreeciv-srv.la depends on lua libraries Project: Freeciv Submitted by: prlw1 Submitted on: Thu 20 Feb 2014 12:46:39 AM UTC Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.4.2 Discussion Lock: Any Operating System: None Planned Release: ___ Details: The problem still exists in trunk (revision 24142) from code inspection. Compiling with recent libtool: CCLD libfreeciv-srv.la CCLD freeciv-server ./.libs/libfreeciv-srv.so: undefined reference to `tolua_tousertype' ../common/.libs/libfreeciv.so: undefined reference to `luaopen_table' ... It is libfreeciv.so which depends on the lua libraries rather than freeciv_server. The following patch against 2.4.2 fixes things for me: --- server/Makefile.am.orig 2014-02-08 13:17:47.0 + +++ server/Makefile.am @@ -133,6 +133,7 @@ srvlibs = \ $(top_builddir)/server/scripting/libscripting_server.la libfreeciv_srv_la_LIBADD = \ + $(LUA_LIBS) $(TOLUA_LIBS) $(LUASQL_LIBS) \ $(srvlibs) freeciv_server_LDFLAGS = $(GGZDMOD_LDFLAGS) @@ -140,7 +141,6 @@ freeciv_server_LDFLAGS = $(GGZDMOD_LDFLA freeciv_server_LDADD = \ ./libfreeciv-srv.la \ $(top_builddir)/common/libfreeciv.la \ - $(LUA_LIBS) $(TOLUA_LIBS) $(LUASQL_LIBS) \ $(INTLLIBS) \ $(MAPIMG_WAND_LIBS) \ $(FCDB_MYSQL_LIBS) $(FCDB_POSTGRES_LIBS) $(FCDB_SQLITE3_LIBS) \ ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries
Follow-up Comment #1, bug #21696 (project freeciv): Just to be sure: you use liblua built from freeciv tree (the default in 2.4), and not external library with --enable-sys-lua. That *might* make important difference to what is in $(LUA_LIBS), meaning that more involved patch will be needed. Also, could you attach your patches as files, and not inline in the message body in the future (especially given how gna reformats messages so that some pointer magic may turn out as bold text instead) ___ Reply to this item at: http://gna.org/bugs/?21696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
