[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Update of bug #22782 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #9, bug #22782 (project freeciv): I think we should revert my change for bug #22474 in the S2_4 branch. Attached S2_4 patch does this. (file #22899) ___ Additional Item Attachment: File name: S2_4-multiplayer-philo-revert.patch Size:6 KB ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #10, bug #22782 (project freeciv): I've just realised a less awful way to fix this might have been to add something to the tech_researched signal distinguishing the signal for primary player from teammates -- either an extra parameter, or a suffix on the reason string like (team). (Although this wouldn't work on trunk where the concept of primary player no longer reliably exists.) But I've tested this one now, so oh well. ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #11, bug #22782 (project freeciv): Fix the inevitable warning from make freeciv.pot. (file #22900) ___ Additional Item Attachment: File name: trunk-S2_5-multiplayer-philo-bis.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Update of bug #22782 (project freeciv): Status:None = In Progress Assigned to:None = jtn Planned Release: 2.4.4, 2.5.0, 2.6.0 = 2.4.4, 2.5.0-beta2, 2.6.0 ___ Follow-up Comment #7: After reflexion, I think we should revert my change for bug #22474 in the S2_4 branch. No user has complained about this bug. Sounds good -- I'll assume we're doing that. Attached a WIP patch for trunk building on patch #5408. Seems to basically work with file #22602 but I've not yet thoroughly tested all corner cases. (file #22849) ___ Additional Item Attachment: File name: trunk-multiplayer-philo-wip.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #6, bug #22782 (project freeciv): After reflexion, I think we should revert my change for bug #22474 in the S2_4 branch. No user has complained about this bug. Worse, it may break another user scripts in the middle of the stable cycle. ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Update of bug #22782 (project freeciv): Depends on: = patch #5408 ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #5, bug #22782 (project freeciv): Even with a shares_research() Lua function (patch #5408) this is going to be slightly fiddly, as Lua needs to track a list of players, and Lua tables aren't included in the savegame. Going to have to use a string or something annoying like that. ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #4, bug #22782 (project freeciv): For S2_5, I think the least worst solution is a late addition to the scripting API (for beta2). I'm going to assume that's OK and do it unless anyone else gets there first. For S2_4 it's not ideal to add a script function to a stable branch, but I don't think ruleset Lua script compatibility with old rulesets is utterly critical. It's that or declare it as a known issue; I don't really want to revert any of pepeto's tech improvements for the sake of the multiplayer ruleset (which isn't used that much?) ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #2, bug #22782 (project freeciv): Darwin's voyage has the opposite effect on shared techs: It will only work for one of the players that share tech. ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
URL: http://gna.org/bugs/?22782 Summary: multiplayer ruleset: Philosophy gives number of techs equal to team size Project: Freeciv Submitted by: jtn Submitted on: Sat 11 Oct 2014 15:42:19 BST Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.4, 2.5.0, 2.6.0 ___ Details: A side effect of bug #22474 being fixed is that in the multiplayer ruleset, which uses Lua scripting to give every player a free tech when they reach philosophy, if team_pooled_research is enabled the team gets a number of techs equal to the size of their team. I think the team should only get one tech in this case. ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22782] multiplayer ruleset: Philosophy gives number of techs equal to team size
Follow-up Comment #1, bug #22782 (project freeciv): Attached savefile (for S2_5) demonstrates this. Hit Turn Done a couple of times. (It's not entirely obvious due to bug #22783, so check the science report before and after.) (file #22602) ___ Additional Item Attachment: File name: 25_multiplayer_team_philo.sav.bz2 Size:18 KB ___ Reply to this item at: http://gna.org/bugs/?22782 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
