[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Jacob Nevins]

Follow-up Comment #11, bug #23911 (project freeciv):

> remove the hopelessly broken feature of trying to turn "disband" > into
"help wonder" for some units
For the record: this behaviour had been present since at least 2004 (r9094
, PR#3989). (I
also support removing it rather than fixing it.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Marko Lindqvist]

Update of bug #23911 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Marko Lindqvist]

Update of bug #23911 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #7:

> I would now just remove the hopelessly broken feature of trying to turn
"disband" into "help wonder" for some units.

Patches for that

(file #28795, file #28796, file #28797)
___

Additional Item Attachment:

File name: DisableNotHelpWonder.patch Size:1 KB
File name: DisableNotHelpWonder-S2_6.patch Size:1 KB
File name: DisableNotHelpWonder-S2_5.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Sveinung Kvilhaugsvik]

Follow-up Comment #6, bug #23911 (project freeciv):

> remove the hopelessly broken feature of trying to turn "disband" into "help
wonder" for some units. Probably do the same even in TRUNK

The benefit of removing this feature is simpler and more correct code. The
price is changing production to something that can receive "Help Wonder"
(100%) after doing "Recycle Unit" (50%) with a unit that could have done "Help
Wonder" to the new production will lose 50% of the shields compared to doing
it in the opposite order. (I assume that doing "Help Wonder" and then changing
to something that can't receive "Help Wonder" won't be exploitable) I think
the price is worth the cost.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Marko Lindqvist]

Follow-up Comment #4, bug #23911 (project freeciv):

The when-can and how-much-gives values of disbanding (and other
unit-destroying activities) are getting more complex. Maybe in 3.1 we get
rules with increased granularity (from unit/building/wonder) and current
method of maintaining shield stock during the mid-turn production changes
turns impossible. Best solution I see at that point would be turning disband
to an activity that takes one turn - actual disband happening at the turn end
when final production choice for the turn is known.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Marko Lindqvist]

Update of bug #23911 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: 2.5.x, 2.6.0, 3.0.0 => 2.5.6, 2.6.0, 3.0.0

___

Follow-up Comment #3:

S2_5 patch to test.

TRUNK ... I don't understand. It's adding only disband bonus to shield stock,
but full help wonder bonus to caravan shield stock. It can't do sensible math
with these as production changes (how does it know what part of the help
wonder bonus is already applied to the shield stock in the form of disband
bonus?)
S2_6 I have not even looked, assuming it uses same action enablers related
code as TRUNK.

(file #28780)
___

Additional Item Attachment:

File name: AlliedCaravanDisband-S2_5.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, bug #23911 (project freeciv):

> Disband gives only 50% of the shields,
Not if you follow the procedure below. It will give you 100% of the shields.
(Unless it has changed since I filed this bug)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Marko Lindqvist]

Follow-up Comment #1, bug #23911 (project freeciv):

Disband gives only 50% of the shields, so it's not same as Help Wonder. So
it's only correct that restrictions to Help Wonder do not apply to a caravan
(and only caravan?) doing disband.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Jacob Nevins]

Update of bug #23911 (project freeciv):

 Planned Release: => 2.5.x, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Disband can bypass non domestic help wonder
restrictions
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 28 Sep 2015 02:01:22 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: TRUNK, 2.6, 2.5.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

A rule can forbid doing "Help Wonder" to foreign cities. In 2.5 this rule is
hard coded. In 2.6 and 3.0 it depends on the ruleset. This rule can be
bypassed by using disband unit.

Step 1: Move the caravan to an allied city.
Step 2: Do disband.
Step 3: Have the allied city change production to something that can receive
caravan shields.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev