[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Update of patch #1356 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Follow-up Comment #5, patch #1356 (project freeciv): There should be a hint, that E_LAST should be used as the last element of the list (the number needs to be updated). Would it be possible to add SPECENUM_LAST to generate_specenum.py? ___ Reply to this item at: http://gna.org/patch/?1356 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Follow-up Comment #6, patch #1356 (project freeciv): There should be a hint, that E_LAST should be used as the last element of the list (the number needs to be updated). Would it be possible to add SPECENUM_LAST to generate_specenum.py? Maybe there is an other way using event_type_max(), even for static arrays. I don't know if using the 'const' attribute would work in this case. But anyway, this should be a part of another ticket. After this one, we would be also able to make a new orders for the events. ___ Reply to this item at: http://gna.org/patch/?1356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Update of patch #1356 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #3: Patch updated against current svn. ___ Reply to this item at: http://gna.org/patch/?1356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Additional Item Attachment, patch #1356 (project freeciv): File name: trunk_S2_2_event_type_specenum.diff Size:14 KB ___ Reply to this item at: http://gna.org/patch/?1356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Follow-up Comment #4, patch #1356 (project freeciv): Attaching the right patch. (file #7235) ___ Additional Item Attachment: File name: trunk_S2_2_event_type_specenum.diff Size:12 KB ___ Reply to this item at: http://gna.org/patch/?1356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Follow-up Comment #2, patch #1356 (project freeciv): Why did you add those useless prototypes? I think every static function should be announced at the top of the *.c file? You also should use secfile_lookup_str_int(). see comment to patch #1355 Global headers like assert.h are usually included before freeciv ones like support.h (see in generate_specenum.h) will change this ... This comment looks superfluous to me... One can change that data without changing this comment... Anyway, if the this setting was too low, then the last enumerators wouldn't be declared and the compilation would fail. The comment should be included to give a hint there to search for the case of the error. The current number could be removed. ___ Reply to this item at: http://gna.org/patch/?1356 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
URL: http://gna.org/patch/?1356 Summary: use specnum.h for the event types Project: Freeciv Submitted by: syntron Submitted on: Samstag 31.10.2009 um 23:36 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.2.0 ___ Details: * increase the number of elements to 125 * update the format of the .civclientrc file * backwards compatible (can load old files) ___ File Attachments: --- Date: Samstag 31.10.2009 um 23:36 Name: event_cache-20091031-2-0002-use-specnum.h-for-the-event-types.diff Size: 13kB By: syntron http://gna.org/patch/download.php?file_id=7188 ___ Reply to this item at: http://gna.org/patch/?1356 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1356] use specnum.h for the event types
Update of patch #1356 (project freeciv): Status:None = In Progress Assigned to:None = pepeto ___ Follow-up Comment #1: Why did you add those useless prototypes? You also should use secfile_lookup_str_int(). Global headers like assert.h are usually included before freeciv ones like support.h (see in generate_specenum.h) /* the maximum number of enumerators is set in generate_specnum.py * at the moment it is set to 125 */ This comment looks superfluous to me... One can change that data without changing this comment... Anyway, if the this setting was too low, then the last enumerators wouldn't be declared and the compilation would fail. ___ Reply to this item at: http://gna.org/patch/?1356 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
