[Freeciv-Dev] [patch #3332] Negated requirements_vector

[Jacob Nevins]

Update of patch #3332 (project freeciv):

  Status:None => Wont Do
 Open/Closed:Open => Closed 

___

Follow-up Comment #6:

Closing as requested.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3332] Negated requirements_vector

[J. M. Gorbach]

Follow-up Comment #5, patch #3332 (project freeciv):

I agree with bug #20695 and I ask to close this patch, because it's pointless.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3332] Negated requirements_vector

[Emmet Hikory]

Follow-up Comment #4, patch #3332 (project freeciv):

For completeness, although I am not in favor of nreqs{} support everywhere, I
prepared a patch with similar effect (and entirely different implementation)
as part of discussion in patch #3879.  While I don't know I will be proposing
that for inclusion, I thought that folk following here might find the
implementation interesting.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3332] Negated requirements_vector

[Emmet Hikory]

Follow-up Comment #3, patch #3332 (project freeciv):

Is this still needed?  Can one use the "negated" value in reqs{} vectors to
meet the original intent of this patch?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3332] Negated requirements_vector

[J. M. Gorbach]

Follow-up Comment #2, patch #3332 (project freeciv):

> Could you provide examples why you want the nreqs for each object type?

Yes, I can, but only one object type: building, see patch #1341.

Base, cities, government, road, nation and specialist are useless. I waste my
time, but see gmake without error is good.

Maybe for nation bug #18358, but I am not sure.






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3332] Negated requirements_vector

[Marko Lindqvist]

Follow-up Comment #1, patch #3332 (project freeciv):

I haven't checked the patch yet, but some comments:
- I'm for adding nreqs to at least some things provided it's not breaking AI
too much
- To get it compile you certainly have been forced to take care of most parts
of the code needing update. One thing that is possible to miss is ruleset
sanity checking code in ruleset.c (should do reqs&nreqs consistency checking)
- Could you provide examples why you want the nreqs for each object type?
- I'm less inclined to add nreqs for object types where there might be
confusion how they work (having nreqs does not prevent bases & roads to exist
in tiles with nreqqed properties...)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3332] Negated requirements_vector

[J. M. Gorbach]

URL:
  

 Summary: Negated requirements_vector
 Project: Freeciv
Submitted by: gorb
Submitted on: Mon 18 Jun 2012 06:41:10 PM GMT
Category: rulesets
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Add 'requirement_vector nreqs':

* Base
* Cities
* Government
* Building
* Road
* Specialist

Gmake is OK: no warnings and no errors.

Add 'requirement_vector reqs';
Add 'requirement_vector nreqs':

* Nation

Gmake is OK: no warning and no error.



___

File Attachments:


---
Date: Mon 18 Jun 2012 06:41:10 PM GMT  Name:
trunk-rev21330_bcsrgb_requirement_nreqs.diff  Size: 17kB   By: gorb


---
Date: Mon 18 Jun 2012 06:41:10 PM GMT  Name:
trunk-rev21330_nations_reqs_nreqs.diff  Size: 4kB   By: gorb



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev