[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset

[Sveinung Kvilhaugsvik]

Update of patch #4671 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #12:

Looks like I forgot to thank the reviewers in the commit message. Sorry about
that.

-

_I have read the entire thread (which took me a long time because of my poor
English)._
Thank you. You don't have to read this reply unless you are interested in
hearing the answers to your questions.

_I suggest that "Attack", "Help Wonder", "Establish Trade Route" (and maybe
some other) should use the action enablers._
This patch is a step in that direction. It moves a difference between spy
actions and "Establish Trade Route" to the rule set.

_If writing such conditions using the requirement syntax, why not using some
magic lua function?_
The requirement system is declarative. That makes it easy to reason about the
rules for programs (3rd party AI's, our help system, etc). The requirement
system is also accessible to ruleset authors that don't want to code.

When that is said: I have heard talk about making a requirement type that is
controlled by Lua so those that need the extra complexity can have it
everywhere requirements are accepted.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset

[Sveinung Kvilhaugsvik]

Update of patch #4671 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #10:

Works when patch #5020 is applied

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset

[Sveinung Kvilhaugsvik]

Update of patch #4671 (project freeciv):

  Depends on: => patch #5020


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset

[Sveinung Kvilhaugsvik]

Follow-up Comment #9, patch #4671 (project freeciv):

Patch that moves the limits to the rulesets and updates the documentation. It
isn't "Ready For Test" since it depends on patch #5020.

(file #21662)
___

Additional Item Attachment:

File name: Move-limits-on-what-terrain-a-spy-action-can-be-done.patch Size:25
KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to the ruleset

[Sveinung Kvilhaugsvik]

Update of patch #4671 (project freeciv):

 Summary: Move limits on what terrain a spy action can be done
from to action enablers => Move limits on what terrain a spy action can be
done from to the ruleset


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev