[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Follow-up Comment #10, patch #4931 (project freeciv): I think the only change that is notable for the user is that units with more than 1 turn of fuel really can wait at all refuel points. Sometimes, the calculation was not done due to a problem of synchronization between the normal and the waited priority queues. I think there is still a case (very rare) the calculation can be not optimal. But it would require a lot of change. I plan to improve this only for 3.0 (when working on generic fueled units). ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Follow-up Comment #9, patch #4931 (project freeciv): Can you summarise the changes players might see as a result of this patch (if any), for release notes? Does it fix any cases where planes could run out of fuel, or anything like that? ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Update of patch #4931 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Update of patch #4931 (project freeciv): Status: Ready For Test = In Progress Assigned to:None = pepeto ___ Follow-up Comment #4: I think a version for earlier branches will be also welcome... ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Update of patch #4931 (project freeciv): Status: In Progress = Ready For Test Planned Release: 2.6.0 = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #5: Attached patch for S2_4 and S2_5. (file #21463) ___ Additional Item Attachment: File name: S2_4_S2_5_pf_fuel_map_adjust.patch Size:14 KB ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Follow-up Comment #2, patch #4931 (project freeciv): Patch #4926, comment 1: I said since bug #20361, there were a SINGLE_MOVE cost hack except for pf_fuel_map. Actually, this was not right. This hack was present there too and I forgot to remove it in patch #4889. This part my be moved to patch #4926 if you want. I made the patch over patch #4926 and patch #4930 so this shouldn't make conflicts. ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Follow-up Comment #3, patch #4931 (project freeciv): Aha, so patch #4926 doesn't actually finish cleaning up the SINGLE_MOVE hack, and so seeing a very similar section being removed in this patch caused me to raise a false positive. My apologies for the noise (I tend to test patches in isolation, and perhaps shouldn't in this sort of situation). Unless you have a strong opinion otherwise, I think it's easier to go with the (incomplete) patch #4926 as-is, and complete the removal of the SINGLE_MOVE hack here (with the attached patch). ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Additional Item Attachment, patch #4931 (project freeciv): File name: pf_fuel_map_adjust.patch Size:13 KB ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4931] pf_fuel_map_iterate(): adjustements
Follow-up Comment #1, patch #4931 (project freeciv): The removal of the obsolete SINGLE_MOVE cost hack will conflict with the application of patch #4926. Which is the right solution here? ___ Reply to this item at: http://gna.org/patch/?4931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
