[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-27 Thread mir3x
Update of patch #5748 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-25 Thread mir3x
Update of patch #5748 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = mir3x  
 Planned Release: = 2.5,2.6, trunk 


___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-24 Thread Louis Moureaux
Follow-up Comment #4, patch #5748 (project freeciv):

Added patch for S2_5.

(file #23611)
___

Additional Item Attachment:

File name: manual-terrain-s25-2.patch.bz2 Size:2 KB


___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-24 Thread Louis Moureaux
Follow-up Comment #3, patch #5748 (project freeciv):

Amended patch not to show which extras can be built (fixed what was broken).
As a side effect, it looks better. S2_5 to come soon.

(file #23609)
___

Additional Item Attachment:

File name: manual-terrain-1.patch.bz2 Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-23 Thread Marko Lindqvist
Follow-up Comment #1, patch #5748 (project freeciv):

 There is an issue with extras having different graphics on
 different terrains (mine).

Extras (2.6-) never do. Old mine special (-2.5) had, but that's solved in
later branches by having two separate extras.

___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-23 Thread Louis Moureaux
URL:
  http://gna.org/patch/?5748

 Summary: [Qt client][Manual] Add terrain page
 Project: Freeciv
Submitted by: louis94
Submitted on: sam. 24 janv. 2015 00:23:14 UTC
Category: client-qt
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

This patch adds a terrain manual page using functions introduced in patch
#5747. Not sure it looks good when there are many resources/transforms.

There is an issue with extras having different graphics on different terrains
(mine). A patch to tilespec.[h,cpp] would be required to solve that
(get_resource_sprite is not enough to draw terrain with resource). I didn't
write it because I'm not sure the design is good enough (it's better than
Gtk's, but still quite not perfect), and I don't feel like doing extra work
that will finally never be used. So I'd be happy to write it if needed.



___

File Attachments:


---
Date: sam. 24 janv. 2015 00:23:14 UTC  Name: manual-terrain.patch.bz2  Size: 3
ko   By: louis94

http://gna.org/patch/download.php?file_id=23598

___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5748] [Qt client][Manual] Add terrain page

2015-01-23 Thread Louis Moureaux
Follow-up Comment #2, patch #5748 (project freeciv):

 Extras (2.6-) never do. Old mine special (-2.5) had, but
 that's solved in later branches by having two separate extras.
Thanks cazfi, you helped me understanding what's going on. My code assumes
there is only one extra per activity. Two options:
- Try to figure out which extra would be built based on reqs (involved)
- Only provide information about bonuses/transforms (really easy)
I'll do the second. I think the terrain help page should list allowed extras,
but I'm not going to add it in the near future.

___

Reply to this item at:

  http://gna.org/patch/?5748

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev