[Freeciv-Dev] [patch #7985] Optimise autoattack transport depth check

2016-11-15 Thread Jacob Nevins 
Update of patch #7985 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7985] Optimise autoattack transport depth check

2016-11-13 Thread Jacob Nevins 
Update of patch #7985 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-autoattack-transport-optim.patch Size:3 KB
File name: S2_5-autoattack-transport-optim.patch Size:2 KB
File name: S2_6-autoattack-transport-optim.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7985] Optimise autoattack transport depth check

2016-11-13 Thread Jacob Nevins 
Additional Item Attachment, patch #7985 (project freeciv):

File name: 25_autoattack.sav.bz2  Size:14 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7985] Optimise autoattack transport depth check

2016-11-13 Thread Jacob Nevins 
Additional Item Attachment, patch #7985 (project freeciv):

File name: 26_autoattack2.sav.bz2 Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7985] Optimise autoattack transport depth check

2016-11-13 Thread Jacob Nevins 
URL:
  

 Summary: Optimise autoattack transport depth check
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 13 Nov 2016 02:10:31 PM UTC
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.6, 2.6.0, 3.0.0
 Contains string changes: No

___

Details:

From my comment in bug #25259:
> A simple optimisation for speed would be to only call unit_transport_depth()
once on each unit.
> Another fiddlier saving (that may not be worth the hassle) would be to
iterate over both transporter stacks in parallel, and bail out when the top of
either one is hit; this saves iterations in the common case where cargo is
compared against non-cargo. Otherwise, if there's a deep nested transport
stack in a stack, we walk its list ~(n log n) times for every defender that
stack could attack.

I haven't measured the improvement (if any), only tested that it doesn't cause
regressions.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev