Re: [Freeciv-Dev] (PR#39785) server crash on unit after coinage in worklist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39785 Daniel Markstedt wrote: I tried to reproduce on 2.1.0-rc1 and the gtk client, but no crash. Do you use another Freeciv version or are there perhaps other factors involved? No crash here, either, but he's certainly not using -rc1, as the line numbers don't match (not even close). Looks like trunk. I did find a possible match in -rc1. The code is hard to understand without comments or even a calling description. But there's no reason to do the next several tests, as they all fail. And then, it will return TRUE at the end. (It always returns TRUE -- after searching the code, FALSE means the city is destroyed.) Probably worth patching in -rc1? Trivial patch, not worth an -rc2. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39785) server crash on unit after coinage in worklist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39785 Timothy Brownawell wrote: Sorry, yes, it's trunk. Last Changed Rev: 13844 I wouldn't bother running trunk, as it's not currently maintained. I'm hoping to poke S2_2 some more as soon as 2.1.0 is released, so try S2_2 instead, there's a lot more debugging ready to go! ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39785) server crash on unit after coinage in worklist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39785 On Sun, 2007-10-21 at 04:54 -0700, William Allen Simpson wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39785 Daniel Markstedt wrote: I tried to reproduce on 2.1.0-rc1 and the gtk client, but no crash. Do you use another Freeciv version or are there perhaps other factors involved? No crash here, either, but he's certainly not using -rc1, as the line numbers don't match (not even close). Looks like trunk. Sorry, yes, it's trunk. Last Changed Rev: 13844 I did find a possible match in -rc1. The code is hard to understand without comments or even a calling description. But there's no reason to do the next several tests, as they all fail. And then, it will return TRUE at the end. (It always returns TRUE -- after searching the code, FALSE means the city is destroyed.) Probably worth patching in -rc1? Trivial patch, not worth an -rc2. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
