Re: [Freeciv-Dev] (PR#36339) [SDL client] no way to save in the gui

2007-09-20 Thread Daniel Markstedt

URL: http://bugs.freeciv.org/Ticket/Display.html?id=36339 

On 9/17/07, Pepeto _ [EMAIL PROTECTED] wrote:

 URL: http://bugs.freeciv.org/Ticket/Display.html?id=36339 

  [dmarks - Lun. Sep. 17 08:11:29 2007]:
 
   [dmarks - Mon Feb 19 05:36:47 2007]:
  
   The SDL client lacks a simple 'save' button (couldn't find one at
  least).
  
~Daniel
  
  
  
 
  I propose this simple (?) solution:
 
  In the options dialog, replace the 'Disconnect' button with a 'Save
  and Quit' one.
  Clicking it will save the game for you and then bring you to the main
  menu. The
  'Quit' button will bring you to the main menu without saving (equal to
  the current
  effect of the 'Disconnect' button.)
 
  Thoughts?
 
   ~Daniel
 
 
 It should depend of is_server_running(). If is_server_running() ==
 FALSE, there is any reason to set a button 'Save and Quit', because it
 should fail.



Agreed. In that case the button should naturally be grayed out.

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39714) Crasher bug introduced in r13286

2007-09-20 Thread William Allen Simpson

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39714 

Petr Baudis wrote:
 ...   Server crashed to me when I was researching
 the last technology in tree and entered a hut with a unit.
 
Mine, am looking at this end case




___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39714) assert(tech != A_FUTURE) debugging

2007-09-20 Thread William Allen Simpson

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39714 

Yes, debugging accidentally left during commit for PR#39525.  Thanks for
the clue!  Committed revision 13614.

Index: common/tech.c
===
--- common/tech.c   (revision 13613)
+++ common/tech.c   (working copy)
@@ -142,7 +142,6 @@
   if (old == value) {
 return old;
   }
-  assert(tech != A_FUTURE);
   research-inventions[tech].state = value;
 
   if (value == TECH_KNOWN) {
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39715) Crash when discovering a Future Tech

2007-09-20 Thread William Allen Simpson

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39715 

That's correct.  This is related to the debugging in PR#39714.

The flags aren't valid for A_FUTURE (or A_UNKNOWN or A_UNUSED), and these
should never be set to TECH_KNOWN.  Where is that happening?

Please send traceback!  And savegame just before event happens!



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39698) 'classic' terrain for 2.1.99

2007-09-20 Thread William Allen Simpson

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39698 

Daniel Markstedt wrote:
 So is it impossible to create a ruleset for 2.1.99 that defines only
 one ocean type?
 
Well, I'm pretty sure there are a couple of ways

The easiest would be to create the world, and then hand edit the file to
change all '.' ',' ';' etc to ' ' ;-)



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39698) 'classic' terrain for 2.1.99

2007-09-20 Thread Daniel Markstedt

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39698 

On 9/21/07, William Allen Simpson [EMAIL PROTECTED] wrote:

 URL: http://bugs.freeciv.org/Ticket/Display.html?id=39698 

 Daniel Markstedt wrote:
  So is it impossible to create a ruleset for 2.1.99 that defines only
  one ocean type?
 
 Well, I'm pretty sure there are a couple of ways

 The easiest would be to create the world, and then hand edit the file to
 change all '.' ',' ';' etc to ' ' ;-)




Ok, so instead of backtracking with 2.2, would it be possible to add a
forward-compatibility layer to 2.1? Simply speaking, the savegame code
would read a 2.2 map and interpret ' ' '.' ',' ';' etc as identical
ocean tiles. I know it sounds hackish, but it would be immensely
helpful.

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39698) 'classic' terrain for 2.1.99

2007-09-20 Thread William Allen Simpson

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39698 

Daniel Markstedt wrote:
 Ok, so instead of backtracking with 2.2, would it be possible to add a
 forward-compatibility layer to 2.1? Simply speaking, the savegame code
 would read a 2.2 map and interpret ' ' '.' ',' ';' etc as identical
 ocean tiles. I know it sounds hackish, but it would be immensely
 helpful.
 
Exactly as civ1 and civ2 in trunk do now? :-)

And your compatibility would last right up until I check-in the civ3-like
land tiles that I posted last May.

You want an editor for 2.1, port the editor to 2.1!

For the record, I'm not in favor of forward-compatibility.  2.1 has
stagnated for 2 years, it's time to put it to bed and move on



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev